ailman/listinfo/overseers
Please see https://sourceware.org/donate.html if you want to
financially support Sourceware.
Sourceware PLC,
Frank Ch. Eigler, Christopher Faylor, Ian Kelling, Ian Lance Taylor,
Tom Tromey, Jon Turney, Mark J. Wielaard, Elena Zannoni
of their patrons as thank you.
https://xeiaso.net/notes/2025/anubis-works/
https://xeiaso.net/patrons/
Cheers,
Mark
icitly also
check that (or file a bug report to check that in the future)?
Thanks,
Mark
> Suggested-by: Constantine Bytensky
> Signed-off-by: Aaron Merey
> ---
> src/readelf.c | 50 +++---
> 1 file changed, 31 insertions(+), 19 deletion
on't have to create a whole valid ELF/Dwarf file. But that proved
trickier than I thought. It does however seem pretty nice for these
kind of tests.
Cheers,
Mark
Hi Dmitry,
On Fri, Apr 04, 2025 at 04:07:26PM +0300, Dmitry V. Levin wrote:
> On Fri, Apr 04, 2025 at 01:55:48PM +0200, Mark Wielaard wrote:
> > So to be (pedantically) correct should we include the attached?
>
> Yes, this should be fine, along with
>
> --- a/lib/crc32.
Hi Dmitry,
On Fri, Apr 04, 2025 at 04:04:21PM +0300, Dmitry V. Levin wrote:
> On Fri, Apr 04, 2025 at 01:38:01PM +0200, Mark Wielaard wrote:
> > But maybe we should just use AC_CHECK_HEADERS([stdatomic.h]) and drop
> > the AC_COMPILE_IFELSE trick?
>
> Sure. And if we want
sten-local only (assuming that
makes sense).
Cheers,
Mark
> ---
> debuginfod/debuginfod.cxx | 115 ++
> doc/debuginfod.8 | 5 ++
> 2 files changed, 84 insertions(+), 36 deletions(-)
>
> diff --git a/debuginfod/debuginfod.cxx
Hi Dmitry,
On Thu, 2025-04-03 at 19:09 +0300, Dmitry V. Levin wrote:
> On Thu, Aug 29, 2019 at 03:16:12PM +0200, Mark Wielaard wrote:
> > From: Jonathon Anderson
> >
> > Uses the stdatomic.h provided by FreeBSD when GCC doesn't (ie. GCC < 4.9)
> >
&
't seen it fail in
armhf for a year, but in the last 9 days it has failed 3 times already
:{
https://builder.sourceware.org/buildbot/#/builders/elfutils-debian-armhf
H,
Mark
> of including config.h twice for all files that include both
> and "system.h".
So to be (pedantically) correct should we include the attached?
Thanks,
Mark
From f14c00adb24bf15059821ca972e5d20a58b893fa Mon Sep 17 00:00:00 2001
From: Mark Wielaard
Date: Fri, 4 Apr 2025 13:50:04 +02
https://sourceware.org/bugzilla/show_bug.cgi?id=29571
Mark Wielaard changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution
tests/run-readelf-z.sh: Add Key to Flags to expected output.
* tests/run-retain.sh: Likewise.
* tests/run-strip-remove-keep.sh: Likewise.
https://sourceware.org/bugzilla/show_bug.cgi?id=29571
Signed-off-by: Samuel Zeter
Cheers,
Mark
CHECK.
(main): Likewise.
Signed-off-by: Mark Wielaard
---
libdw/Makefile.am | 11
libdw/dwarf.h | 2 +
libdw/dwarf_default_lower_bound.c | 2 +
libdw/dwarf_srclang.c | 87 ++-
4 files changed, 101 insertions(
> doc/debuginfod.8 | 5 ++
> 2 files changed, 84 insertions(+), 36 deletions(-)
Looks good, pushed as is.
Thanks,
Mark
On Fri, Mar 14, 2025 at 01:40:42AM +0100, Mark Wielaard wrote:
> The Sourceware Project Leadership Committee would like to know who our
> users are, which hosted projects they feel part of, what services they
> rely on and what the priorities should be for new initiatives.
&
d-off-by line to show they have the right to and grand
others rights to use their contribution. See the CONTRIBUTING file:
https://sourceware.org/cgit/elfutils/tree/CONTRIBUTING#n15
Thanks,
Mark
en there are more places that might need extra guarding (or we have
to write better eu-search wrappers?)
Thanks,
Mark
> Signed-off-by: Aaron Merey
> ---
> libdw/libdw_findcu.c | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/libdw/libdw_findcu
Using [[ is a bashism. We can just use [ since this is a simple
comparision.
* tests/thread-safety-subr.sh: Use if [ instead of if [[.
Signed-off-by: Mark Wielaard
---
tests/thread-safety-subr.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/thread-safety
Hi Michael,
On Thu, Mar 20, 2025 at 02:58:34PM +, Trapp, Michael wrote:
> > Am 19.03.2025 um 13:35 schrieb Mark Wielaard :
> > The code itself does look ok, although I think it could be simplified a
> > little if we go for something like --listen-local only (assuming th
looks good. I believe that means the whole series is
finally fully reviewed and approved. So please do push it.
Cheers,
Mark
Hi Aaron,
On Sun, 2025-03-16 at 21:51 -0400, Aaron Merey wrote:
> * libdw/dwarf_begin_elf.c (dwarf_begin_elf): Init macro_lock.
> * libdw/dwarf_end.c (cu_free): Free src_lock.
> (dwarf_end): Free macro_lock.
> * libdw/dwarf_getsrcfiles.c (dwarf_getsrcfiles): Use src_lock.
>
it
slightly more intuitive to use.
Cheers,
Mark
> * libdwfl/libdwfl.h (Dwfl_Process_Tracker): New struct.
> (dwfl_process_tracker_begin): New function.
> (dwfl_begin_with_tracker): New function.
> (dwfl_process_tracker_end): New function.
> * libdw/libdw.map: Add new functions.
libdwfl function with the above
changes, but I think it is simpler/less work to just make it an
internal libdwflP.h helper function.
Cheers,
Mark
Hi Serhei,
On Sun, Mar 16, 2025 at 07:14:11PM -0400, Serhei Makarov wrote:
> Since libebl is a private interface, subsequent patches in the series
> introduce another api wrapping the libebl perf register handling. In
> this patch, add an interface to access the preferred set of registers
> that
tch 01/13 (it could even
be folded into it.
Cheers,
Mark
> ---
> src/Makefile.am | 4 ++--
> src/stacktrace.c | 48 +---
> 2 files changed, 15 insertions(+), 37 deletions(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
his is used by some backends, where the
> return_address_register actually contains the call address. */
> diff --git a/libebl/libeblP.h b/libebl/libeblP.h
> index c408ed97..29c2402d 100644
> --- a/libebl/libeblP.h
> +++ b/libebl/libeblP.h
> @@ -1,5 +1,5 @@
> /* Internal definitions for interface for libebl.
> - Copyright (C) 2000-2009, 2013, 2014 Red Hat, Inc.
> + Copyright (C) 2000-2009, 2013, 2014, 2025 Red Hat, Inc.
> This file is part of elfutils.
>
> This file is free software; you can redistribute it and/or modify
> @@ -60,6 +60,11 @@ struct ebl
> Ebl architecture can unwind iff FRAME_NREGS > 0. */
>size_t frame_nregs;
>
> + /* Preferred sample_regs_user mask to request from linux perf_events
> + to allow unwinding. Ebl architecture supports unwinding from
> + perf_events sample data iff PERF_FRAME_REGS_MASK > 0. */
> + uint32_t perf_frame_regs_mask;
> +
In all other places the mask is an uint64_t
Also the libebl interface is very verbose for this mask.
Clearly copied from how frame_nregs is done.
So fine for now. But we might want to look into something simpler for
both of these. Both fetching frame_nregs and perf_frame_regs_mask feel
very inefficient.
Cheers,
Mark
located the symbol and/or section
addresses (so whether you are reading the values from memory or on
disk).
Cheers,
Mark
(" L (link order), N (extra OS processing required), G (group), T
> (TLS),");
> + puts (" C (compressed), O (ordered), R (GNU retain), E (exclude)");
> +}
>
> /* Print the program header. */
> static void
The patch itself does look correct. These are the flags that print_shdr
prints if the corresponding shdr->sh_flags are set.
Cheers,
Mark
https://sourceware.org/bugzilla/show_bug.cgi?id=29571
--- Comment #7 from Mark Wielaard ---
(In reply to Sam Zeter from comment #6)
> I also noticed in libelf/elf.h that we define these flags but do not print
> them in readelf:
>
> #define SHF_MASKOS 0x0ff0 /*
that coding like this triggers -Werror=unused-parameter on non-x86.
> I plan to fix this in the next version of the patch.
In some other situations that is "solved" with marking the function
arguments with __attribute__ ((unused)) (which isn't true for x86_64,
but the compiler is fine with that).
Cheers,
Mark
your local
timezone: $ date -d "Fri Mar 14 16:00 UTC 2025"
Thanks,
Frank Ch. Eigler, Christopher Faylor, Ian Kelling, Ian Lance Taylor,
Tom Tromey, Jon Turney, Mark J. Wielaard, Elena Zannoni
.
* tests/Makefile.am (check_PROGRAMS): Add dwarf_language_lower_bound.
(TESTS): Likewise.
(dwarf_language_lower_bound_LDADD): New variable.
Signed-off-by: Mark Wielaard
---
NEWS | 2 +
libdw/dwarf_aggregate_size.c | 8 +-
libdw
.
(dwarf_srclang): If there is no DW_AT_language, try
DW_AT_language_name and DW_AT_language_version, use
language_to_srclang.
Signed-off-by: Mark Wielaard
---
libdw/dwarf_srclang.c | 221 +-
1 file changed, 218 insertions(+), 3 deletions
dwarf_lname_name.
* run-readelf-lnames.sh: New test.
* testfile-lnames.bz2: New testfile.
* tests/Makefile.am (TESTS): Add run-readelf-lnames.sh.
(EXTRA_DIST): Add run-readelf-lnames.sh and
testfile-lnames.bz2.
Signed-off-by: Mark Wielaard
---
libdw/dwarf.h
-dwarf.awk: Handle DW_LNAME.
* libdw/dwarf.h: Add DW_AT_language_name and DW_AT_language_version
plus all currently defined DW_LNAME constants. Add DW_LANG_V and
DW_LANG_Algol68.
* libdw/dwarf_default_lower_bound.c: Add DW_LANG_V and
DW_LANG_Algol68.
Signed-off-by: Mark Wielaard
https://sourceware.org/bugzilla/show_bug.cgi?id=31862
Mark Wielaard changed:
What|Removed |Added
Resolution|--- |FIXED
CC
v3 changes: Add --track-fds to valgrind_cmd when USE_HELGRIND is true.
Looks OK.
Once this is in we should add a buildbot with this enabled.
Thanks,
Mark
f
> *correctness* now, and only complicating locking later when
> serious contention hits to performance are indicated.)
Sure. But I think the current locking proposal, using an indirect lock
from a "parent" object, feels like it is harder to proof correct than
having the lock in the object itself.
Cheers,
Mark
se_lock);
}
return off;
> }
> diff --git a/libdw/libdw_findcu.c b/libdw/libdw_findcu.c
> index 613f61c8..1e96110b 100644
> --- a/libdw/libdw_findcu.c
> +++ b/libdw/libdw_findcu.c
> @@ -179,6 +179,7 @@ __libdw_intern_next_unit (Dwarf *dbg, bool debug_types)
>eu_search_tree_init (&newp->locs_tree);
>rwlock_init (newp->abbrev_lock);
>rwlock_init (newp->split_lock);
> + mutex_init (newp->str_off_base_lock);
>
>/* v4 debug type units have version == 4 and unit_type == DW_UT_type. */
>if (debug_types)
OK.
Cheers,
Mark
e dwarf_macro_getsrclines locking added in this patch.
That makes sense.
> On Wed, Feb 12, 2025 at 8:17 AM Mark Wielaard wrote:
> >
> > Hi Aaron,
> >
> > On Tue, 2025-02-04 at 16:50 -0500, Aaron Merey wrote:
> > > * libdw/dwarf_getsrcfiles.
* libdw/libdwP.h (struct Dwarf): Ditto.
> * libdw/libdw_findcu.c (__libdw_findcu): Ditto.
>
> Signed-off-by: Aaron Merey
>
> ---
> v3 changes: More specific comment for dwarf_lock declaration.
Still not a fan of these recursive mutexes, but the changes themselves
look correct and the extra comments are helpful.
Cheers,
Mark
o create symbol table");
If you check this why not at the point where elf_getdata is called
(symstrdata is assigned?). And then you should also check the other
elf_getdata call at the same time here:
symdata = elf_getdata (unstripped_symtab, NULL);
symstrdata = elf_getdata (unstripped_strtab, NULL);
Thanks,
Mark
r, is pass down that ehdr from handle_notes through the various
handle_* functions.
Cheers,
Mark
> Corrections explained:
> - Added a NULL check for the ehdr variable
>
> Triggers found by static analyzer Svace.
>
> Signed-off-by: Anton Moryakov
> ---
> src/readelf.c
x27;t think scnname can be NULL.
But this code is different from any other print_debug_* code. All
other code uses section_name (Ebl *ebl, GElf_Shdr *shdr) to get the
section name.
So what we could do to make the static analyzer happy is simply do the
same here. I pushed the attached.
Cheers,
Ma
member '%s' contains:\n"), h->ar_name);
>
> elf_end (subelf);
Again subject isn't super helpful and indentation is incorrect.
Also it is easier to switch the check around to:
+ if (h != NULL)
+ printf (_("Archive member '%s' contains:\n"), h->ar_name);
I made those changes and checked this in.
Thanks,
Mark
oper_insert (int oper, const char *arfname, char
> **argv, int argc,
>while ((subelf = elf_begin (fd, cmd, elf)) != NULL)
> {
>Elf_Arhdr *arhdr = elf_getarhdr (subelf);
> +
> + if (arhdr == NULL)
> + goto next;
Likewise.
Thanks,
Mark
st-manyfuncs.sh: Likewise.
* tests/test-manyfuncs.c: New test.
Signed-off-by: Mark Wielaard
---
libelf/elf32_getshdr.c | 14 --
libelf/elf_begin.c | 26 ---
libelf/elf_scnshndx.c| 52 -
libelf/libelf.h | 9 +-
libelf/libelfP.h
https://sourceware.org/bugzilla/show_bug.cgi?id=32684
Mark Wielaard changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resolution
lt against older kernel headers will still be fully
> functional if used on a newer system
This looks very nice. I added a reference to
https://sourceware.org/bugzilla/show_bug.cgi?id=32684 to the commit
message and pushed your commit.
Thanks,
Mark
rage report snapshot work
again: https://snapshots.sourceware.org/elfutils/coverage/latest/
Cheers,
Mark
ating various
fixes since 0.192. Fedora is carrying 8 backports (plus an odd s390x
endian fixup, that is probably not necessary anymore).
https://src.fedoraproject.org/rpms/elfutils/tree/rawhide
Cheers,
Mark
One of the (libcurl) libraries tries to close invalid file descriptors
on fedora s390. Skip running the testsuite under valgrind for now.
---
builder/master.cfg | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builder/master.cfg b/builder/master.cfg
index 0ccd23df9800..7a55e
https://sourceware.org/bugzilla/show_bug.cgi?id=32713
--- Comment #2 from Mark Wielaard ---
See also this kernel thread:
https://lore.kernel.org/all/39fc2866-dff3-43c9-9d40-e8ff30a21...@juniper.net/
Looks like the kernel people believe this in "in spec" so doesn't really b
https://sourceware.org/bugzilla/show_bug.cgi?id=32713
Mark Wielaard changed:
What|Removed |Added
CC||mark at klomp dot org
--- Comment #1
x27;t guaranteed a valid pointer (or NULL) then this could easily
lead to memory leaks.
I would at least report it to glibc to see if this is intentional.
Cheers,
Mark
https://sourceware.org/bugzilla/show_bug.cgi?id=32657
--- Comment #2 from Mark Wielaard ---
Note that someone created CVE-2025-1372 for this bug without following our
SECURITY policy: https://sourceware.org/cgit/elfutils/tree/SECURITY
This is NOT a security issue according to our policy
https://sourceware.org/bugzilla/show_bug.cgi?id=32650
--- Comment #3 from Mark Wielaard ---
Note that someone created CVE-2025-1352 for this bug without following our
SECURITY policy: https://sourceware.org/cgit/elfutils/tree/SECURITY
This is NOT a security issue according to our policy
https://sourceware.org/bugzilla/show_bug.cgi?id=32654
--- Comment #3 from Mark Wielaard ---
Note that someone created CVE-2025-1365 for this bug without following our
SECURITY policy: https://sourceware.org/cgit/elfutils/tree/SECURITY
This is NOT a security issue according to our policy
https://sourceware.org/bugzilla/show_bug.cgi?id=32655
--- Comment #3 from Mark Wielaard ---
Note that someone created CVE-2025-1371 for this bug without following our
SECURITY policy: https://sourceware.org/cgit/elfutils/tree/SECURITY
This is NOT a security issue according to our policy
https://sourceware.org/bugzilla/show_bug.cgi?id=32656
--- Comment #4 from Mark Wielaard ---
Note that someone created CVE-2025-1372 for this bug without following our
SECURITY policy: https://sourceware.org/cgit/elfutils/tree/SECURITY
This is NOT a security issue according to our policy
https://sourceware.org/bugzilla/show_bug.cgi?id=32672
--- Comment #4 from Mark Wielaard ---
Note that someone created CVE-2025-1376 for this bug without following our
SECURITY policy: https://sourceware.org/cgit/elfutils/tree/SECURITY
This is NOT a security issue according to our policy
https://sourceware.org/bugzilla/show_bug.cgi?id=32673
--- Comment #3 from Mark Wielaard ---
Note that someone created CVE-2025-1377 for this bug without following our
SECURITY policy: https://sourceware.org/cgit/elfutils/tree/SECURITY
This is NOT a security issue according to our policy
https://sourceware.org/bugzilla/show_bug.cgi?id=32672
Mark Wielaard changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution
https://sourceware.org/bugzilla/show_bug.cgi?id=32650
Mark Wielaard changed:
What|Removed |Added
Resolution|--- |FIXED
Status|ASSIGNED
https://sourceware.org/bugzilla/show_bug.cgi?id=32654
Mark Wielaard changed:
What|Removed |Added
Resolution|--- |FIXED
Status|ASSIGNED
https://sourceware.org/bugzilla/show_bug.cgi?id=32655
Mark Wielaard changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution
https://sourceware.org/bugzilla/show_bug.cgi?id=32656
Mark Wielaard changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution
https://sourceware.org/bugzilla/show_bug.cgi?id=32673
Mark Wielaard changed:
What|Removed |Added
Resolution|--- |FIXED
Status|ASSIGNED
Hi Aaron,
On Thu, Feb 13, 2025 at 03:35:03PM -0500, Aaron Merey wrote:
> On Mon, Feb 10, 2025 at 1:27 PM Mark Wielaard wrote:
> > When dynsym/str was read through eu-readelf --dynamic by readelf
> > process_symtab the string data was not validated, possibly printing
> > un
Priority: P2
Component: libelf
Assignee: unassigned at sourceware dot org
Reporter: mark at klomp dot org
CC: elfutils-devel at sourceware dot org
Target Milestone: ---
The Elf_Data returned from a SHT_NOBITS section have their d_size set
kes a
message string to display.
(INTERNAL_ERROR): Use INTERNAL_ERROR_MSG with elf_errmsg (-1).
(remove_debug_relocations): Check the sh_link referenced
section is real and isn't a SHT_NOBITS section.
https://sourceware.org/bugzilla/show_bug.cgi?id=32673
Signed-of
https://sourceware.org/bugzilla/show_bug.cgi?id=32673
Mark Wielaard changed:
What|Removed |Added
Assignee|unassigned at sourceware dot org |mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=32684
Mark Wielaard changed:
What|Removed |Added
CC||mark at klomp dot org
--- Comment #1
d yet.
* libelf/elf_strptr.c (elf_strptr): Check strscn->rawdata_base
is not NULL.
https://sourceware.org/bugzilla/show_bug.cgi?id=32672
Signed-off-by: Mark Wielaard
---
libelf/elf_strptr.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/libelf/elf_
t let me know if you want more feedback.
Cheers,
Mark
> tests/Makefile.am | 1 +
> tests/thread-safety-subr.sh | 33 +
> 2 files changed, 34 insertions(+)
> create mode 100644 tests/thread-safety-subr.sh
>
> diff --git a/tests/Makefile.a
ng helgrind now requires enabling annotations
This looks good. It will clash with your recent --track-fds=yes
changes. But that should be easy to resolve (--track-fds works with
both memcheck and helgrind, so you can simply add it to both
valgrind_cmd assignments.
Thanks,
Mark
> configure.ac
;
> +
>if (result->cu == NULL)
> {
>/* This should never happen. The input file is malformed. */
Or if it is needed here, should it also be added in other places where
__libdw_findcu is called? dwarf_cu_dwp_section_info,
dwarf_die_addr_die, dwarf_get_units, dwarf_getaranges, ...
Cheers,
Mark
nlock (cu->dbg->dwarf_lock);
> + return -1;
> + }
> }
>else if (cu->lines == (void *) -1l)
> -return -1;
> +{
> + mutex_unlock (cu->dbg->dwarf_lock);
> + return -1;
> +}
>
>*lines = cu->lines;
>*nlines = cu->lines->nlines;
>
> - // XXX Eventually: unlocking here.
> -
> + mutex_unlock (cu->dbg->dwarf_lock);
>return 0;
> }
> INTDEF(dwarf_getsrclines)
As far as I can see the locking and unlocking is correct here.
Thanks,
Mark
wP.h
> +++ b/libdw/libdwP.h
> @@ -305,6 +305,7 @@ struct Dwarf_Abbrev
> /* Files in line information records. */
> struct Dwarf_Files_s
>{
> + Dwarf *dbg;
> unsigned int ndirs;
> unsigned int nfiles;
> struct Dwarf_Fileinfo_s
So the extra Dwarf dbg field is to have a lock (the dwarf_lock dbg
field) that is only used in dwarf_filesrc? If so, I think it isn't
necessary. But maybe I am confused.
Cheers,
Mark
die_abbrev. */
>rwlock_define(, abbrev_lock);
>
> - /* Synchronize access to the split member of this Dwarf_CU. */
> + /* Synchronize access to the split member of this Dwarf_CU.
> + Covers __libdw_find_split_unit. */
>rwlock_define(, split_lock);
>
>/* Memory boundaries of this CU. */
> diff --git a/libdw/libdw_findcu.c b/libdw/libdw_findcu.c
> index ee5d..613f61c8 100644
> --- a/libdw/libdw_findcu.c
> +++ b/libdw/libdw_findcu.c
> @@ -249,7 +249,7 @@ __libdw_findcu (Dwarf *dbg, Dwarf_Off start, bool
> v4_debug_types)
>if (found != NULL)
> return *found;
>
> - rwlock_wrlock (dbg->dwarf_lock);
> + mutex_lock (dbg->dwarf_lock);
>
>if (start < *next_offset)
> __libdw_seterrno (DWARF_E_INVALID_DWARF);
> @@ -276,7 +276,7 @@ __libdw_findcu (Dwarf *dbg, Dwarf_Off start, bool
> v4_debug_types)
> }
> }
>
> - rwlock_unlock (dbg->dwarf_lock);
> + mutex_unlock (dbg->dwarf_lock);
>return result;
> }
>
Thanks,
Mark
https://sourceware.org/bugzilla/show_bug.cgi?id=32682
Mark Wielaard changed:
What|Removed |Added
Resolution|--- |NOTABUG
Status
https://sourceware.org/bugzilla/show_bug.cgi?id=32682
--- Comment #6 from Mark Wielaard ---
(In reply to Lorinczy Zsigmond from comment #4)
> Thank you for help; the problem occured on Centos7.9/amd64, gcc-14.2
> (compiled from source). I have a predefined CFLAGS settings that includes
&
https://sourceware.org/bugzilla/show_bug.cgi?id=32682
--- Comment #3 from Mark Wielaard ---
Which environment are you using that causes an issue here?
I am trying to figure out if this is some theoretical issue or something that
actually happens.
A concrete example where you are seeing this
https://sourceware.org/bugzilla/show_bug.cgi?id=32682
Mark Wielaard changed:
What|Removed |Added
CC||mark at klomp dot org
--- Comment #1
Hi Anton,
On Mon, 2025-02-03 at 14:45 +0100, Mark Wielaard wrote:
> So the code path where prefix != NULL also implies suffix != NULL.
>
> Maybe the code needs a comment, check or assert to verify this?
I added an assert.
Pushed,
Mark
From 316077dd4b34c90f7e4c4228395a580e99239347 M
https://sourceware.org/bugzilla/show_bug.cgi?id=32672
Mark Wielaard changed:
What|Removed |Added
Assignee|unassigned at sourceware dot org |mark at klomp dot org
Last
x27;t try to gnu decompress a
section without a name.
(print_string_section): Likewise.
https://sourceware.org/bugzilla/show_bug.cgi?id=32656
Signed-off-by: Mark Wielaard
---
src/readelf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/readelf.c b/src/readelf.c
gelf_getphdr returns NULL.
https://sourceware.org/bugzilla/show_bug.cgi?id=32655
Signed-off-by: Mark Wielaard
---
src/readelf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/readelf.c b/src/readelf.c
index c43fda35075a..21b92a08a6b6 100644
--- a/src/readelf.c
+++ b
://sourceware.org/bugzilla/show_bug.cgi?id=32654
Signed-off-by: Mark Wielaard
---
lib/system.h| 27 +++
libelf/elf_strptr.c | 18 --
src/readelf.c | 18 +++---
3 files changed, 42 insertions(+), 21 deletions(-)
diff --git a/lib/system.h b/lib
https://sourceware.org/bugzilla/show_bug.cgi?id=32672
Mark Wielaard changed:
What|Removed |Added
CC||mark at klomp dot org
--- Comment #1
abbrev into abbrevp on success.
* libdw/libdw.h (dwarf_offabbrev): Document return values.
* libdw/libdwP.h (__libdw_getabbrev): Don't take Dwarf_Abbrev
result argument.
https://sourceware.org/bugzilla/show_bug.cgi?id=32650
Signed-off-by: Mark Wielaard
---
libdw/dw
https://sourceware.org/bugzilla/show_bug.cgi?id=32656
--- Comment #2 from Mark Wielaard ---
*** Bug 32657 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
https://sourceware.org/bugzilla/show_bug.cgi?id=32657
Mark Wielaard changed:
What|Removed |Added
CC||mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=32656
Mark Wielaard changed:
What|Removed |Added
Last reconfirmed||2025-02-08
CC
https://sourceware.org/bugzilla/show_bug.cgi?id=32655
Mark Wielaard changed:
What|Removed |Added
Status|UNCONFIRMED |ASSIGNED
Assignee
https://sourceware.org/bugzilla/show_bug.cgi?id=32654
Mark Wielaard changed:
What|Removed |Added
Last reconfirmed||2025-02-08
Assignee
https://sourceware.org/bugzilla/show_bug.cgi?id=32650
Mark Wielaard changed:
What|Removed |Added
Last reconfirmed||2025-02-08
CC
Hi Anton,
I changed the indention from using spaces to tabs and rewrote the
subject line to better explain the change.
Pushed as attached.
Thanks,
Mark
>From 6c76ce7331e82a6fc6c2004e8e6ae51ca91f51d7 Mon Sep 17 00:00:00 2001
From: Anton Moryakov
Date: Wed, 5 Feb 2025 00:50:23 +0300
Subj
Hi Aaron,
On Tue, Feb 04, 2025 at 05:00:21PM -0500, Aaron Merey wrote:
> On Mon, Feb 3, 2025 at 8:36 AM Mark Wielaard wrote:
> > So I don't think close should be called unconditionally. Maybe the
> > correct solution is to do if (!close_fd) close (fd); after elf_end?
the same subelf, so eventually you run
out of memory.
It is probably simpler to just add the check here:
>/* Skip over the index entries. */
>if (strcmp (arhdr->ar_name, "/") != 0
> && strcmp (arhdr->ar_name, "//") != 0)
if (arhdr != NULL
&& strcmp (arhdr->ar_name, "/") != 0
&& strcmp (arhdr->ar_name, "//") != 0)
Cheers,
Mark
1 - 100 of 1237 matches
Mail list logo
