Re: scraperbot protection - Patchwork and Bunsen behind Anubis

2025-04-23 Thread Frank Ch. Eigler
Hi - > We were wondering if it would be possible / suitable to have https > requests served by one container, > and ssh ones by another? Maybe that's already the case though... SSH stuff is already (un)contained. > [...] > so maybe it would help if we switched to ssh access for our CI user > whe

Re: [PATCH 04/13] libdwfl [4/13]: add dwfl_perf_sample_preferred_regs_mask

2025-04-22 Thread Frank Ch. Eigler
Hi - > CCLD libdw.so > /usr/bin/ld: ../libdwfl/libdwfl_pic.a(dwfl_module_getdwarf.os): in function > `open_elf': > Calling a public function across the library boundary should be no problem, > but we run into this -- circular dependency? It might just require the libdw.so LDFLAGS/LDADD to

Re: [PATCH 2/3] src/readelf.c: Support concurrency for -w, --debug-dump

2025-04-05 Thread Frank Ch. Eigler
Hi - > Due to significant lock contention, running eu-readelf when configured > with --enable-thread-safety causes a major performance degradation. > Currently, concurrency may double the runtime of eu-readelf. > However I think this work should still be merged. --enable-thread-safety > is still

Re: [PATCH] Take latest of archive and file mtime

2025-03-13 Thread Frank Ch. Eigler
Hi - > [...] > Every time you rebuild some packages, the package files are rebuilt with the > new contents. When this happens, the new package files will have a newer > mtime, but the files inside the archive (elf, source) will have the same > fixed timestamp as before. Do I understand this part

Re: [patch] PR31862: debuginfod client should cache received x-debuginfod-* headers

2025-03-03 Thread Frank Ch. Eigler
les .cache/debuginfod/BUILDID/PAYLOAD as .cache/debuginfod/BUILDID/hdr-PAYLOAD. They are aged the same atime-based way. Testing via an extension of a previous small test, and hand-running both client & server code under valgrind. No memcheck errors reported. Signe

Re: [PATCH] Take latest of archive and file mtime

2025-03-03 Thread Frank Ch. Eigler
Hi - > [...] > Distributions like Yocto update the RPMs but they set all files inside to > a fixed timestamp, so that internal timestamp doesn't tell if files > changed. > [...] Can you please elaborate on your explanation? I'm afraid I can't quite see why this yocto behaviour should change anyt

Re: [PATCH 2/9 v3] libdw: Add locking to dwarf_getsrcfiles, dwarf_getsrclines, dwarf_macro_getsrcfiles

2025-02-27 Thread Frank Ch. Eigler
Hi - > We should make dwarf_getsrcfiles and dwarf_getsrclines independent so > callers that onle need the file table don't need to "pay" for parsing > the whole line table. (I thought we had a bug for that, but cannot > find it now. If you also cannot find it, please let me know and I'll > file a

[patch] PR31862: debuginfod client should cache received x-debuginfod-* headers

2025-02-21 Thread Frank Ch. Eigler
commit 082c0a94eed6706753e8019ce348be095deb72f9 (HEAD -> main) Author: Frank Ch. Eigler Date: Fri Feb 21 14:33:49 2025 -0500 PR31862: debuginfod: client to cache x-debuginfod-* headers This feature allows the extra http headers from debuginfod to be saved into the cli

Re: [obv] [patch] debuginfod-client memory hygiene

2025-02-20 Thread Frank Ch. Eigler
Hi - > [...] > This does sounds like a bug in glibc sscanf. I cannot find a > description of what exactly happens with 'm' modifier allocated > buffers on error. So I can imagine a double free if sscanf frees the > buffer on error. But returning a bogus pointer? That seems a bug. If > we aren't gu

[obv] [patch] debuginfod-client memory hygiene

2025-02-18 Thread Frank Ch. Eigler
Planning to commit this shortly: commit a71bac67f4705b84368b71f5ece54deedaa1abf1 (HEAD -> master1) Author: Frank Ch. Eigler Date: Tue Feb 18 22:09:12 2025 -0500 debuginfod-client: correct invalid free() in failed ima path debuginfod-find with a failed signature configuration

debuginfod - IMA crypto enforcement status

2025-02-18 Thread Frank Ch. Eigler
Hi - Having upgraded debuginfod.elfutils.org's server to a more modern distro, this machine now can handle the IMA crypto extensions we added to debuginfod not too long ago. It federates to the same debuginfod servers as before, but for those that show "yes" in the "IMA" column, it now applies "i

Re: [RFC] sketch of an unwinder cache interface for elfutils libdwfl

2024-12-12 Thread Frank Ch. Eigler
Hi - > [...] > If there's something we can do here on the glibc side, please let us > know. I think by default, dlclose needs to unmap the address space, so > options might be somewhat limited. But for debugging purposes, I've > long since wanted a mode where dlclose keeps the address space rese

Re: [PATCH] debuginfod: add CORS support

2024-12-08 Thread Frank Ch. Eigler
ore environment variables. Note that the env vars are used for configuring the *client*, because it sometimes embedded deep into other preexisting applications, so we can't easily add command line options. - FChE >From e574f0089a2389267a95417c11ae5aa42a5b8bf8 Mon Sep 17 00:00:00 2001 From:

Re: [PATCH] debuginfod: add CORS support

2024-12-08 Thread Frank Ch. Eigler
Hi - > [...] > I think it will allow public web clients to exfiltrate debuginfo data > from debuginfod servers on private intranets. Previously, the > cross-origin restrictions on web content would have prevented that. Yes, this is the flip side of the CORS default coin. ISTM the convenience is

Re: [PATCH] debuginfod: add CORS support

2024-12-07 Thread Frank Ch. Eigler
Hi - I'm planning to commit this shortly: >From 4ebefc8f3b4b8fb68a55c960e70122fda50a0fb9 Mon Sep 17 00:00:00 2001 From: "Frank Ch. Eigler" Date: Sat, 7 Dec 2024 15:01:54 -0500 Subject: [PATCH] debuginfod: add CORS response headers and OPTIONS method From: Henning Meyer

Re: [PATCH] debuginfod: add CORS support

2024-12-04 Thread Frank Ch. Eigler
Hi - > This is my first attempt at implementing CORS support in debuginfod. Looks good to me really; will wait for a glance from others. > I should probably add or change tests. [...] I wouldn't overthink it - just add a "-i" to any random curl command and look for ACAO:*. I reconfigured the d

Re: Accessing debuginfod from web browsers

2024-12-03 Thread Frank Ch. Eigler
Hi - > I am working on a DWARF parser and visualizer as a web app, Neat. > [...] debuginfod currently does not do that, it does not respond to > OPTIONS method and it does not send the |Access-Control-Allow-Origin > header. I don't think there are any security downsides to enabling > this opti

Re: [PATCH] Fix potential handle leak by ensuring dlclose is always called on debuginfod_so

2024-11-01 Thread Frank Ch. Eigler
Hi - > first report > HANDLE_LEAK.EX The handle 'debuginfod_so' is created at > debuginfod-client.c:104 by calling function 'dlopen' and lost at > debuginfod-client.c:129. > second report > HANDLE_LEAK.EX The handle 'debuginfod_so' is created at > debuginfod-client.c:107 by calling function 'dl

Re: [PATCH] debuginfod-client.c: add dlclose call to prevent resource leak

2024-11-01 Thread Frank Ch. Eigler
Hi - On Fri, Nov 01, 2024 at 07:37:03PM +0300, Anton Moryakov wrote: > Previously, the handle debuginfod_so created by dlopen was not closed > in all cases, leading to a potential resource leak. This commit adds an > additional dlclose call to ensure that the handle is always properly > release

Re: [PATCH] PR32218: debuginfod-client: support very long source file

2024-10-15 Thread Frank Ch. Eigler
ase debugging, uncomment: > > +set -x > > Missing # ? Or use it just unconditionally? I *love* set -x unconditionally, so tweaked the comment. (IMO test-subr.sh should set this for all our tests.) patch v2: >From 4023ad1a81f31ae404c2959bad752d05ad2bb3b9 Mon Sep 17 00:00:00 2001 F

[PATCH] PR32218: debuginfod-client: support very long source file

2024-10-10 Thread Frank Ch. Eigler
>From be79d138989b9968f9c687ef62cc91b5b93e32b5 Mon Sep 17 00:00:00 2001 From: "Frank Ch. Eigler" Date: Thu, 10 Oct 2024 16:30:19 -0400 Subject: [PATCH] PR32218: debuginfod-client: support very long source file names debuginfod clients & servers may sometimes encounter very

Re: [patch] test tempdir move

2024-10-09 Thread Frank Ch. Eigler
Hi - > I like the idea of this change. Some nitpicks below. Those were great ideas, v2 below: >From 65efbafc16fffa582a84c277493d2531bf88021a Mon Sep 17 00:00:00 2001 From: "Frank Ch. Eigler" Date: Wed, 9 Oct 2024 13:41:14 -0400 Subject: [PATCH] tests/test-subr.sh: Put test_di

[patch] test tempdir move

2024-10-09 Thread Frank Ch. Eigler
Hi - I find the following patch makes make checks bearable again. >From 0acce289fbb9c4da6a6ec1868eed5ede5a62e63d Mon Sep 17 00:00:00 2001 From: "Frank Ch. Eigler" Date: Wed, 9 Oct 2024 13:41:14 -0400 Subject: [PATCH] tests/test-subr.sh: Put test_dir under /var/tmp. Every indiv

Forw: [RFE] Improve handling of framepointer-based backtraces for function prologue samples

2024-09-11 Thread Frank Ch. Eigler
Hi - wcohen wrote this to linux-perf-users@, touching on unwinding and especially eu-stacktrace comparison subjects. https://www.spinics.net/lists/linux-perf-users/msg44812.html - FChE

[patch] debuginfod metadata query timeout enforcement

2024-09-03 Thread Frank Ch. Eigler
Hi - Proposed patch for a problem we spotted recently in unreleased code: commit b853004e723d058f97362dbfdc40d1c49ea2ef51 (HEAD -> main) Author: Frank Ch. Eigler Date: Tue Sep 3 11:27:36 2024 -0400 debuginfod: service metadata queries in separate, timed-out connections

debuginfod service for rpmfusion content

2024-08-31 Thread Frank Ch. Eigler
Hi - We have recently started snapshotting rpmfusion content for purposes of distributing its debugging data. https://debuginfod.systemtap.org/ is a part of the elfutils debuginfod federation, and is now serving all present and forseeable-future rpmfusion debug content. https://bugzilla.rpmfusi

Re: [PATCH v3 0/7] debuginfod: speed up extraction from kernel debuginfo packages by 200x

2024-07-19 Thread Frank Ch. Eigler
Hi - > This is v3 of my patch series optimizing debuginfod for kernel > debuginfo. v1 is here [7], v2 is here [8]. This version fixes a couple > of minor bugs and adds test cases. [...] Thanks, LGTM, running through try-buildbots to make sure. - FChE

Re: [PATCH v2 0/5] debuginfod: speed up extraction from kernel debuginfo packages by 200x

2024-07-16 Thread Frank Ch. Eigler
Hi - > [...] I'll send it through the testsuite > trybots here. [...] There was some success and there was some failure. :-) all 11 runs: https://builder.sourceware.org/testruns/?commitishes=&has_expfile_glob=&has_trsfile_glob=&has_keyvalue_k=testrun.git_describe&has_keyvalue_op=glob&has_keyva

Re: [PATCH v2 0/5] debuginfod: speed up extraction from kernel debuginfo packages by 200x

2024-07-16 Thread Frank Ch. Eigler
Hi - > This is v2 of my patch series optimizing debuginfod for kernel > debuginfo. v1 is here [7]. This generally looks great to me. I'll send it through the testsuite trybots here. But there isn't an xz-y test case yet. Is there a smallish seekable-xz rpm file that you have or could make tha

Re: [PATCH 0/3] debuginfod: speed up extraction from kernel debuginfo packages by 200x

2024-07-11 Thread Frank Ch. Eigler
Hi, Omar - Thanks. I wish this sort of amazing kludge weren't necessary, but given that it helps, so be it. I'd like to commend you on the effort needed to match your code up with the stylistic idiosyncracies of the debuginfod c++ code. It looks just like the other code. My only reservation is

Re: [PATCH 1/2] libdwfl: specify optional sysroot to search for shared libraries and binaries

2024-07-02 Thread Frank Ch. Eigler
Hi - > > > [...] For example, we might be looking at a core file from an ARM > > > system using elfutils running on an x86 host. [...] > > > > Makes sense. By the way, to what extent would debuginfod (serving > > files from that sysroot) work for this same use case? > [...] > Frankly I don't kno

Re: [PATCH 1/2] libdwfl: specify optional sysroot to search for shared libraries and binaries

2024-07-01 Thread Frank Ch. Eigler
Hi - > [...] For example, we might be looking at a core file from an ARM > system using elfutils running on an x86 host. [...] Makes sense. By the way, to what extent would debuginfod (serving files from that sysroot) work for this same use case? - FChE

Re: [PATCH] Add man pages for some libelf functions

2024-06-19 Thread Frank Ch. Eigler
Aaron Merey writes: > [...] By the way, in addition or instead of using tarballs for carrying this bulk content toward review, a git branch holding it all work about as well. - FChE

Re: make dist considered harmful: odd gotcha with building elfutils rpms

2024-06-15 Thread Frank Ch. Eigler
mark wrote: > [...] Having each committer push generated files with their own > variant of the tools causes generates updates that are hard to sanity > check by others. Indeed. Luckily, configury changes are rare, and distractingly wordy generated-code-diffs are rarer. And if they are indeed

Re: make dist considered harmful: odd gotcha with building elfutils rpms

2024-06-11 Thread Frank Ch. Eigler
Hi - > That is certainly a bug, dist targets shouldn't be conditional. Thanks! > [...] > > But I think the root cause is more the continued reliance > > on "make dist", made necessary by the exclusion of generated autoconf* > > materiel in the source tree. > > I really don't think putting gen

make dist considered harmful: odd gotcha with building elfutils rpms

2024-06-11 Thread Frank Ch. Eigler
Hi - While trying to get a reliable fedora-copr build of the git/master snapshot of elfutils, I ran into a problem that took me too long to figure out. I was running "make rpm" from an elfutils build tree, which involves running a "make dist" substep to produce a complete buildable source tarball

git/master snapshot debuginfod deployed to fedora.stg server

2024-06-07 Thread Frank Ch. Eigler
Hi - Open for your experimentation needs, on a recent fedora client and a fresh build of elfutils, env DEBUGINFOD_URLS='ima:enforcing https://debuginfod.stg.fedoraproject.org' \ DEBUGINFOD_IMA_CERT_PATH=/etc/keys/ima \ DEBUGINFOD_VERBOSE=1 \ debuginfod-find debuginfo /bin/ls should r

PATCH: debuginfod configury rework

2024-06-04 Thread Frank Ch. Eigler
Hi - A few buildbots are unhappy with the debuginfod configury from yesterday. It's right: it's rather convoluted. This patch reworks and harmonizes all of that stuff. Author: Frank Ch. Eigler Date: Mon Jun 3 18:14:52 2024 -0400 rework debuginfod configury Rewo

Re: [patch] debuginfod metadata extension

2024-06-01 Thread Frank Ch. Eigler
Hi - > Thanks for the patch, some suggestions below. Thanks, adding the following 'git diff -w' to the patch you reviewed: > [...] > I was experimenting with metadata queries to a local server that indexed > a single rpm (binutils-2.41-8.fc40.x86_64.rpm). The following commands > produced JSON w

Re: [PATCH] Support nullglob in profile.sh.in

2024-05-13 Thread Frank Ch. Eigler
Hi - > > Don't block on stdin when /etc/debuginfod/*.certpath expands to nothing. > > Signed-off-by: Andreas Schwab Thanks, committed as obvious. > I slightly prefer "cat but this variant is also fine. I see your point, but the other five cases in the profile.* use this formulation, so for s

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

2024-05-09 Thread Frank Ch. Eigler
Hi - > Well, even if it happened unintentionally, it was ignored just the same > as if it happened on purpose. I hope the technical reasons for that > are now fixed, and won't cause any problems next time. You have been in the open source community long enough to know that emails sometimes just

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

2024-05-09 Thread Frank Ch. Eigler
Hi - > > > What's the purpose of sending proposed patches to the mailing list > > > if reviews are silently ignored? > > > > Please be collegial and don't exaggerate. > > The fact is that the review was silently ignored, which is, from my point > of view, an extraordinary event, The review *si

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

2024-05-09 Thread Frank Ch. Eigler
Hi - On Fri, May 10, 2024 at 12:53:39AM +0300, Dmitry V. Levin wrote: > > Pushed as commit ca8ad4648197 > > What's the purpose of sending proposed patches to the mailing list > if reviews are silently ignored? Please be collegial and don't exaggerate. - FChE

Re: [rfc] [patch] PR28204: debuginfod ima signature verification

2024-05-04 Thread Frank Ch. Eigler
Hi - On Tue, Apr 16, 2024 at 06:15:00PM -0400, Frank Ch. Eigler wrote: > The following is the candidate patch for the basic functionality. > It's been corrected for whitespace & error codes, given more complete > docs and commit message. See also the users/fche/try-bz2824f bra

Re: [rfc] [patch] PR28204: debuginfod ima signature verification

2024-04-16 Thread Frank Ch. Eigler
d-find.1, doc/debuginfod_find_debuginfo.3: Update SECURITY. * tests/run-debuginfod-ima-verification.sh: New test. * tests/debuginfod-ima: Some new files for the tests. * tests/Makefile.am: run/distribute them. Signed-off-by: Ryan Goldberg Signed-off-by: Frank Ch. Eigler diff -

Re: [rfc] [patch] PR28204: debuginfod ima signature verification

2024-04-11 Thread Frank Ch. Eigler
Hi - > > IOW, without a "permissive" mode being available at all, we could not > > ask users to enable this new code at all for our own federated > > servers, nor even for fedora. That's because no server can guarantee > > the availability of signatures for all content they can serve. > > I don'

Re: [rfc] [patch] PR28204: debuginfod ima signature verification

2024-04-10 Thread Frank Ch. Eigler
Hi, Mark - > > - to drop "permissive" mode > > We discussed a bit on irc about "wording". But I think it isn't really > how it is worded, but that there is just different features. What is > called "enforcing" is an authenticity scheme. While "permissive" is > more like an (optional) error-detec

Re: Inquiry about Development Features and Integration of Source Code Version Control Systems

2024-04-10 Thread Frank Ch. Eigler
Hi - > Support for reading source code directly from a code hosting service > (such as GitHub) has been supported for years by Microsoft via > SourceLink[1]. [...] Thanks for that reminder. Yeah, eventually that could be an alternate way. > [...] > > Can you explain under what situations you th

Re: Inquiry about Development Features and Integration of Source Code Version Control Systems

2024-04-10 Thread Frank Ch. Eigler
Hi - > [...] Specifically, I am interested in understanding how the > Debuginfod Server can facilitate the direct download of source code > from Git repositories. [...] Can you explain under what situations you think this would be helpful? The main challenge is that compilers don't generally ha

[rfc] [patch] PR28204: debuginfod ima signature verification

2024-04-03 Thread Frank Ch. Eigler
_match): Added extraction of the + per-file IMA signature for the queried file and store in http header. + * (find_globbed_koji_filepath): New function. + * (parse_opt): New flag --koji-sigcache. + * debuginfod-client.c (debuginfod_query_server): Added policy for +

Re: [PATCH] srcfiles: fix unused variable BUFFER_SIZE

2024-03-19 Thread Frank Ch. Eigler
Hi - > The const variable BUFFER_SIZE is used only on the zip_files > function witch is only available with LIBARCHIVE. Thanks, merged as obvious. - FChE

Re: [PATCH] debuginfod.cxx: periodically malloc_trim()

2024-03-18 Thread Frank Ch. Eigler
Hi - > From: Di Chen > Date: Mon, 18 Mar 2024 09:06:19 +0800 > Subject: [PATCH] debuginfod.cxx: periodically malloc_trim() > > Add malloc_trim() for releasing memory which is allocated for temporary > purposes, e.g. answering queries, adding data to the database during > scans. > > https://sour

Re: [PATCH] debuginfod: Remove unused variable

2024-03-10 Thread Frank Ch. Eigler
Khem Raj writes: > Recent commit acd9525e9 has removed all references to max_fds > therefore remove it, moreover clang18 is happier Thanks, merged as obvious. - FChE

Re: [PATCH v2] dwarf_getaranges: Build aranges list from CUs instead of .debug_aranges

2024-02-22 Thread Frank Ch. Eigler
Hi - > > We could then also introduce a new public function, dwarf_getdieranges > > (?) that does the new thing. But it doesn't have to be public on the > > first try as long as dwarf_addrdie and dwfl_module_addrdie work. (We > > might want to change the interface of dwarf_getdieranges so it can b

[PATCH] PR31265 - rework debuginfod archive-extract fdcache

2024-02-12 Thread Frank Ch. Eigler
Hi - I plan to roll out this improvement to all the servers I look after, via COPR builds or such, it's that impactful. commit 7bfc10acc7f0e00c5bc45416d1bf8ee183d79ff3 (HEAD -> master) Author: Frank Ch. Eigler Date: Thu Feb 8 19:33:55 2024 -0500 PR31265 - rework debuginfod

Re: [PATCH] PR 30991: srcfiles tarball feature

2024-02-06 Thread Frank Ch. Eigler
Hi - > > > - // This is a common symptom for dwz-compressed debug files, > > > - // where the altdebug file cannot be resolved. > > Was it intended to remove this comment? Yes, it was copy/pasted from debuginfod by mistake. - FChE

[patch] debuginfod.8

2023-11-14 Thread Frank Ch. Eigler
commit 06e0aacb4b288403bd02a0820dd0f87c7f017a2b (HEAD -> master) Author: Frank Ch. Eigler Date: Tue Nov 14 14:09:40 2023 -0500 doc/debuginfod.8: clarify source file handling Added text about the archive common-prefix heuristic, mentioned the new eu-srcfiles tool, and g

Re: [PATCH] PR28204, debuginfod IMA

2023-11-14 Thread Frank Ch. Eigler
Hi - > >\fIima:optimistic\fP Every downloaded file with a known-invalid > >signature is rejected, protecting against some types of corruption. > > I like this wording more. But maybe it would be helpful to split the > patch into one that implements ima:enforcing and another that adds the

Re: [PATCH] readelf: Support .gdb_index version 9

2023-11-02 Thread Frank Ch. Eigler
Hi - > OK. BTW the description of the gdb_index at the top > https://sourceware.org/gdb/current/onlinedocs/gdb/Index-Section-Format.html > doesn't resolve anymore. It is now > https://sourceware.org/gdb/current/onlinedocs/gdb.html/Index-Section-Format.html Added another httpd redirect to make th

Re: [PATCH] PR28204, debuginfod IMA

2023-10-31 Thread Frank Ch. Eigler
Hi, Mark - > > Considering how easily the trybots can process the actual code - and > > have done so before posting the patch for review - we can consider > > some CI well done already. After approval but before merge, it would > > undergo another round of trybotting. With such workflow, patchw

regarding the "Abusing gdb Features for Data Ingress & Egress" paper

2023-10-29 Thread Frank Ch. Eigler
Hi - A few days ago, I was pointed to a paper [1] from a security researcher that deals with debuginfod. The first half of the paper is a fine overview of how the system works. [1] https://www.archcloudlabs.com/projects/debuginfod/ The second half takes a turn toward security concerns. I'd lik

Re: [PATCH] PR28204, debuginfod IMA

2023-10-27 Thread Frank Ch. Eigler
Hi - > > I would not expect the emailed patch to apply, esp. with all the other > > work done in the intermediate months, which is why the code is also in > > the git branch. The binary files do not seem effectively reviewable > > anyway. > > It would be really convenient though. And modern git

Re: [PATCH] PR28204, debuginfod IMA

2023-10-24 Thread Frank Ch. Eigler
Hi - Thanks for the review. > [...] > BTW. The diff doesn't show the newly added binary files. So the patch > cannot be applied. Please use git send-email or git format-patch for > that. I would not expect the emailed patch to apply, esp. with all the other work done in the intermediate months,

Re: PR30000 - introduce new srcfiles tool

2023-10-23 Thread Frank Ch. Eigler
Hi - On Thu, Sep 28, 2023 at 10:59:38AM -0400, Housam Alamour via Elfutils-devel wrot > Here is the new srcfiles tool ready for review. This lgtm. - FChE

[PATCH] debuginfod PR29472: metadata queries

2023-10-18 Thread Frank Ch. Eigler
users/fche/try-pr29472 branch. Before a final commit, might nuke the ChangeLog bits and copy key content over into the git commit message. commit 8dd1108b6779b8efd5e4037e0653de7702839cc8 Author: Frank Ch. Eigler Date: Tue Apr 11 23:35:25 2023 -0400 PR29472: debuginfod: add metadata query

Re: PATCH PR30962, debuginfod

2023-10-11 Thread Frank Ch. Eigler
Hi - > OK. But I think you should add an explanation or example to "Front-end > proxies can also elide sensitive path name components" paragraph. So > the user is fully aware what those "sensitive path names" are. Maybe > even add that debuginfod-find -v example so people can double check. OK, re

Re: PATCH PR30962, debuginfod

2023-10-11 Thread Frank Ch. Eigler
Hi - > I think this makes sense, but it would be good to see an example of the > paths this now exposes. e.g: % debuginfod-find -v debuginfo /bin/ls [...] x-debuginfod-size: 502024 x-debuginfod-archive: /mnt/fedora_koji_prod/koji/packages/coreutils/9.3/4.fc39/x86_64/coreutils-debuginfo-9.3-4.fc3

PATCH PR30962, debuginfod

2023-10-10 Thread Frank Ch. Eigler
commit e967988e419121cad1d7f40013a316059b1173f0 Author: Frank Ch. Eigler Date: Tue Oct 10 16:21:00 2023 -0400 PR30962: debuginfod: full paths for X-DEBUGINFOD-FILE/ARCHIVE response headers Previous code was inconsistent in offering basename versus full pathname for these

Re: [PATCH] PR30879: debuginfod intermittent terminate()

2023-10-01 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > The new terminate_handler seems really useful, I wonder why something > like this isn't the default behaviour. Yeah. > I think I understand the idea behind wrapping scan () to catch the > reportable_exception. Yup. > The sqlite_checkpoint_pb looks simpler now. But I must admit I don't >

Re: [PATCH 00/14] elfutils: DWARF package (.dwp) file support

2023-09-27 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > This patch series adds support for DWARF package files to libdw and the > elfutils tools. It supports the GNU DebugFission format for DWARF 4 [1] > and the format standardized in DWARF 5 (section 7.3.5 "DWARF Package > Files"). It supports both automatically opening the .dwp file for a > sk

[PATCH] PR30879: debuginfod intermittent terminate()

2023-09-22 Thread Frank Ch. Eigler via Elfutils-devel
Author: Frank Ch. Eigler Date: Fri Sep 22 15:30:51 2023 -0400 PR30879: intermittent debuginfod crash with unhandled exception Code inspection identified two places where sqlite_ps objects were being created/used outside try/catch protection. This patch wraps or replaces

Re: Building Elfutils with Mingw32

2023-09-18 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > [...] I would prefer to use MinGW instead of Cygwin. For some extra > context, we use the Yocto Project to build our Embedded Linux > images, which can provide a cross compiler toolchain and other host > development tools for Windows using MinGW. [...] FWIW, I'm not aware of any conflict b

Re: Building Elfutils with Mingw32

2023-09-13 Thread Frank Ch. Eigler via Elfutils-devel
Hi, Colin - > I'm currently trying to determine the level of effort required to > compile Elfutils for Windows using MinGW. I'd like to get a version > of Elfutils compiled with libdebginfod in order to compile GDB with > debuginfod support on Windows. I've currently explored two > avenues... Nic

[PATCH] PR28204, debuginfod IMA

2023-09-07 Thread Frank Ch. Eigler via Elfutils-devel
es are also searched. See $DEBUGINFOD_IMA_CERT_PATH. These certificates are assumed trusted. Signed-off-by: Ryan Goldberg Signed-off-by: Frank Ch. Eigler diff --git a/ChangeLog b/ChangeLog index 6aed95b6974e..b3b1a8ebc93a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@

PR30809, was Re: [PATCH v2 2/2] debuginfod-client.c: Fix x-debuginfod-size counts differently than CURLINFO_SIZE_DOWNLOAD_T

2023-08-29 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > What is the status of this patch/discussion? U forgot about it. But that's OK, filed PR30809, and wrote & tested this little patch: commit 3ef3fab0d64c89a52dd6e2ce0d01dd5e713d7b5a Author: Frank Ch. Eigler Date: Tue Aug 29 14:08:04 2023 -0400 PR30809: improv

Re: Fwd: Anton Baltser, bug with libdebuginfod

2023-07-30 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > I need to install > I tried to install elfutils - 0.189 version , and I could solve installing > libdebuginfod. > My system ubuntu 20.04/wsl2 > > I used ./configure --prefix=/usr\ > --disable-debuginfod \ > --enable-libdebuginfod=dummy \

Re: Performance issue with systemd-coredump and container process linking 2000 shared libraries.

2023-06-21 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > On our side Francois also told me this afternoon that he didn’t > really reproduce the same thing with my reproducer posted here and > the real systemd-coredump issue he witnessed live, and also noticed > that with DEBUGINFOD_URLS unset/set to the empty string my > reproducer has no problem

Re: Local Build ID Directory Lookup (DEBUGINFOD_LOCAL_PATH)

2023-06-01 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > Hmm, how would the effective behavior of this differ from directly > returning the path? The symlink could become invalid at any time [...] Effective behaviour is about the same, but code logic and explanation is simpler. > It would make sense if the cache were made to contain a hard link

Re: Local Build ID Directory Lookup (DEBUGINFOD_LOCAL_PATH)

2023-06-01 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > So I guess, sans the format, the feature request would just be that > it would have a shortcut for file URLs to produce the path directly > in response to e.g. a debuginfod_find_debuginfo, rather than making > a copy of the file via libcurl. A compromise solution could be for new code to p

Re: Local Build ID Directory Lookup (DEBUGINFOD_LOCAL_PATH)

2023-05-31 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > Ah, I had forgotten completely that file URLs worked out of the box > (libcurl, duh). Yeah. > When we tried that way back when, the issue was just that it > actually does a libcurl fetch out of that path and saves another > copy of the file into the cache. Yes, a copy is made. This is "

Re: Local Build ID Directory Lookup (DEBUGINFOD_LOCAL_PATH)

2023-05-31 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > [...] > It would be really nice if there were, a DEBUGINFOD_LOCAL_PATH environment > variable that provided a colon-separated list of directories in the GDB > `.build-id//` [...] Please note that $DEBUGINFOD_URLS can already include file:// URLs that identify local filesystems whose direct

Re: Segfault in dwfl_module_getsrc

2023-05-09 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > I tried to use elfutils to retrieve the backtrace within a signal handle, > but I am having a segfault inside `dwfl_module_getsrc`. > [...] A red flag is "within a signal handler". The kinds of code that one may safely invoke in a signal handler are highly limited. Most elfutils function

[patch]: PR30316: debuginfod wal checkpointing

2023-05-08 Thread Frank Ch. Eigler via Elfutils-devel
Hi - This is patch 2/2 of this series. commit 9b70bce69268eaae7621791ba7c72639469d4a69 Author: Frank Ch. Eigler Date: Mon May 8 11:05:48 2023 -0400 PR30316: debuginfod wal checkpointing Add a "--scan-checkpoint=NUM" option to debuginfod to control forced synch

[patch] PR30378: debuginfod, _files table compression

2023-05-08 Thread Frank Ch. Eigler via Elfutils-devel
Hi - This is patch 1 of 2 of important filesystem usage reduction work for debuginfod. commit 8ee1cc26b08f773c1c6d2f8ed2f68a88534cf93d Author: Frank Ch. Eigler Date: Fri May 5 13:56:23 2023 -0400 debuginfod: PR30378: better compression for _files table Split the _files table

[patch] PR30377: debuginfod -r -X

2023-04-21 Thread Frank Ch. Eigler via Elfutils-devel
Hi - Planning to push this one-liner fix shortly. A new test case exercises the -r / -I / -X ops. commit bc6c774dfb61ac61a66195a269579544f97eeb30 Author: Frank Ch. Eigler Date: Fri Apr 21 17:04:08 2023 -0400 PR30377: fix debuginfod -r -X combination Until this fix, debuginfod

[patch] [obv] PR30348: debuginfod: retry partial archive scans

2023-04-13 Thread Frank Ch. Eigler via Elfutils-devel
Planning to push this shortly: Author: Frank Ch. Eigler Date: Thu Apr 13 13:11:56 2023 -0400 PR30348: debuginfod: retry partial archive scans On some public debuginfod servers, it was observed that errors may occur during individual archive scanning operations. That&#

PR29472: debuginfod metadata query

2023-04-12 Thread Frank Ch. Eigler via Elfutils-devel
Hi - At long last, for your review, an updated & merged patch for $SUBJECT. "git diff -s" against git/master follows, code also on users/fche/try-pr29472e. Author: Frank Ch. Eigler Date: Tue Apr 11 23:35:25 2023 -0400 PR29472: debuginfod: add metadata query webapi,

Re: Some ideas for process improvements/changes

2023-04-06 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > - Get rid of ChangeLog files and trivial ChangeLog entries > [...] Yes please! > - Use patchwork more > [...] This doesn't seem like something for community/contributors to do - patchwork seems mostly a maintainer/committer tool. > It would be nice if it was automated a bit more b

Re: [PATCH v2 2/2] debuginfod-client.c: Fix x-debuginfod-size counts differently than CURLINFO_SIZE_DOWNLOAD_T

2023-03-30 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > > Hey, great idea actually tallying up writes in the callback function. > > (We need to take care to clear that counter, in case of client object > > reuse.) Also, can you think of some reason not to just use that value > > at all times, i.e., without any of that "if and only if ..." busin

Re: [PATCH 3/3] debuginfod: When retrieving files from cache, update atime manually

2023-03-29 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > The cache cleaning logic requires atime to be correct (strictatime) but > most users on Linux only have relatime or even noatime. This is not really correct: relatime is the kernel default and works fine with the cache. atime values updated once a day are still plenty for caches with a mu

Re: [PATCH v2 1/2] debuginfod-client.c: Fix download size not correctly fallbacks to x-debuginfod-size header

2023-03-29 Thread Frank Ch. Eigler via Elfutils-devel
> +2023-03-29 lilydjwg > + > + * debuginfod/debuginfod-client.c: Fix download size not correctly > + fallbacks to x-debuginfod-size header Thanks, merged. - FChE

Re: [PATCH 1/3] debuginfod: Replace futimes with futimens

2023-03-29 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > Similar to what 8c4aa0ef998191ed828a37190dc179b91649938a did for ar and > strip, replace the non-standard futimes with the POSIX futimens. Thanks, merged (with a little ChangeLog thing added ... please free us, mjw!). - FChE

Re: [PATCH v2 2/2] debuginfod-client.c: Fix x-debuginfod-size counts differently than CURLINFO_SIZE_DOWNLOAD_T

2023-03-29 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > x-debuginfod-size is the actual file size, but CURLINFO_SIZE_DOWNLOAD_T > is transferred size, i.e. the gzipped one if gzip is on. > Let's count written data and use that if and only if x-debuginfod-size > is used. Hey, great idea actually tallying up writes in the callback function. (We n

Re: [PATCH] debuginfod-client.c: Fix download size not correctly fallbacks to x-debuginfod-size header

2023-03-29 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > [...] > The reason is that when Content-Length is unavailable, cl is set to -1 > by curl Is that behaviour from new versions of curl? > but dl_size remains as 0, but later dl_size == -1 is checked. Or perhaps dl_size needs to be initialized to -1 ("unknown") vs 0 ("known to be zero"), a

Re: [PATCH v2 4/7] x86_64_return_value_location: Support lvalue and rvalue references

2023-02-10 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > $ cat 1.cpp > int &foo() { throw; } > int &&bar() { throw; } > $ g++ -g 1.cpp -c > and then running > > $ LD_LIBRARY_PATH=../libelf:../libdw ./funcretval -e 1.o > > What would be a good way to integrate such a testcase? > Currently all tests are built with gcc, is it okay to add one > bui

Re: ☠ Buildbot (Sourceware): elfutils - failed test (failure) (master)

2023-02-08 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > > A new failure has been detected on builder elfutils-gentoo-sparc while > > building elfutils. > > > > Full details are available at: > > https://builder.sourceware.org/buildbot/#builders/225/builds/10 > > - test-suite.log: > > https://builder.sourceware.org/buildbot/#builder

preservation of signed rpms

2023-01-26 Thread Frank Ch. Eigler via Elfutils-devel
Hi - Recently, fedora koji has started applying per-file (IMA) signatures to RPMs it has built. This is in addition to the overall GPG signature of the RPM payload as a whole. While this extra capability is not yet fully developed in userspace, we do have one ready user (elfutils debuginfod [1])

Re: ☠ Buildbot (GNU Toolchain): elfutils-try-debian-armhf - failed compile (failure) (users/marxin/try-zstd-support-v2)

2022-12-21 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > [...] > Unfortunately buildbot itself doesn't show the config.log. > Trying to get that... Ah darn. It would have been saved in bunsen, but the buildbot configuration means that a make-stage failure means it won't even try. - FChE

Re: PATCH: Bug debuginfod/29472 followup

2022-11-10 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > Are you sure the interface is correct? Hard to be sure, so it's left generalized. The APIs would be unchanged if future search strategies are added (or subtracted); they'd affect the choice of acceptable KEY strings. We know we want glob patterns over executable file names. I've seen c

patch, debuginfod

2022-11-03 Thread Frank Ch. Eigler via Elfutils-devel
Hi - Showing diff -w to omit reindentation whitespace noise. Maybe worth backporting to 0.188 releases, could affect federation intermediate servers with burst workload. commit ec166cf3c8d825a2f02aca448a0823de12e78991 (HEAD -> master) Author: Frank Ch. Eigler Date: Thu Nov 3 10:07:31 2

  1   2   3   4   >