[Bug general/32598] New: Use --track-fds=yes when running tests under valgrind

2025-01-25 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=32598 Bug ID: 32598 Summary: Use --track-fds=yes when running tests under valgrind Product: elfutils Version: unspecified Status: NEW Severity: normal Priority: P2

Re: [PATCH] src/readelf.c: Close skel_fd

2025-01-25 Thread Mark Wielaard
Hi Aaron, On Fri, Jan 24, 2025 at 08:32:58PM -0500, Aaron Merey wrote: > skel_fd is passed to create_dwfl, which calls dup() on skel_fd. > create_dwfl handles closing the dup'ed fd but not the original. > > Ensure the original skel_fd is closed after it's passed to create_dwfl. Nice find. We sh

Re: [PATCH] debuginfod-client.c: Avoid freeing uninitialized value

2025-01-25 Thread Mark Wielaard
Hi Aaron, On Fri, Jan 24, 2025 at 08:32:48PM -0500, Aaron Merey wrote: > debuginfod_validate_imasig might call free on an uninitialized sig_buf > due to a goto that can occur before sig_buf is set to NULL. > > Fix this by setting sig_buf to NULL before the goto. The first thing after exit_valida