☠ Buildbot (Sourceware): elfutils - failed test (failure) (main)

2024-11-21 Thread builder
A new failure has been detected on builder elfutils-debian-amd64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#/builders/52/builds/427 Build state: failed test (failure) Revision: 5cc89c78499cd37465d7b0b3f35ef0e5d07a98cc Worker: bb1-2 Build

Re: [PATCH] Cleanup Makefile.am CLEANFILES definitions

2024-11-21 Thread Mark Wielaard
Hi Michael, On Tue, Nov 19, 2024 at 04:18:17AM +, Michael Pratt wrote: > > > This is because config/eu.am defines a default CLEANFILES. So those > > Makefile.am files should add to CLEANFILES with += instead of > > redefining CLEANFILES with =. > > May I suggest to instead simply use > "D

Re: [PATCH] libdw: Don't use ATOMIC_VAR_INIT

2024-11-21 Thread Mark Wielaard
Hi Aaron, On Mon, Nov 18, 2024 at 07:02:27PM -0500, Aaron Merey wrote: > LGTM. Aaron Ballman has noted [1] that no implementation of atomics or > embedded locks has depended on the use of this macro. Thanks, pushed. > [1] https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1138r0.pdf

Re: [PATCH] srcfiles.cxx: Prevent fd and entry leak

2024-11-21 Thread Mark Wielaard
Hi Aaron, On Mon, Nov 18, 2024 at 06:43:56PM -0500, Aaron Merey wrote: > Make sure to free fd and the archive entry if an error is encountered > while adding source files to the archive. Looks good to me. But one (paranoid?) nitpick below. > Signed-off-by: Aaron Merey > --- > src/srcfiles.cxx

[PATCH] Update minimum C compiler supported to C11 plus stdatomic.h

2024-11-21 Thread Mark Wielaard
We were using a somewhat odd mix of gnu99 with a fallback atomics.h so we could build with gcc 4.7. Lets requires a compiler that can do at least C11 and has a stdatomic.h. So we can build against any C standard >= C11 (including C17 and C23). That means GCC 4.9+. GCC 4.9 was released in 2014. The