[PATCH] Consolidate and add files to clean target variables

2024-10-22 Thread Michael Pratt
To increase the consistency of how automatic clean targets run, define the variables together without +=, default to MOSTLYCLEANFILES when there is no need for different levels or add more clean levels to match other subdirectories, add more files that are built, remove duplication, and cleanup. D

Re: [PATCH 6/6] Use file stream or format variants of stdio print functions

2024-10-22 Thread Michael Pratt
Hi Aaron, On 10/22/24 4:45 PM, Aaron Merey wrote: > Hi Michael, > > On Tue, Oct 15, 2024 at 11:10 AM Michael Pratt wrote: > > It would be nice to have patch 5 before release, > > for patch 6 doesn't matter if or when to me. > > > > Let me know if you want a v2 of either patch 5 or 6. >

Re: [PATCH 6/6] Use file stream or format variants of stdio print functions

2024-10-22 Thread Aaron Merey
Hi Michael, On Tue, Oct 15, 2024 at 11:10 AM Michael Pratt wrote: > On Monday, October 14th, 2024 at 17:30, Mark Wielaard wrote: > > > > If we are trying to be more consistent then I think I would prefer we > > use putchar, puts, and printf, instead of adding stdout to all these > > calls. > > I

[PATCH] configure: better error message for [lib]debuginfod missing dependencies

2024-10-22 Thread Mark Wielaard
When dependencies for libdebuginfod, debuginfod or ima verification are missing and these features are explicitly enabled the user might not immediately know which of the dependicies are missing. Move the checks around a little so checks for dependencies are done immediately before the enable error

Re: [PATCH] libelf: Add libeu objects to libelf.a static archive

2024-10-22 Thread Aaron Merey
On Tue, Oct 22, 2024 at 9:04 AM Mark Wielaard wrote: > > libelf might use some symbols from libeu.a, specifically the eu-search > wrappers. But we don't ship libeu.a separately. So include the libeu > objects in the libelf.a archive to facilitate static linking. > > * libelf/Makefile.am (l

Re: [PATCH] tests: run-debuginfod-seekable.sh depends on LZMA and DEBUGINFOD

2024-10-22 Thread Aaron Merey
On Tue, Oct 22, 2024 at 7:48 AM Mark Wielaard wrote: > > The run-debuginfod-seekable.sh test would run (and fail) if lzma > support was enabled, but debuginfod wasn't build. Only run it when > both are available. > > * tests/Makefile.am (TESTS): Add run-debuginfod-seekable.sh if > DEBUGI

[PATCH] libelf: Add libeu objects to libelf.a static archive

2024-10-22 Thread Mark Wielaard
libelf might use some symbols from libeu.a, specifically the eu-search wrappers. But we don't ship libeu.a separately. So include the libeu objects in the libelf.a archive to facilitate static linking. * libelf/Makefile.am (libeu_objects): New variable. (libelf_a_LIBADD): New, add

[PATCH] tests: run-debuginfod-seekable.sh depends on LZMA and DEBUGINFOD

2024-10-22 Thread Mark Wielaard
The run-debuginfod-seekable.sh test would run (and fail) if lzma support was enabled, but debuginfod wasn't build. Only run it when both are available. * tests/Makefile.am (TESTS): Add run-debuginfod-seekable.sh if DEBUGINFOD and LZMA. Signed-off-by: Mark Wielaard --- tests/Makefile.a

[Bug libelf/32293] Build of vl4-utils using elfutils-0.192 libelf (static) fails

2024-10-22 Thread rudi at heitbaum dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=32293 --- Comment #2 from rudi at heitbaum dot com --- (In reply to Mark Wielaard from comment #1) > Is there a reason vl4-utils cannot simply be linked shared to libelf? > In general we aren't really testing static linking. > Which indeed means it i