Re: [PATCH 6/6] Use file stream or format variants of stdio print functions

2024-10-14 Thread Mark Wielaard
Hi Michael, On Thu, Oct 10, 2024 at 10:27:31AM +, Michael Pratt wrote: > In many source files, putc() and fputc() and putchar() > are used interchangeably, and puts() and fputs() and printf() > are used interchangeably. > > Reducing the usage to 2 of the 3 both reduces binary size > of the fi

Re: [PATCH 5/6] Remove usage of "unlocked" variant of stdio print functions

2024-10-14 Thread Mark Wielaard
Hi Michael, On Thu, Oct 10, 2024 at 10:27:23AM +, Michael Pratt wrote: > These Linux Standard Base functions are not available > on all systems that are capable of building Linux and ELFs. > > The difference is negligible for simple printing to stdout. > > POSIX also states for the similar p

Re: [PATCH 3/6] libdw: Let clean targets be unconditional

2024-10-14 Thread Mark Wielaard
Hi Michael, On Thu, Oct 10, 2024 at 10:27:09AM +, Michael Pratt wrote: > The automake rule "maintainer-clean-generic" > is always available and never conditional, > so let the variable that uses it be define > non-conditionally. > > If one actually wants conditional cleaning > they should wri

Re: [PATCH 2/6] libcpu: Include config.h before standard headers in lexer source

2024-10-14 Thread Mark Wielaard
Hi Michael, On Thu, Oct 10, 2024 at 10:27:02AM +, Michael Pratt wrote: > As part of the processing of flex, definitions and headers > are added to output source before any literal text or generated code. > > This causes standard headers to come before config.h > unless config.h is included in

Re: [PATCH 1/6] lib: Add missing config.h include to next_prime.c

2024-10-14 Thread Mark Wielaard
Hi Michael, On Thu, Oct 10, 2024 at 10:26:54AM +, Michael Pratt wrote: > This is the last remaining C source file as of this commit > without the standard conditional inclusion of config.h > as the very first header. > > * lib/next_prime.c: add missing config.h header. Looks good and i

Re: [PATCH 0/6] Various portability fixes and organization

2024-10-14 Thread Michael Pratt
Hi Aaron, The first 3 patches of the series are pretty simple and helpful. I would like to see them in the next release, do they look ok? Without the first 2, we actually experience build errors due to config.h not being included or being included too late. The 3rd one prevents an error with our