☝ Buildbot (Sourceware): elfutils - worker not available (main)

2024-08-20 Thread builder
A retry build has been detected on builder elfutils-opensuseleap-x86_64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#/builders/90/builds/332 Build state: worker not available Revision: (unknown) Worker: bbo1-1 Build Reason: (unknown) Blamel

☝ Buildbot (Sourceware): elfutils - worker not available (main)

2024-08-20 Thread builder
A retry build has been detected on builder elfutils-opensuseleap-x86_64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#/builders/90/builds/334 Build state: worker not available Revision: (unknown) Worker: bb1-1 Build Reason: (unknown) Blameli

☝ Buildbot (Sourceware): elfutils - worker not available (main)

2024-08-20 Thread builder
A retry build has been detected on builder elfutils-opensuseleap-x86_64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#/builders/90/builds/333 Build state: worker not available Revision: (unknown) Worker: bbo1-2 Build Reason: (unknown) Blamel

☠ Buildbot (Sourceware): elfutils-snapshots-coverage - failed test (failure) (main)

2024-08-20 Thread builder
A new failure has been detected on builder elfutils-snapshots-coverage while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#/builders/250/builds/156 Build state: failed test (failure) Revision: a0a2996d15529673bf43269fe7fcafa2e4a0187b Worker: snaps

Re: [PATCH 08/10 v3] libdw: Make libdw_findcu thread-safe

2024-08-20 Thread Aaron Merey
Hi Mark, On Fri, Aug 16, 2024 at 5:38 PM Mark Wielaard wrote: > > Hi, > > On Fri, Aug 02, 2024 at 07:38:07PM -0400, Aaron Merey wrote: > > From: Heather McIntyre > > > > * libdw/libdw_findcu.c (__libdw_findcu): Add locking. > > > > Signed-off-by: Heather S. McIntyre > > Signed-off-by: Aar

Re: [PATCH 07/10 v3] libdw: Make libdw_find_split_unit thread-safe

2024-08-20 Thread Aaron Merey
Hi Mark, On Fri, Aug 16, 2024 at 5:14 PM Mark Wielaard wrote: > > On Fri, Aug 02, 2024 at 07:38:06PM -0400, Aaron Merey wrote: > > From: Heather McIntyre > > > > * libdw/libdwP.h (struct Dwarf_CU): Add split_lock. > > * libdw/libdw_find_split_unit.c (__libdw_find_split_unit): > >

Re: [PATCH 06/10 v3] libdwP.h: Add locking to dwarf_formref_die and __libdw_dieabbrev

2024-08-20 Thread Aaron Merey
Hi Mark, On Fri, Aug 16, 2024 at 5:51 PM Mark Wielaard wrote: > > On Fri, Aug 02, 2024 at 07:38:05PM -0400, Aaron Merey wrote: > > From: Heather McIntyre > > > > * libdw/dwarf_formref_die.c (dwarf_formref_die): Add locking > > around call to __libdw_intern_next_unit. > > *

Re: [PATCH 05/10 v3] libdw: make dwarf_getalt and dwarf_setalt thread-safe

2024-08-20 Thread Aaron Merey
Hi Mark, On Fri, Aug 16, 2024 at 9:45 AM Mark Wielaard wrote: > > On Fri, 2024-08-02 at 19:38 -0400, Aaron Merey wrote: > > From: Heather McIntyre > > > > * libdw/dwarf_getalt.c (dwarf_getalt): Add locking. > > * libdw/dwarf_setalt.c (dwarf_setalt): Ditto. > > > > Signed-off-by: Heat

Re: [PATCH 04/10 v3] libdw: Add rwlocks for Dwarf and Dwarf_CU

2024-08-20 Thread Aaron Merey
Hi Mark, On Fri, Aug 16, 2024 at 9:38 AM Mark Wielaard wrote: > > Hi Aaron, > > On Fri, 2024-08-02 at 19:38 -0400, Aaron Merey wrote: > > From: Heather McIntyre > > > > Add dwarf_lock for Dwarf as well as abbrev_lock for Dwarf_CU. > > > > * libdw/dwarf_begin_elf.c (dwarf_begin_elf): Init d

Re: [PATCH 03/10 v3] lib: Add eu_tsearch, eu_tfind, eu_tdelete and eu_tdestroy

2024-08-20 Thread Aaron Merey
Hi Mark, On Thu, Aug 15, 2024 at 6:13 PM Mark Wielaard wrote: > > On Fri, Aug 02, 2024 at 07:38:02PM -0400, Aaron Merey wrote: > > From: Heather McIntyre > > > > Add struct search_tree to hold tree root and lock. Add new eu_t* > > functions for ensuring synchronized tree access. > > > > Replace

Re: [PATCH 02/10 v3] libelf: Fix deadlock in elf_cntl

2024-08-20 Thread Aaron Merey
Hi Mark, On Thu, Aug 15, 2024 at 12:16 PM Mark Wielaard wrote: > > On Fri, 2024-08-02 at 19:38 -0400, Aaron Merey wrote: > > From: Heather McIntyre > > > > * libelf/elf_cntl.c (elf_cntl): Move rwlock_wrlock, rwlock_unlock, > > inside case switch statements. Remove unnecessary ea

Re: [PATCH 01/10 v3] libelf: Fix deadlock in __libelf_readall

2024-08-20 Thread Aaron Merey
Hi Mark, On Thu, Aug 15, 2024 at 12:13 PM Mark Wielaard wrote: > > On Fri, 2024-08-02 at 19:38 -0400, Aaron Merey wrote: > > From: Heather McIntyre > > > > Apply locking during __libelf_readall. > > > > Signed-off-by: Heather S. McIntyre > > Signed-off-by: Aaron Merey > > Signed-off-by: Mark W

Re: [PATCH 0/5] Enable PAC support in elfutils

2024-08-20 Thread Mark Wielaard
Hi Steve, On Fri, Jun 14, 2024 at 03:47:14PM +0100, Steve Capper wrote: > This series enables Pointer Authentication (PAC) support in elfutils. > > The first four patches were originally posted by German Gomez. I've > rebased to the latest elfutils and added an extra patch that was > required to

Re: [PATCH 1/5] aarch64: Create definitions for AARCH64_RA_SIGN_STATE register

2024-08-20 Thread Mark Wielaard
Hi, Sorry, one more thing. On Fri, Jun 14, 2024 at 03:47:15PM +0100, Steve Capper wrote: > index 4be32de5..f6d26044 100644 > --- a/libdw/dwarf.h > +++ b/libdw/dwarf.h > @@ -1028,6 +1028,11 @@ enum > DW_EH_PE_indirect = 0x80 >}; > > +/* AARCH64 DWARF registers. */ > +enum > + { > +

Re: [PATCH 2/5] libdw, aarch64: Implement DW_CFA_AARCH64_negate_ra_state CFI instruction

2024-08-20 Thread Mark Wielaard
Hi, On Fri, Jun 14, 2024 at 03:47:16PM +0100, Steve Capper wrote: > From: German Gomez > > Implement DW_CFA_AARCH64_negate_ra_state in accordance with the DWARF > AARCH64 ABI [1]. > > Followup commits will use the value of this register to remove the PAC > from return addresses. Looks correct.

Re: [PATCH 1/5] aarch64: Create definitions for AARCH64_RA_SIGN_STATE register

2024-08-20 Thread Mark Wielaard
On Fri, Jun 14, 2024 at 03:47:15PM +0100, Steve Capper wrote: > From: German Gomez > > This register will be used to indicate whether a return address is > mangled with a PAC or not, in accordance with the DWARF AARCH64 ABI [1]. > > [1] > https://github.com/ARM-software/abi-aa/blob/main/aadwarf

[PATCH] Fix some potential deref-of-null error

2024-08-20 Thread Maks Mishin
strip.c: Pointer `arhdr` created at strip.c:2741 and then dereferenced without NULL-check. The same situation for the `arhdr` pointer at the objdump.c:313 and the `h` pointer at the readelf.c:13545. Triggers found by static analyzer Svace. Signed-off-by: Maks Mishin --- src/objdump.c | 5 +