Re: [PATCH] Add helper function for basename

2023-12-14 Thread Khem Raj
On Thu, Dec 14, 2023 at 11:22 AM Mark Wielaard wrote: > > Hi Khem, > > On Thu, Dec 14, 2023 at 10:15:00AM -0800, Khem Raj wrote: > > Overall, this looks a good improvement on top of my patch so good to go. > > I will also try it in my local distro builds and see how it goes. > > Thanks. I didn't a

Re: [PATCH] Add helper function for basename

2023-12-14 Thread Mark Wielaard
Hi Khem, On Thu, Dec 14, 2023 at 10:15:00AM -0800, Khem Raj wrote: > Overall, this looks a good improvement on top of my patch so good to go. > I will also try it in my local distro builds and see how it goes. Thanks. I didn't actually test it against musl. So if you could and report whether or n

Re: [PATCH] Add helper function for basename

2023-12-14 Thread Khem Raj
On Thu, Dec 14, 2023 at 10:07 AM Mark Wielaard wrote: > > Hi Khem, > > On Sun, 2023-12-10 at 12:20 -0800, Khem Raj wrote: > > musl does not provide GNU version of basename and lately have removed > > the definiton from string.h [1] which exposes this problem. It can be > > made to work by providin

Re: [PATCH] Add helper function for basename

2023-12-14 Thread Mark Wielaard
Hi Khem, On Sun, 2023-12-10 at 12:20 -0800, Khem Raj wrote: > musl does not provide GNU version of basename and lately have removed > the definiton from string.h [1] which exposes this problem. It can be > made to work by providing a local implementation of basename which > implements the GNU base