[COMMITTED] debuginfod: Fix formatting in debuginfod_config_cache

2023-06-22 Thread Mark Wielaard
The formatting of debuginfod_config_cache in debuginfod-client.c was slightly off making it hard to see the program logic. Make sure lines are < 76 chars, and if { } else { } indentation follows GNU style. Signed-off-by: Mark Wielaard --- debuginfod/debuginfod-client.c | 32 ++---

Re: Performance issue with systemd-coredump and container process linking 2000 shared libraries.

2023-06-22 Thread Mark Wielaard
Hi Romain, On Thu, 2023-06-22 at 08:10 +, Romain GEISSLER via Elfutils-devel wrote: > > Overall we can see that both fix independently fix the performance issue (yet > the systemd patch seems a bit more effective), so I guess both fixes are > welcome. Yes, thanks so much for the testing o

Re: Performance issue with systemd-coredump and container process linking 2000 shared libraries.

2023-06-22 Thread Mark Wielaard
Hi Frank, On Wed, 2023-06-21 at 22:40 -0400, Frank Ch. Eigler wrote: > For an application that processes these elf/dwarf files sequentially, > queries for each synthetic solib are going to result in 2000 https-404 > transactions, sans debuginfod caching.  If you're lucky (reusing a > dwfl object),

Re: Performance issue with systemd-coredump and container process linking 2000 shared libraries.

2023-06-22 Thread Romain GEISSLER via Elfutils-devel
> Le 21 juin 2023 à 21:39, Mark Wielaard a écrit : > > > Hi Romain, > > That patch looks good. It should reduce the number of calls to > elf_getdata_rawchunk a lot. Making it less urgent that function is > fast. But if you could test it that would be appreciated. I'll also > test it a bit more