Re: [PATCH v2 2/2] debuginfod-client.c: Fix x-debuginfod-size counts differently than CURLINFO_SIZE_DOWNLOAD_T

2023-03-29 Thread lilydjwg via Elfutils-devel
On Wed, Mar 29, 2023 at 03:14:43PM -0400, Frank Ch. Eigler wrote: > Hi - > > > x-debuginfod-size is the actual file size, but CURLINFO_SIZE_DOWNLOAD_T > > is transferred size, i.e. the gzipped one if gzip is on. > > Let's count written data and use that if and only if x-debuginfod-size > > is used

☺ Buildbot (Sourceware): elfutils - build successful (master)

2023-03-29 Thread builder--- via Elfutils-devel
A restored build has been detected on builder elfutils-debian-arm64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/5/builds/168 Build state: build successful Revision: 7b97c73bbd30ba9b51fb48e4e9b93ab064c9a7dd Worker: debian-arm64 Bui

☠ Buildbot (Sourceware): elfutils - failed test (failure) (master)

2023-03-29 Thread builder--- via Elfutils-devel
A new failure has been detected on builder elfutils-debian-arm64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/5/builds/167 Build state: failed test (failure) Revision: adcc81a03f286404b4e661759e1eb1dd10baf774 Worker: debian-arm64 B

☠ Buildbot (Sourceware): elfutils - failed test (failure) (master)

2023-03-29 Thread builder--- via Elfutils-devel
A new failure has been detected on builder elfutils-opensusetw-x86_64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/88/builds/141 Build state: failed test (failure) Revision: a9bf65487df83c7b4ebbab4ff77b57e0c17f7c33 Worker: bb1-2 Bu

Re: [PATCH 3/3] debuginfod: When retrieving files from cache, update atime manually

2023-03-29 Thread Jan Alexander Steffens (heftig) via Elfutils-devel
On Wed, Mar 29, 2023 at 10:54 PM Frank Ch. Eigler wrote: > Hi - > > > The cache cleaning logic requires atime to be correct (strictatime) but > > most users on Linux only have relatime or even noatime. > > This is not really correct: relatime is the kernel default and works > fine with the cache.

Re: [PATCH 3/3] debuginfod: When retrieving files from cache, update atime manually

2023-03-29 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > The cache cleaning logic requires atime to be correct (strictatime) but > most users on Linux only have relatime or even noatime. This is not really correct: relatime is the kernel default and works fine with the cache. atime values updated once a day are still plenty for caches with a mu

Re: [PATCH v2 1/2] debuginfod-client.c: Fix download size not correctly fallbacks to x-debuginfod-size header

2023-03-29 Thread Frank Ch. Eigler via Elfutils-devel
> +2023-03-29 lilydjwg > + > + * debuginfod/debuginfod-client.c: Fix download size not correctly > + fallbacks to x-debuginfod-size header Thanks, merged. - FChE

Re: [PATCH 1/3] debuginfod: Replace futimes with futimens

2023-03-29 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > Similar to what 8c4aa0ef998191ed828a37190dc179b91649938a did for ar and > strip, replace the non-standard futimes with the POSIX futimens. Thanks, merged (with a little ChangeLog thing added ... please free us, mjw!). - FChE

Re: [PATCH v2 2/2] debuginfod-client.c: Fix x-debuginfod-size counts differently than CURLINFO_SIZE_DOWNLOAD_T

2023-03-29 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > x-debuginfod-size is the actual file size, but CURLINFO_SIZE_DOWNLOAD_T > is transferred size, i.e. the gzipped one if gzip is on. > Let's count written data and use that if and only if x-debuginfod-size > is used. Hey, great idea actually tallying up writes in the callback function. (We n

Re: [PATCH] debuginfod-client.c: Fix download size not correctly fallbacks to x-debuginfod-size header

2023-03-29 Thread lilydjwg via Elfutils-devel
On Wed, Mar 29, 2023 at 10:57:47PM +0800, lilydjwg wrote: > On Wed, Mar 29, 2023 at 08:28:35AM -0400, Frank Ch. Eigler wrote: > > Hi - > > > > > [...] > > > The reason is that when Content-Length is unavailable, cl is set to -1 > > > by curl > > > > Is that behaviour from new versions of curl? >

[PATCH v2 2/2] debuginfod-client.c: Fix x-debuginfod-size counts differently than CURLINFO_SIZE_DOWNLOAD_T

2023-03-29 Thread lilydjwg via Elfutils-devel
x-debuginfod-size is the actual file size, but CURLINFO_SIZE_DOWNLOAD_T is transferred size, i.e. the gzipped one if gzip is on. Let's count written data and use that if and only if x-debuginfod-size is used. Signed-off-by: lilydjwg --- ChangeLog | 2 ++ debuginfod/debugin

[PATCH v2 1/2] debuginfod-client.c: Fix download size not correctly fallbacks to x-debuginfod-size header

2023-03-29 Thread lilydjwg via Elfutils-devel
Signed-off-by: lilydjwg --- ChangeLog | 5 + debuginfod/debuginfod-client.c | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 10c23002..05697a02 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2023-03-29 lilydj

Re: [PATCH] debuginfod-client.c: Fix download size not correctly fallbacks to x-debuginfod-size header

2023-03-29 Thread lilydjwg via Elfutils-devel
On Wed, Mar 29, 2023 at 08:28:35AM -0400, Frank Ch. Eigler wrote: > Hi - > > > [...] > > The reason is that when Content-Length is unavailable, cl is set to -1 > > by curl > > Is that behaviour from new versions of curl? Yes. curl 8.0.1 to be exact. > > but dl_size remains as 0, but later dl_s

Re: [PATCH] debuginfod-client.c: Fix download size not correctly fallbacks to x-debuginfod-size header

2023-03-29 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > [...] > The reason is that when Content-Length is unavailable, cl is set to -1 > by curl Is that behaviour from new versions of curl? > but dl_size remains as 0, but later dl_size == -1 is checked. Or perhaps dl_size needs to be initialized to -1 ("unknown") vs 0 ("known to be zero"), a