Re: [PATCH] libdwfl: Read no more than required to parse dynamic sections

2022-11-29 Thread Gavin Li
Hi Mark, Thanks for looking over this patch. Responses are inline. > The code as written doesn't seem to guarantee that > dwfl_segment_report_module will always be called with > dwfl_elf_phdr_memory_callback as memory_callback. Although it probably > will be in practice. All file/line references

Re: [PATCH] libdwfl: Read no more than required to parse dynamic sections

2022-11-29 Thread Mark Wielaard
Hi Gavin, On Mon, 2022-11-28 at 22:26 -0800, ga...@matician.com wrote: > Since size checking has been moved to > dwfl_elf_phdr_memory_callback(), > there is no longer a need for dwfl_segment_report_module() to enforce > the same. Reading beyond the end of the dynamic section actually causes > issu

[PATCHv2] support ZSTD compression algorithm

2022-11-29 Thread Martin Liška
Hi. There's second version of the patch that fully support both compression and decompression. Changes from the v1: - compression support added - zstd detection is fixed - new tests are added - builds fine w/ and w/o the ZSTD library What's currently missing and where I need a help: 1) When I

☺ Buildbot (GNU Toolchain): elfutils - build successful (master)

2022-11-29 Thread builder--- via Elfutils-devel
A restored build has been detected on builder elfutils-debian-armhf while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/6/builds/106 Build state: build successful Revision: 6bb3e0b5c2124d51c604ec0cf145419c6856f5c0 Worker: debian-armhf Bui

Re: [PATCH][RFC] readelf: partial support of ZSTD compression

2022-11-29 Thread Martin Liška
On 11/28/22 23:29, Mark Wielaard wrote: Hi Martin, On Mon, Nov 28, 2022 at 02:16:35PM +0100, Martin Liška wrote: On 10/29/22 00:21, Mark Wielaard wrote: Although I like to also have compression working. Then we can also add support to src/elfcompress, which makes for a good testcase. See test