Hi -
Generally looks fine, thanks a lot.
A few nits:
- use of write(2) to put files onto disk is not quite right; write(2) can
be partial, so you need a loop (or a macro wrapping a loop)
- not sure I understand why the code worries about dots in or not in
section names. Why not just pass th
On 10/24/22 18:48, Dmitry V. Levin wrote:
> On Mon, Oct 24, 2022 at 02:17:17PM +0200, Martin Liška wrote:
>> On 10/24/22 13:41, Dmitry V. Levin wrote:
>>> On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote:
>>> [...]
One TODO I see is that:
+libelf_so_LDLIBS = $(libelf_so_DEPS)
On Mon, Oct 24, 2022 at 02:17:17PM +0200, Martin Liška wrote:
> On 10/24/22 13:41, Dmitry V. Levin wrote:
> > On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote:
> > [...]
> >> One TODO I see is that:
> >> +libelf_so_LDLIBS = $(libelf_so_DEPS) -lz -lzstd
> >>
> >> should be conditional ba
https://sourceware.org/bugzilla/show_bug.cgi?id=29719
--- Comment #1 from Martin Liska ---
3) we may want to implement the semantic: dump all symbols that live in a given
section "foo". Can be handy for sections like .hot.text and so on.
--
You are receiving this mail because:
You are on the CC
On 10/24/22 13:41, Dmitry V. Levin wrote:
> On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote:
> [...]
>> One TODO I see is that:
>> +libelf_so_LDLIBS = $(libelf_so_DEPS) -lz -lzstd
>>
>> should be conditional based on HAVE_ZSTD. But I don't know how to do that?
>
> I suppose you're tal
https://sourceware.org/bugzilla/show_bug.cgi?id=29719
Bug ID: 29719
Summary: eu-readelf -s=section is confusing
Product: elfutils
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: tools
On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote:
[...]
> One TODO I see is that:
> +libelf_so_LDLIBS = $(libelf_so_DEPS) -lz -lzstd
>
> should be conditional based on HAVE_ZSTD. But I don't know how to do that?
I suppose you're talking about libzstd_LIBS.
[...]
> diff --git a/m4/zst
https://sourceware.org/bugzilla/show_bug.cgi?id=29565
--- Comment #1 from Martin Liska ---
First part patch:
https://sourceware.org/pipermail/elfutils-devel/2022q4/005491.html
--
You are receiving this mail because:
You are on the CC list for the bug.
Support decompression of ZSTD sections and add support
for it when -SWz is used:
...
[30] .debug_abbrevPROGBITS 1f9d 0168 0 C
0 0 1
[ELF ZSTD (2) 02fc 1]
...
One TODO I see is that:
+libelf_so_LDLIBS = $(libelf_so_DEPS) -lz -lzstd
should b
