Re: [PATCH 5/7] Strip __ prefix from __BYTE_ORDER __LITTLE_ENDIAN and __BIG_ENDIAN

On Mon, Oct 17, 2022 at 5:11 AM Mark Wielaard wrote: > > Hi, > > This seems to work and is probably OK. But do you know when/what the > __ prefix versions are defined and when/what defines the non-prefixed > versions? > __BYTE_ORDER__ is a predefined macro by gcc/clang, BYTE_ORDER is defined in

Re: [PATCH 7/7] Add CMake build files

Hi, I rather not have multiple build systems in the tree. Are the autotools not available on your system? Cheers, Mark

Re: [PATCH 6/7] Fixes building with msvc/clang mingw/gcc

Hi, I find this hard to review. I have no experienc with msvc and don't know when/what _MSC_VER implies or how to verify system_win32.c. I am also a bit worried that the various ifdefs will be hard to keep correct. If we don't have HAVE_DECL_MMAP does the testsuite still work? Maybe this patch c

☺ Buildbot (GNU Toolchain): elfutils - build successful (master)

A restored build has been detected on builder elfutils-fedora-s390x while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/43/builds/79 Build state: build successful Revision: 96263dfee3591a9c732b00a33a4a221b8f01bf46 Worker: fedora-s390x Bui

Re: [PATCH 5/7] Strip __ prefix from __BYTE_ORDER __LITTLE_ENDIAN and __BIG_ENDIAN

Hi, This seems to work and is probably OK. But do you know when/what the __ prefix versions are defined and when/what defines the non-prefixed versions? Thanks, Mark On Tue, Sep 20, 2022 at 04:43:05PM +0800, Yonggang Luo via Elfutils-devel wrote: > Signed-off-by: Yonggang Luo > --- > lib/sys

☠ Buildbot (GNU Toolchain): elfutils - failed test (failure) (master)

A new failure has been detected on builder elfutils-fedora-s390x while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/43/builds/78 Build state: failed test (failure) Revision: a6b2ec76d51386dd06ab86d46eabbcf5140fe80d Worker: fedora-s390x B

Re: [PATCH v2 4/7] lib: Use NOT_HAVE_LIBINTL to guard #include

Hi, On Sun, Oct 16, 2022 at 12:36:22AM +0800, Yonggang Luo via Elfutils-devel wrote: > Add NOT_HAVE_LIBINTL macro to disable internationalization, > sometimes we have don't want access internationalization such as MSVC, > so the macro NOT_HAVE_LIBINTL can help that. This needs a configure check.

Re: [PATCH v2 3/7] Move the #include into eu-config.h

On Sun, Oct 16, 2022 at 12:36:21AM +0800, Yonggang Luo via Elfutils-devel wrote: > So we do not need include in each file. > And indeed the macro > #define _(Str) dgettext ("elfutils", Str) > access libintl function dgettext, so it's make more sense > #include in file eu-config.h And this works b

Re: [PATCH v2 2/7] move platform depended include into system.h of libelf

On Sun, Oct 16, 2022 at 12:36:20AM +0800, Yonggang Luo via Elfutils-devel wrote: > All of these files either #include directly or #include "libelfP.h" > And now "libelfP.h also #include , so the platform depended include > can be moved to system.h safely Thanks. While reviewing wrote ChangeLog en

☺ Buildbot (GNU Toolchain): elfutils - build successful (master)

A restored build has been detected on builder elfutils-debian-armhf while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/6/builds/77 Build state: build successful Revision: 2a4ce08fafcf76d866ae5f6b394389d8d93aa0cb Worker: debian-armhf Buil

Re: ☠ Buildbot (GNU Toolchain): elfutils - failed test (failure) (master)

There is a run-debuginfod-federation-metrics.sh failure that must be unrelated. It is an odd crash in the shell script wait statement? But there are also a few failures compiling the new testcase: In file included from /usr/include/features.h:490, from /usr/include/assert.h:35,

☠ Buildbot (GNU Toolchain): elfutils - failed test (failure) (master)

A new failure has been detected on builder elfutils-debian-arm64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/5/builds/74 Build state: failed test (failure) Revision: 64ee2cb792e7b6ba6ad2a5759bff7ce8714e4668 Worker: debian-arm64 Bu

Re: [PATCH] libdwfl: add dwfl_report_offline_memory

Hi Aleksei, On Tue, Sep 20, 2022 at 01:36:37PM +, Aleksei Vetrov via Elfutils-devel wrote: > This method allows to read and report ELF from memory instead of opening > a file. That way arbitrary memory can be worked with, e.g. when coming > from a stream without the need to persist. > > Anot

[Bug libelf/29695] In libelf.h struct Elf, struct Elf_Scn is defined using typedef and not using #include is not the way to comply with the specification?

https://sourceware.org/bugzilla/show_bug.cgi?id=29695 lin zhuorong changed: What|Removed |Added Component|libdw |libelf CC|

[Bug libdw/29695] New: In libelf.h struct Elf, struct Elf_Scn is defined using typedef and not using #include is not the way to comply with the specification?

https://sourceware.org/bugzilla/show_bug.cgi?id=29695 Bug ID: 29695 Summary: In libelf.h struct Elf, struct Elf_Scn is defined using typedef and not using #include is not the way to comply with the specification? Product: e