Re: [PATCH 2/7] move platform depended include into system.h

OK, updated in v2 On Sat, Oct 15, 2022 at 5:16 AM Mark Wielaard wrote: > > On Tue, Sep 20, 2022 at 04:43:02PM +0800, Yonggang Luo via Elfutils-devel wrote: > > All of these files either #include directly or #include "libelfP.h" > > And now "libelfP.h also #include , so the platform depended incl

[PATCH v2 4/7] lib: Use NOT_HAVE_LIBINTL to guard #include

Add NOT_HAVE_LIBINTL macro to disable internationalization, sometimes we have don't want access internationalization such as MSVC, so the macro NOT_HAVE_LIBINTL can help that. Signed-off-by: Yonggang Luo --- lib/eu-config.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/eu-config

[PATCH v2 3/7] Move the #include into eu-config.h

So we do not need include in each file. And indeed the macro #define _(Str) dgettext ("elfutils", Str) access libintl function dgettext, so it's make more sense #include in file eu-config.h Signed-off-by: Yonggang Luo --- debuginfod/debuginfod.cxx | 1 - lib/color.c | 1 - lib/eu-

[PATCH v2 2/7] move platform depended include into system.h of libelf

All of these files either #include directly or #include "libelfP.h" And now "libelfP.h also #include , so the platform depended include can be moved to system.h safely Signed-off-by: Yonggang Luo --- lib/system.h | 11 +++ libelf/common.h | 3 --- libelf/

[PATCH v2 0/7] Enable building libelf of elfutils on win32

After these changes, now libelf can be build with mingw/gcc and msvc/clang v1 -> v2 Do no modify libebl in commit move platform depended include into system.h of libelf Add commit Move the #include into eu-config.h to Yonggang Luo (7): Rename 'hello2.spec.' -> 'hello2.spec' 'hello3.spec.' ->