Re: [PATCH] debuginfod: Fix some memory leaks on debuginfod-client error paths.

On Wed, Dec 01, 2021 at 01:27:23PM +0100, Mark Wielaard wrote: > In a couple of places we might leak some memory when we encounter > an error. tmp_url might leak if realloc failed. escaped_string might > leak when setting up the data handle fails and we don't use it. > And one of the goto out1 shou

Re: [PATCH] debuginfod/debuginfod-client.c: correct string format on 32bit arches with 64bit time_t

I'm not sure; the point of this patch is simply to ensure debuginfod builds everywhere without errors. Making the types consistent is perhaps better done as a followup? Alex On Sun, 5 Dec 2021 at 21:31, Mark Wielaard wrote: > Hi, > > On Sun, Nov 21, 2021 at 11:14:11PM +0100, Alexander Kanavin v

Re: [PATCH] debuginfod/debuginfod-client.c: correct string format on 32bit arches with 64bit time_t

Hi, On Sun, Nov 21, 2021 at 11:14:11PM +0100, Alexander Kanavin via Elfutils-devel wrote: > From: Alexander Kanavin > > Use intmax_t to print time_t > > time_t is platform dependent and some of architectures e.g. > x32, riscv32, arc use 64bit time_t even while they are 32bit > architectures, t

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

Hi Luca, On Tue, Nov 30, 2021 at 12:25:41PM +0100, Mark Wielaard wrote: > On Thu, 2021-11-25 at 17:02 +, Luca Boccassi via Elfutils-devel > wrote: > > +/* Packaging metadata as defined on > > > https://systemd.io/COREDUMP_PACKAGE_METADATA/ */ > > > +#define FDO_PACKAGING_METADATA 0xcafe1a7e >

Re: PATCH: testsuite debuginfod

Hi Frank, On Tue, Oct 05, 2021 at 06:55:34PM +0200, Mark Wielaard wrote: > On Thu, 2021-09-30 at 10:50 -0400, Frank Ch. Eigler via Elfutils-devel > wrote: > > commit 85602ff68179053f19a2005df4fc653a69757584 (HEAD -> master) > > Author: Frank Ch. Eigler > > Date: Thu Sep 30 10:48:00 2021 -0400 >

Re: [PATCH] debuginfod: sqlite3_sharedprefix_fn should not compare past end of string

On Sat, Dec 04, 2021 at 05:54:07PM -0500, Frank Ch. Eigler wrote: > > gcc address sanitizer detected a read after the end of string in > > sqlite3_sharedprefix_fn. Make sure to stop comparing the strings when > > seeing the zero terminator. > > Yup, OK. Thanks, pushed. Mark

Re: [PATCH v3] build: allow turning off --no-undefined and -z,defs

Hi Mark, > But it would help if you replied to the original > reviews and/or mentioned how the different versions of your patch have > changed since the last time. I did but it looks like those emails didn't pass the spam filter. I'll try to figure out what happened there. Sorry about that! >

Re: [PATCH v3] build: allow turning off --no-undefined and -z,defs

Hi Evgeny, I really appreciate you helping us using more analyzers and fuzzers to improve the code base. I think the address sanitizer already helped improve the code. But it would help if you replied to the original reviews and/or mentioned how the different versions of your patch have changed si