Re: [PATCH] debuginfod/debuginfod-client.c: correct string format on 32bit arches with 64bit time_t

2021-11-25 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > According to 'man 3 printf' %j appeared in glibc 2.1 and seems to be C99 > feature. That's decidedly ancient. OK. > And may I be allowed to suggest, unless elfutils is tested in upstream CI > with decade-old toolchains, you should not be considering its compatibility > with them. Deploy

Re: [PATCH] debuginfod/debuginfod-client.c: correct string format on 32bit arches with 64bit time_t

2021-11-25 Thread Alexander Kanavin via Elfutils-devel
According to 'man 3 printf' %j appeared in glibc 2.1 and seems to be C99 feature. That's decidedly ancient. And may I be allowed to suggest, unless elfutils is tested in upstream CI with decade-old toolchains, you should not be considering its compatibility with them. Alex On Thu, 25 Nov 2021 at

Re: [PATCH] debuginfod/debuginfod-client.c: correct string format on 32bit arches with 64bit time_t

2021-11-25 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > Use intmax_t to print time_t > [...] > - if (dprintf(fd, "%ld", cache_config_default_s) < 0) > + if (dprintf(fd, "%jd", (intmax_t)cache_config_default_s) < 0) > [...] I'm not a compatibility specialist, but note that elfutils is sometimes built on decade-old toolchains, where use

Re: [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note

2021-11-25 Thread Luca Boccassi via Elfutils-devel
On Sun, 2021-11-21 at 19:43 +, luca.bocca...@gmail.com wrote: > From: Luca Boccassi > > As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/ > this note will be used starting from Fedora 36. Allow > readelf --notes to pretty print it: > > Note section [ 3] '.note.package' of 76 bytes

Re: [PATCH] tests: Add -ldl to dwfl_proc_attach_LDFLAGS

2021-11-25 Thread Dmitry V. Levin
On Sat, Nov 20, 2021 at 03:18:27PM +0100, Mark Wielaard wrote: > Hi, > > On Sat, Nov 20, 2021 at 01:12:17AM +0300, Dmitry V. Levin wrote: > > On Fri, Nov 19, 2021 at 05:58:19PM +0100, Florian Weimer wrote: > > > It may have to do with --as-needed that some builds use. If there are > > > no pendin

Re: [PATCH] tests: Add -ldl to dwfl_proc_attach_LDFLAGS

2021-11-25 Thread Mark Wielaard
Hi, On Sat, 2021-11-20 at 15:18 +0100, Mark Wielaard wrote: > On Sat, Nov 20, 2021 at 01:12:17AM +0300, Dmitry V. Levin wrote: > > On Fri, Nov 19, 2021 at 05:58:19PM +0100, Florian Weimer wrote: > > > It may have to do with --as-needed that some builds use. If there are > > > no pending undefined