Hello,
> Why have MAXTIME default to LONG_MAX? Which is long, but different on
> different arches 32/64bit. If MAXSIZE == 0 means infinite, why not make
> MAXTIME=0 the same for consistency?
Fixed.
> The bug suggests to also check the Content-Length header on reciept (in
> case the server didn'
Hi -
> Is debuginfod-client-config.7 intended to be installed? If so it should
> be added to notrans_dist_man7_MANS in doc/Makefile.am, [...]
Yeah.
> If it isn't intended to be installed, maybe give it a different suffix
> so it isn't confused to be a standalone man page?
>
> > +.so ./debuginfo
Hi Alice,
On Wed, 2021-07-28 at 15:42 -0400, Alice Zhang via Elfutils-devel wrote:
> Create a new file, debuginfod-client-config.7, that holds all environment
> variables and cache control files related info. Get rid of repetitive
> definitions in three other files, instead, those files will inclu
Hi -
> [...] An alternative of passing around the X-DEBUGINFOD-MAXSIZE
> header is doing it all at the client side if we supported HEAD. See
> PR27277. Did you consider that route? [...]
That would require -two- http round-trips (one HEAD, one actual GET).
This way, the requested limit goes out
Hi Noah,
On Mon, 2021-07-26 at 14:56 -0400, Noah Sanci via Elfutils-devel wrote:
> Please find the attached patch for pr 27982. DEBUGINFOD_MAXSIZE and
> MAXTIME were added in this patch to allow users to use more
> constraints when downloading debuginfo.
This looks good. Some high level comments
https://sourceware.org/bugzilla/show_bug.cgi?id=28136
Mark Wielaard changed:
What|Removed |Added
Resolution|--- |FIXED
CC|
Hi Noah,
On Wed, 2021-07-28 at 12:23 -0400, Noah Sanci via Elfutils-devel wrote:
> This patch fixes a memory leak and slightly alters the PR27983 test,
> isolating where its DEBUGINFO_URLS's duplicates are accessible, which
> fixes a case of test failure on some systems.
Great. I pushed my patch
