Re: [PATCH] libdwfl: fix crash when reading link map

2021-06-09 Thread Omar Sandoval
On Wed, Jun 09, 2021 at 09:59:06PM -0300, Érico Nogueira wrote: > Hope you don't mind my nit, then :) Thanks, that's what I get for sending patches out right before dinner... > On Wed Jun 9, 2021 at 9:51 PM -03, Omar Sandoval wrote: > > On Wed, Jun 09, 2021 at 05:45:57PM -0700, Omar Sandoval wrot

Re: [PATCH] libdwfl: fix crash when reading link map

2021-06-09 Thread Érico Nogueira via Elfutils-devel
Hope you don't mind my nit, then :) On Wed Jun 9, 2021 at 9:51 PM -03, Omar Sandoval wrote: > On Wed, Jun 09, 2021 at 05:45:57PM -0700, Omar Sandoval wrote: > > From: Omar Sandoval > > > > When read_addrs() was converted was converted from a nested function to

Re: [PATCH] libdwfl: fix crash when reading link map

2021-06-09 Thread Omar Sandoval
On Wed, Jun 09, 2021 at 05:45:57PM -0700, Omar Sandoval wrote: > From: Omar Sandoval > > When read_addrs() was converted was converted from a nested function to > a normal function, there was a mistake in converting "buffer" from a > closure variable to a parameter: we are checking whether the po

[PATCH] libdwfl: fix crash when reading link map

2021-06-09 Thread Omar Sandoval
From: Omar Sandoval When read_addrs() was converted was converted from a nested function to a normal function, there was a mistake in converting "buffer" from a closure variable to a parameter: we are checking whether the pointer argument is NULL, not whether the buffer itself is NULL. This cause

[Bug debuginfod/27863] server optimization for identical concurrent requests

2021-06-09 Thread fche at redhat dot com via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27863 Frank Ch. Eigler changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: PR27863 [PATCH] - debuginfod serialization for concurrent identical requests

2021-06-09 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > After a little DoS on one of the public servers yesterday, I'm > thinking this should help. Working well on the public servers, pushing. - FChE