Re: [PATCH 4/4] arlib-argp: Pull text_for_default() into file scope

2021-01-29 Thread Mark Wielaard
Hi Timm, On Fri, 2021-01-08 at 09:13 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. Right, the only context captured is the text string pointer which is now passed as argument. Added a Changelog entry and pushed. Thanks, Mark

Re: [PATCH 3/4] ar: Pull should_truncate_fname() into file scope

2021-01-29 Thread Mark Wielaard
Hi Timm, On Fri, 2021-01-08 at 09:13 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. Skipping this one for now since I don't believe I understand this code. Could you explain what the code does what it does and why it works fine when moved this way? Thanks,

Re: [PATCH 2/4] zstrptr: Pull print_string() into file scope

2021-01-29 Thread Mark Wielaard
Hi Timm, On Fri, 2021-01-08 at 09:13 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. OK. This doesn't immediately make clear that the given scn and ndx refer to the same section. But it does test the same thing (that given section strings can be accessed throu

Re: [PATCH 1/4] addr2line: Pull show_note() and show_int() in file scope

2021-01-29 Thread Mark Wielaard
Hi Timm, On Fri, 2021-01-08 at 09:13 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of the nested functions OK. These nested functions don't actually capture anything from their outerscope. So they can be moved to file scope without requiring any extra arguments. Added a ChangeLog entry an

[Bug debuginfod/27277] New: support HEAD query for debuginfod content probe requests

2021-01-29 Thread fche at redhat dot com via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=27277 Bug ID: 27277 Summary: support HEAD query for debuginfod content probe requests Product: elfutils Version: unspecified Status: NEW Severity: normal