Re: [PATCH 02/14] segment_report_module: Pull segment_read into file scope

2020-11-18 Thread Mark Wielaard
Hi Timm, On Thu, Nov 12, 2020 at 04:04:00PM +0100, Timm Bäder via Elfutils-devel wrote: > In preparation of getting rid of nested functions I actually like the nested functions in this case, they simply act as lambdas. But if you want to get rid of this one then can we inline the (*memory_callbac

Re: [PATCH 01/14] segment_report_module: Get rid of variable-length arrays

2020-11-18 Thread Mark Wielaard
Hi Tim, On Thu, Nov 12, 2020 at 04:03:59PM +0100, Timm Bäder via Elfutils-devel wrote: > This prevents a jump which is needed in a later patch. I liked them better when they defined the array size, since it shows the array size equals the for loop bounds. But the usage does look nicer now. I adde

[Bug libelf/26878] elflint reports error on SHT_X86_64_UNWIND .eh_frame section

2020-11-18 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=26878 Mark Wielaard changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

Re: Subject: [PATCH] Make elflint and libebl understand .rela.eh_frame like other section type

2020-11-18 Thread Mark Wielaard
Hi Navin, On Wed, 2020-11-18 at 10:08 +0530, Navin P via Elfutils-devel wrote: > with clang compiler build, before applying this patch 3 tests were > failing and after > applying the patch all tests pass. > your patch is much better as it fixes the backend. Great, thanks for testing. I pushed it