On Sun, 2020-11-01 at 19:46 +0100, Mark Wielaard wrote:
> We already checked the header actually existed for ELFCLASS64 but not
> for the ELFCLASS32 case. It is very unlikely it is at this point in the
> code, but theoretically it could happen.
Pushed.
On Sun, 2020-11-01 at 19:42 +0100, Mark Wielaard wrote:
> GCC with -flto finds some (very) unlikely error paths. It flags callers
> of __elf_getphdrnum_chk_rdlock with *dst not yet set because an internal
> call to __elf_getphdrnum_rdlock might not initialize *dst either in one
> particular failure
On Sun, 2020-11-01 at 19:36 +0100, Mark Wielaard wrote:
> GCC with -flto detects some (very) unlikely issues in error paths.
> In theory getting the Ehdr from an Elf handle might fail. But in
> most cases where __libelf_data_type is used, we already have the
> Ehdr anyway. So simply pass that to __
On Mon, 2020-11-02 at 15:23 +0100, Mark Wielaard wrote:
> We used to try to trigger an error during debuginfod scanning using
> a chmod 000 file. But this doesn't always result in an error. Create
> a cyclic symlink instead, which always results in a failure to
> open/read.
Pushed.
The elf-knowledge.h contains various macros to deal with specific ELF
knowledge needed to interpret some ELF constructs that can be ambigious
depending on architecture ABI. Update the comment of SH_ENTSIZE_HASH
to add a more technical description of why it is needed.
Signed-off-by: Mark Wielaard
