Re: [PATCH v2] Support building when fts and obstack aren't part of libc.

2020-11-03 Thread Érico Nogueira via Elfutils-devel
On Tue Nov 3, 2020 at 10:33 PM -03, Dmitry V. Levin wrote: > On Sun, Nov 01, 2020 at 09:48:50PM -0300, Érico Nogueira via > Elfutils-devel wrote: > > From: Érico Rolim > > > > - Make configure.ac test for fts and obstack availability; > > - Add fts and obstack ldflags to all files that need them;

Re: [PATCH v2] Support building when fts and obstack aren't part of libc.

2020-11-03 Thread Dmitry V. Levin
On Sun, Nov 01, 2020 at 09:48:50PM -0300, Érico Nogueira via Elfutils-devel wrote: > From: Érico Rolim > > - Make configure.ac test for fts and obstack availability; > - Add fts and obstack ldflags to all files that need them; > - Add missing argp ldflags to programs in debuginfod/. > > Signed-

Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-03 Thread Dmitry V. Levin
Hi, On Tue, Nov 03, 2020 at 06:26:07PM +0100, Mark Wielaard wrote: > Hi Frank, > > On Tue, 2020-11-03 at 12:07 -0500, Frank Ch. Eigler via Elfutils-devel > wrote: > > > While packaging I noticed that we install the profiles.d files even > > > when the DEBUGINFOD_URLS is empty. I think we should a

multi debug files and artificial module

2020-11-03 Thread Sasha Da Rocha Pinheiro via Elfutils-devel
Hi, we are currently dealing with multiple separate debug files, the normal stripped ones put in .debug/ folder and now the ones generated by DWZ and put into .dwz/ folder. When loading a normal stripped debug files who has a dwz file, I saw the same DIE (same id) twice with different data. Woul

Re: [PATCH v2] debuginfod.cxx: include libintl.h.

2020-11-03 Thread Mark Wielaard
On Tue, 2020-11-03 at 12:16 -0500, Frank Ch. Eigler wrote: > Hi - > > > But don't take it too seriously. I seem to be the only person left > > in > > the project that loves ChangeLog entries. They really help me > > review > > what was changed. If too many contributors complain we can look at > >

Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-03 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > That is a good point. But I think the default setting is wrong if it > isn't actually used/setup. As the profile shell snippets are now they > define the DEBUGINFOD_URLS environment variable as an non-empty string > (although just containing spaces), [...] Good point, we should make it emp

Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-03 Thread Mark Wielaard
Hi Frank, On Tue, 2020-11-03 at 12:07 -0500, Frank Ch. Eigler via Elfutils-devel wrote: > > While packaging I noticed that we install the profiles.d files even > > when the DEBUGINFOD_URLS is empty. I think we should avoid that. > > I think we should install them anyway. They give a sysadmin an

Re: [PATCH v2] debuginfod.cxx: include libintl.h.

2020-11-03 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > But don't take it too seriously. I seem to be the only person left in > the project that loves ChangeLog entries. They really help me review > what was changed. If too many contributors complain we can look at > alternatives. YES PLEASE! :-) As a transition, how about ChangeLog format con

Re: [PATCH v2] debuginfod.cxx: include libintl.h.

2020-11-03 Thread Mark Wielaard
On Mon, 2020-11-02 at 23:44 -0300, Érico Nogueira via Elfutils-devel wrote: > On Mon Nov 2, 2020 at 10:17 PM -03, Mark Wielaard wrote: > > Thanks, added a ChangeLog entry and pushed. > > Sorry for missing these, and thank you for adding them. So, from what I > understand now, the policy is to add

Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-03 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > While packaging I noticed that we install the profiles.d files even > when the DEBUGINFOD_URLS is empty. I think we should avoid that. I think we should install them anyway. They give a sysadmin an easy knob to set a systemwide default, even if the distro build didn't. - FChE

Re: [PATCH v2] Support building when fts and obstack aren't part of libc.

2020-11-03 Thread Mark Wielaard
Hi Érico, On Mon, 2020-11-02 at 23:41 -0300, Érico Nogueira via Elfutils-devel wrote: > On Mon Nov 2, 2020 at 10:13 PM -03, Mark Wielaard wrote: > > Shouldn't we do argp in the same way? This looks simpler than what > > we have now. > > I can send a patch to change it. That would be great. Then

Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-03 Thread Mark Wielaard
Hi Dmitry, On Mon, 2020-11-02 at 08:00 +, Dmitry V. Levin wrote: > When elfutils is configured using --enable-libdebuginfod > --disable-debuginfod, that is, when the library is built and installed > but the server is not, it makes sense to install libdebuginfod.pc > because the latter compleme

Re: [PATCH] Switch from numerical to defined constants for permissions.

2020-11-03 Thread Mark Wielaard
Hi Érico, On Sun, 2020-11-01 at 22:49 -0300, Érico Nogueira via Elfutils-devel wrote: > From: Érico Rolim > > Use defined constants for permission values. Also add fallback > definitions for them in system.h, to allow for compatibility with > systems that don't provide these macros. > > Include

Re: building static libs

2020-11-03 Thread Paul Smith
My ISP appears to get this sort of treatment regularly. I just don't have the time or energy to investigate or switch to something else. I know that's why they can probably get away with it, but... that doesn't give me more time or energy :p On Tue, 2020-11-03 at 00:16 +0100, Mark Wielaard wrote