[Bug debuginfod/26756] some more operational metrics

2020-10-21 Thread fche at redhat dot com via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=26756 Frank Ch. Eigler changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [PATCH v2] PR25756 more debuginfod metrics

2020-10-21 Thread Frank Ch. Eigler via Elfutils-devel
Hi - PR26756: add more prometheus metrics to debuginfod Add an error_count{} family of metrics for each libc/libarchive/http exception instance created during operation. Add a family of fdcache* metrics for tracking fdcache operations and status. Test via a injecting a p

Re: [PATCH] debuginfo fdcache prefetching tweak

2020-10-21 Thread Mark Wielaard
Hi Frank, On Wed, 2020-10-21 at 09:59 -0400, Frank Ch. Eigler wrote: > So we still setup the whole archive, but then don't actually > > iterate > > through it. So shouldn't we check internal_req_p a little earlier and > > just return from handle_buildid_r_match when it is set and we hit "no > > ma

Re: [PATCH] PR25756 more debuginfod metrics

2020-10-21 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > I found this somewhat hard to review since the indenting isn't > following the (GNU) style used in the rest of the file. Please place > curly brackets on their own line when possible. OK. > > +2020-10-20 Frank Ch. Eigler > > + > > + PR26756: more prometheus metrics > > + * debuginf

Re: [PATCH] debuginfo fdcache prefetching tweak

2020-10-21 Thread Frank Ch. Eigler via Elfutils-devel
Hi - Thanks! > So we still setup the whole archive, but then don't actually iterate > through it. So shouldn't we check internal_req_p a little earlier and > just return from handle_buildid_r_match when it is set and we hit "no > match ... grumble, must process the archive"? We do iterate throug

Re: [PATCH] debuginfo fdcache prefetching tweak

2020-10-21 Thread Mark Wielaard
Hi Frank, On Tue, 2020-10-20 at 20:45 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > Subject: [PATCH 2/2] debuginfod: suppress fdcache prefetching during dwz > lookup > > From: Frank Ch. Eigler > > During a recent from-scratch reindexing of the rpm/deb corpus at > debuginfod.elfutils.org,

Re: [PATCH] PR25756 more debuginfod metrics

2020-10-21 Thread Mark Wielaard
Hi Frank, On Tue, 2020-10-20 at 20:44 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > Subject: [PATCH 1/2] PR26756: add more prometheus metrics to debuginfod > > From: Frank Ch. Eigler > > Add an error_count{} family of metrics for each libc/libarchive/http > exception instance created duri

Re: avoiding private headers -

2020-10-21 Thread Mark Wielaard
Hi Brian, On Tue, 2020-10-20 at 20:41 -0400, Brian Dodge via Elfutils-devel wrote: > I am attempting to use elfutils / libdw to create a library for > tagging > function's local/automatic variable storage. I hope to use dwarf info to > get the stack frame offsets, etc. for function's local vars.