Re: Tombstone values in debug sections (was: Range lists, zero-length functions, linker gc)

2020-06-19 Thread David Blaikie via Elfutils-devel
On Fri, Jun 19, 2020 at 1:04 PM Mark Wielaard wrote: > > Hi, > > On Tue, 2020-06-09 at 13:24 -0700, Fangrui Song via Elfutils-devel wrote: > > I want to revive the thread, but focus on whether a tombstone value > > (-1/-2) in .debug_* can cause trouble to various DWARF consumers (gdb, > > debug re

Re: Range lists, zero-length functions, linker gc

2020-06-19 Thread David Blaikie via Elfutils-devel
On Fri, Jun 19, 2020 at 5:00 AM Mark Wielaard wrote: > > Hi, > > On Tue, 2020-06-02 at 11:06 -0700, David Blaikie via Elfutils-devel wrote: > > > I do think combining Split DWARF and LTO might not be the best > > > solution. When doing LTO you probably want something like GCC Early > > > Debug, wh

Re: Buildbot failure in Wildebeest Builder on whole buildset

2020-06-19 Thread Mark Wielaard
Hi, On Fri, 2020-06-19 at 23:20 +, build...@builder.wildebeest.org wrote: > The Buildbot has detected a failed build on builder whole buildset > while building elfutils. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/16/builds/343 > > Buildbot URL: ht

Re: Can dwarf_getscopes{,_die} performance be improved?

2020-06-19 Thread Mark Wielaard
On Mon, 2020-06-15 at 09:54 -0700, Josh Stone via Elfutils-devel wrote: > On 6/13/20 10:40 AM, Milian Wolff wrote: > > Has anyone an idea on how to to post-process the DWARF data to > > optimize the > > lookup of inlined frames? > > SystemTap implements its own cache for repeated lookups -- see >

Re: Difference between dwarf_getscopes and dwarf_getscopes_die

2020-06-19 Thread Mark Wielaard
On Mon, 2020-06-15 at 09:50 -0700, Josh Stone via Elfutils-devel wrote: > On 6/13/20 10:34 AM, Milian Wolff wrote: > > can someone explain me the difference between dwarf_getscopes and > > dwarf_getscopes_die? Ideally, this should then be added to the > > documentation > > too. > > dwarf_getscop

Buildbot failure in Wildebeest Builder on whole buildset

2020-06-19 Thread buildbot
The Buildbot has detected a failed build on builder whole buildset while building elfutils. Full details are available at: https://builder.wildebeest.org/buildbot/#builders/16/builds/343 Buildbot URL: https://builder.wildebeest.org/buildbot/ Worker for this Build: centos-aarch64 Build Reaso

Re: Question on how to copy an elf file and edit the .preinit_array section

2020-06-19 Thread Mark Wielaard
Hi, On Thu, 2020-06-11 at 15:25 +0100, Anastasios Andronidis via Elfutils- devel wrote: > Could someone please help me with this: > https://stackoverflow.com/questions/62293512/inject-a-preinit-array-section-in-an-elf-file-with-libelf > > I'm trying to do some runtime manipulation of an elf fil

Re: Tombstone values in debug sections (was: Range lists, zero-length functions, linker gc)

2020-06-19 Thread Mark Wielaard
Hi, On Tue, 2020-06-09 at 13:24 -0700, Fangrui Song via Elfutils-devel wrote: > I want to revive the thread, but focus on whether a tombstone value > (-1/-2) in .debug_* can cause trouble to various DWARF consumers (gdb, > debug related tools in elfutils and other utilities I don't know about). >

Re: [PATCH 06/10] ar, ranlib: Call fchown before fchmod, explicitly check and ignore errors.

2020-06-19 Thread Mark Wielaard
On Wed, 2020-06-17 at 00:25 +0200, Mark Wielaard wrote: > In ar and ranlib we don't mind if the fchown call fails (it normally > would, then the file simply gets own by the current user). We used to > call fchown before fchmod, but that might ignore (or reset) some mode > flags, so call fchown firs

[Bug debuginfod/25509] Break a cyclic dependency by core packages

2020-06-19 Thread fche at redhat dot com via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=25509 --- Comment #10 from Frank Ch. Eigler --- Comment on attachment 12628 --> https://sourceware.org/bugzilla/attachment.cgi?id=12628 debuginfod: Add --disable-libdebuginfod and --enable-libdebuginfod=dummy. Looks workable. I don't know if we

Re: [PATCH 05/10] libdwfl: Flag an error if CIE return_address_register is invalid.

2020-06-19 Thread Mark Wielaard
On Wed, 2020-06-17 at 00:25 +0200, Mark Wielaard wrote: > If the CIE return address register is invalid (unknown) for the > architecture immediately flag an error and return. Pushed to master.

[Bug debuginfod/25509] Break a cyclic dependency by core packages

2020-06-19 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=25509 Mark Wielaard changed: What|Removed |Added Last reconfirmed||2020-06-19 Assignee|unassig

Re: [PATCH 04/10] libdwfl: When we find a compressed image, use that, don't search for others

2020-06-19 Thread Mark Wielaard
On Wed, 2020-06-17 at 00:25 +0200, Mark Wielaard wrote: > We try to find a compressed vmlinux image ending with either .gz, bz2 or > xz. Stop searching if we find one. Otherwise we will leak a file descriptor > for an earlier one we opened. Pushed to master

Re: [PATCH 03/10] elflint: Explicitly check and ignore elf_compress error.

2020-06-19 Thread Mark Wielaard
On Wed, 2020-06-17 at 00:25 +0200, Mark Wielaard wrote: > We just want to make sure that any section data is decompressed before > use, if the section was already decompressed that is fine, so just ignore > any errors. The make this more clear, explicitly check for errors, then > don't do anything.

Re: [PATCH 02/10] libdw: Add missing FALLTHROUGH in execute_cfi.

2020-06-19 Thread Mark Wielaard
Pushed to master.

Re: Range lists, zero-length functions, linker gc

2020-06-19 Thread Mark Wielaard
Hi, On Tue, 2020-06-02 at 11:06 -0700, David Blaikie via Elfutils-devel wrote: > > I do think combining Split DWARF and LTO might not be the best > > solution. When doing LTO you probably want something like GCC Early > > Debug, which is like Split DWARF, but different, because the Early > > Debug

Re: [PATCH 01/10] backends: Make the reloc_nametable zero element an one char array.

2020-06-19 Thread Mark Wielaard
On Wed, 2020-06-17 at 00:25 +0200, Mark Wielaard wrote: > We are using the reloc_nametable zero element as an char array. > So make that element an actual array (we are actually after one > of the next string arrays in the table). Pushed to master.

[Bug backends/25832] aarch64 fails to compile with musl

2020-06-19 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=25832 --- Comment #3 from Mark Wielaard --- (In reply to Jory A. Pratt from comment #2) > Created attachment 12534 [details] > properly fix aarch64 support for both glibc/musl > > Patch is self explanatory Could you for those of us who don't know