* Mark Wielaard:
>> Regarding the test case, I think if the build target is ELF, it makes
>> sense to check that the elfutils binaries themselves are classified as
>> expected, with the current build flags. This will detect changes
>> required due to the evolution of the toolchain.
>
> That is wh
On Mon, Jul 29, 2019 at 11:22:13AM +0200, Florian Weimer wrote:
> * Mark Wielaard:
>
> > Signed-off-by: Mark Wielaard
>
> Does elfutils use DCO? Then yoy have my signoff as well:
>
> Signed-off-by: Florian Weimer
Thanks. Yes, elfutils uses a Developer Certificate of Origin based on
the linux
* Mark Wielaard:
> On Mon, Jul 29, 2019 at 11:16:31AM +0200, Florian Weimer wrote:
>> * Mark Wielaard:
>>
>> > +/* Called to process standard input if flag_stdin is not no_stdin. */
>> > +static void
>> > +process_stdin (int *status)
>> > +{
>> > + char delim;
>> > + if (flag_stdin == do_stdin
On Mon, Jul 29, 2019 at 11:16:31AM +0200, Florian Weimer wrote:
> * Mark Wielaard:
>
> > +/* Called to process standard input if flag_stdin is not no_stdin. */
> > +static void
> > +process_stdin (int *status)
> > +{
> > + char delim;
> > + if (flag_stdin == do_stdin0)
> > +delim = '\0';
>
On Mon, Jul 29, 2019 at 10:43:56AM +0200, Florian Weimer wrote:
> * Mark Wielaard:
>
> > + if (elf == NULL)
> > +{
> > + /* This likely means it just isn't an ELF file, probably not a
> > +real issue, but warn if verbose reporting. */
> > + if (verbose > 0)
> > + fprintf (std
* Mark Wielaard:
> Signed-off-by: Mark Wielaard
Does elfutils use DCO? Then yoy have my signoff as well:
Signed-off-by: Florian Weimer
You should you list yourself as an author somewhere in the commit
message. This is so much more than what I wrote.
Regarding the test case, I think if the
* Mark Wielaard:
> +/* Called to process standard input if flag_stdin is not no_stdin. */
> +static void
> +process_stdin (int *status)
> +{
> + char delim;
> + if (flag_stdin == do_stdin0)
> +delim = '\0';
> + else
> +delim = '\n';
> +
> + char *buffer = NULL;
> + size_t buffer_size
* Mark Wielaard:
> + if (elf == NULL)
> +{
> + /* This likely means it just isn't an ELF file, probably not a
> + real issue, but warn if verbose reporting. */
> + if (verbose > 0)
> + fprintf (stderr, "warning: %s: %s\n", current_path, elf_errmsg (-1));
> + return fa
