Re: [PATCH] libelf: Fix some 32bit offset/size issues that break updating 4G+ files.

2019-07-02 Thread Lei Zhang
On Tue, Jul 2, 2019 at 4:15 PM Mark Wielaard wrote: > I'll try to create a testcase to replicate the issue to see if I can > debug where the offset value gets truncated. Sounds good to me. > Or do you happen to have the 5.4 GB binary named "chrome" create before > splitting still around somewher

Re: [PATCH] libelf: Fix some 32bit offset/size issues that break updating 4G+ files.

2019-07-02 Thread Mark Wielaard
Hi, On Tue, 2019-07-02 at 11:40 -0700, Lei Zhang wrote: > I tested and found some problems. My test procedure is to: > - Build elfutils at commit 31c8b3f098b0654db8f573b2a15d5b6d07d4d3b0 > - Replace Chromium's buildtools/third_party/eu-strip/bin/eu-strip with > the newly built strip binary. > - Do

Re: [PATCH] libelf: Fix some 32bit offset/size issues that break updating 4G+ files.

2019-07-02 Thread Lei Zhang
On Tue, Jun 18, 2019 at 5:04 PM Mark Wielaard wrote: > My apologies if you tried to upstream this and I missed it. But I think > the patch below is a more complete fix. If you could test it in your > setup that would be great. Hi Mark, I'm not sure if we tried to upstream the patch. So no worrie