Re: [PATCH] libelf: Remove unused __elf_xfctstof.

2019-02-28 Thread Mark Wielaard
On Sun, Feb 24, 2019 at 06:18:11PM +0100, Mark Wielaard wrote: > __elf_xfctstof is only used in case the memory size and file size of ELF > data structures are different. This is never the case. Pushed to master.

Re: [PATCH] libelf: Remove unused internal __elf[32|64]_msize functions.

2019-02-28 Thread Mark Wielaard
On Sun, Feb 24, 2019 at 06:14:36PM +0100, Mark Wielaard wrote: > Those functions were intended for ELF versions where the memory and > file sizes of data structures are different. They were never used > because libelf depends on the file and memory sizes being equal > (otherwise using mmap wouldn't

Re: [PATCH] libelf: There is just one ELF version.

2019-02-28 Thread Mark Wielaard
On Sun, Feb 24, 2019 at 06:07:17PM +0100, Mark Wielaard wrote: > Remove (partially defined out) code and data structures dealing with > multiple ELF versions. There hasn't been a new ELF version in the > last 20 years. Simplify the code a bit by just assuming there will > only be one version (EV_CU

Re: [PATCH] libdwf: Initialize notes early in intuit_kernel_bounds.

2019-02-28 Thread Mark Wielaard
On Sun, Feb 24, 2019 at 03:11:52PM +0100, Mark Wielaard wrote: > We fake initialization of notes with an empty asm statement. But > it is simpler and less confusing to just initialize notes just > before the fopen. Pushed to master.