[Bug general/23320] Incorrect usage of sizeof

2018-06-20 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=23320 Mark Wielaard changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[Bug general/23320] Incorrect usage of sizeof

2018-06-20 Thread serban at us dot ibm.com
https://sourceware.org/bugzilla/show_bug.cgi?id=23320 --- Comment #2 from serban at us dot ibm.com --- Darn, yes, I cloned from another fork, don't know how. I re-cloned from upstream and it build w/no problems now. -- You are receiving this mail because: You are on the CC list for the bug.

Re: [PATCH] backends: add abi_cfi and register_info callbacks for RISC-V

2018-06-20 Thread Mark Wielaard
On Wed, 2018-06-20 at 15:55 +0200, Andreas Schwab wrote: > It's probably because there are more than just simple relocations on > debug sections, more than reloc_simple_type can handle. aha, ok, but it looks like RISCV_(ADD|SUB)(8|16|32|64) should not be too hard to handle. The other ones (RISCV_S

[Bug general/23320] Incorrect usage of sizeof

2018-06-20 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=23320 Mark Wielaard changed: What|Removed |Added CC||mark at klomp dot org --- Comment #1

[Bug general/23320] New: Incorrect usage of sizeof

2018-06-20 Thread serban at us dot ibm.com
https://sourceware.org/bugzilla/show_bug.cgi?id=23320 Bug ID: 23320 Summary: Incorrect usage of sizeof Product: elfutils Version: unspecified Status: UNCONFIRMED Severity: normal Priority: P2 Component: general

Re: [PATCH] backends: add abi_cfi and register_info callbacks for RISC-V

2018-06-20 Thread Mark Wielaard
On Wed, 2018-06-20 at 14:38 +0200, Andreas Schwab wrote: > On Jun 20 2018, Mark Wielaard wrote: > > > > FAIL: run-low_high_pc.sh > > > > > > lowpc: 220, highpc: 220lx > > > ../../elfutils/src/size.c: [c84] 'handle_elf' highpc <= lowpc > > > > > > lowpc: 41c, highpc: 41clx > > > ../../elfutils/s

Re: [PATCH] backends: add abi_cfi and register_info callbacks for RISC-V

2018-06-20 Thread Andreas Schwab
On Jun 20 2018, Mark Wielaard wrote: >> FAIL: run-low_high_pc.sh >> >> lowpc: 220, highpc: 220lx >> ../../elfutils/src/size.c: [c84] 'handle_elf' highpc <= lowpc >> >> lowpc: 41c, highpc: 41clx >> ../../elfutils/src/strip.c: [1c00] 'update_section_size' highpc <= >> lowpc > > That is odd. For w

Re: [PATCH] libdw: Break dwarf_aggregate_size recursion because of type cycles.

2018-06-20 Thread Mark Wielaard
On Mon, 2018-06-18 at 12:44 +0200, Mark Wielaard wrote: > Found by afl-fuzz. An array type (indirectly) referring to itself in the > DIE tree could blow up the stack when dwarf_aggregate_size was called. > Limit the recursion depth to MAX_DEPTH (256) entries. Pushed to master.

Re: [PATCH] libdw: dwarf_peel_type break long chains/cycles.

2018-06-20 Thread Mark Wielaard
On Mon, 2018-06-18 at 10:42 +0200, Mark Wielaard wrote: > Limit the number of chained modifiers to 64 (that is 8 chains for all > 8 modifiers, most of which cannot be chained). This prevents loops in > the DWARF DIE DW_AT_type references. Pushed to master.

Re: [PATCH v2] backends,bpf: add proper relocation support

2018-06-20 Thread Mark Wielaard
On Sat, 2018-06-16 at 13:02 -0700, Yonghong Song wrote: > Due to libdw does not have proper BPF relocation support, > the pahole cannot display filenames correctly for objects > with default llvm options. So we have to invent > a special option "llc -march=bpf -mattr=dwarfris" to > prevent llvm fro

Re: [PATCH] libdw: aggregate_size check NULL result from get_type.

2018-06-20 Thread Mark Wielaard
On Mon, 2018-06-18 at 10:37 +0200, Mark Wielaard wrote: > aggregate_size can be called recursively with the result of get_type. > get_type can return NULL when dwarf_peel_type fails. Found by afl- > fuzz. > > dwarf_aggregate_size when called directly doesn't need a NULL check > because it calls an

Re: [PATCH] backends: add abi_cfi and register_info callbacks for RISC-V

2018-06-20 Thread Mark Wielaard
Hi Andreas, On Mon, 2018-06-18 at 09:59 +0200, Andreas Schwab wrote: > On Jun 15 2018, Mark Wielaard wrote: > > > How does the result of make check look now on a native riscv > > system? > > FAIL: run-native-test.sh > > return_value_location is missing Sadly DWARF doesn't describe how return