Re: [PATCH v2] elflint: fix typo in error diagnostics

2018-05-15 Thread Mark Wielaard
On Tue, May 15, 2018 at 11:18:43PM +0300, Dmitry V. Levin wrote: > Signed-off-by: Dmitry V. Levin Great. Pushed. Thanks, Mark

[PATCH v2] elflint: fix typo in error diagnostics

2018-05-15 Thread Dmitry V. Levin
Signed-off-by: Dmitry V. Levin --- src/ChangeLog | 4 src/elflint.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/ChangeLog b/src/ChangeLog index 419fa20..8a664da 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,7 @@ +2018-05-15 Dmitry V. Levin + +

Re: [PATCH] elflint: fix typo in error diagnostics

2018-05-15 Thread Mark Wielaard
Hi Dmitry, On Tue, May 15, 2018 at 06:34:57PM +0300, Dmitry V. Levin wrote: > +2018-05-15 Dmitry V. Levin > + > + * elflint.c (check_elf_header): Fix typo in error diagnostics. Thanks for spotting this. Looks good. But all contributions need an explicit Signed-off-by line. Could you take a

[PATCH] elflint: fix typo in error diagnostics

2018-05-15 Thread Dmitry V. Levin
diff --git a/src/ChangeLog b/src/ChangeLog index 419fa20..8a664da 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,7 @@ +2018-05-15 Dmitry V. Levin + + * elflint.c (check_elf_header): Fix typo in error diagnostics. + 2018-05-15 Mark Wielaard * readelf.c (print_form_d

Re: [PATCH] backends: add checks for _GLOBAL_OFFSET_TABLE_ and __global_pointer$ on riscv

2018-05-15 Thread Andreas Schwab
On Mai 15 2018, Mark Wielaard wrote: > Is there an ELF abi document for riscv that describes these special > symbols? There is , but it doesn't mention the symbols. I have extracted that out of the binutils sources. Andreas

Re: [PATCH] backends: add checks for _GLOBAL_OFFSET_TABLE_ and __global_pointer$ on riscv

2018-05-15 Thread Mark Wielaard
On Tue, 2018-05-15 at 13:47 +0200, Andreas Schwab wrote: > + > + * riscv_init.c (riscv_init): Hook check_special_symbol. > + * riscv_symbol.c (riscv_check_special_symbol): New function. Looks good. Pushed. I assume this solves some of the self-tests in make check on riscv. Is there an EL

[PATCH] libdw: Recognize GNU DebugFission split units.

2018-05-15 Thread Mark Wielaard
The split dwarf dwo unit id and type are not in the CU header itself, but can be found in the CU DIE DW_AT_GNU_dwo attributes. Use this to set the correct unit_type and id for GNU DebugFission split units. Also show this information in eu-readelf when printing units. Signed-off-by: Mark Wielaard

[PATCH] backends: add checks for _GLOBAL_OFFSET_TABLE_ and __global_pointer$ on riscv

2018-05-15 Thread Andreas Schwab
Signed-off-by: Andreas Schwab --- backends/ChangeLog | 5 + backends/riscv_init.c | 1 + backends/riscv_symbol.c | 32 3 files changed, 38 insertions(+) diff --git a/backends/ChangeLog b/backends/ChangeLog index 63bb7e444e..0dde0ff3f5 100644 --- a/ba

[PATCH] libdw: Add GNU DebugFission attributes, tags, forms and operands.

2018-05-15 Thread Mark Wielaard
Most are handled just like their DWARF5 counterparts. Signed-off-by: Mark Wielaard --- libdw/ChangeLog | 20 libdw/dwarf.h | 16 libdw/dwarf_formaddr.c| 4 +++- libdw/dwarf_formstring.c | 3 ++- libdw/dwarf_formudata.c | 2 ++

[PATCH] libdw, readelf: Handle .debug_*.dwo section name variants.

2018-05-15 Thread Mark Wielaard
The .debug_*.dwo section names are handled just like their none .dwo variants. The section contents is the same as sections without the .dwo name, but they are only found in split-dwarf files. This patch allows opening and inspecting split-dwarf files. It doesn't yet connect the split-dwarf with

[COMMITTED] readelf: Fix 32bit compile issues.

2018-05-15 Thread Mark Wielaard
The buildbot flagged a couple of issues on debian-i686. Fixes pushed to master. Signed-off-by: Mark Wielaard --- src/ChangeLog | 6 ++ src/readelf.c | 10 +- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/ChangeLog b/src/ChangeLog index 4e6887e..419fa20 100644 -

Re: [PATCH] readelf, libdw: Handle DWARF5 .debug_macro.

2018-05-15 Thread Mark Wielaard
On Fri, 2018-05-11 at 15:38 +0200, Mark Wielaard wrote: > Almost identical to GNU .debug_macro extension. Just accept and use > DW_AT_macros where we accept or use DW_AT_GNU_macros. And be a little > stricter in which FORMs we accept (this could have caused problems > with the GNU variant too). Dea

Re: [PATCH] libdw: Fix crashing on illegal/zero Dwarf_Die.

2018-05-15 Thread Mark Wielaard
On Fri, 2018-05-11 at 12:49 +0200, Mark Wielaard wrote: > In some cases we create an illegal Dwarf_Die by clearing all fields. > The idea is that dwarf_tag () on such a Dwarf_Die will return > DW_TAG_invalid, to indicate that the Dwarf_Die is unusable (and other > functions will also return errors)

Re: [PATCH] readelf: Add DWARF5 .debug_line support.

2018-05-15 Thread Mark Wielaard
On Fri, 2018-05-11 at 14:28 +0200, Mark Wielaard wrote: > This only changes the parsing of the directory and file name tables. > It does this by sharing the printing of (non-CU based) from data from > the .debug_macro code. Adding support for printing strx[1234] form > data > by sharing the code th