Re: [PATCH] readelf: Print DIE offset in attribute reading error messages.

2017-11-16 Thread Mark Wielaard
On Tue, 2017-10-03 at 16:59 +0200, Mark Wielaard wrote: > When processing large files it is useful to know the DIE offset if > printing of attributes fails (especially when redirecting the output). > With this change the error message looks like: > >   eu-readelf: DIE [2aeb8ef1] cannot get attribu

Re: [PATCH] Add replacement endian.h and byteswap.h to libgnu

2017-11-16 Thread Mark Wielaard
On Thu, 2017-11-16 at 10:21 +0100, Florian Weimer wrote: > * Ulf Hermann: > > Well, there are a lot of other issues to be fixed if you want to build > > elfutils on anything non-gcc. We could add a further check for those > > builtins and sys/param.h and then add a somewhat less trivial version > >

Re: [PATCH] tests: Add varlocs-self and exprlocs-self tests.

2017-11-16 Thread Mark Wielaard
On Wed, 2017-11-15 at 21:01 +0100, Mark Wielaard wrote: > On Fri, 2017-11-10 at 17:12 +0100, Mark Wielaard wrote: > > Make sure the testcases (library functions they use) don't crash, > > triggers self-check/asserts or leaks memory under valgrind. This > > also helps making sure newer DWARF constru

Re: [PATCH] Add replacement endian.h and byteswap.h to libgnu

2017-11-16 Thread Florian Weimer
* Ulf Hermann: >>> Some systems don't provide endian.h and byteswap.h. The required >>> functions are trivial to define using sys/param.h and gcc builtins, >>> though. >>> >>> Also, include endian.h in dwelf_scn_gnu_compressed_size.c as that uses >>> be64toh(). >> >> This is still an issue with n

Re: [PATCH] Add replacement endian.h and byteswap.h to libgnu

2017-11-16 Thread Ulf Hermann
>> Some systems don't provide endian.h and byteswap.h. The required >> functions are trivial to define using sys/param.h and gcc builtins, >> though. >> >> Also, include endian.h in dwelf_scn_gnu_compressed_size.c as that uses >> be64toh(). > > This is still an issue with non-glibc, non-BSD compil

Re: [PATCH] Add replacement endian.h and byteswap.h to libgnu

2017-11-16 Thread Florian Weimer
* Ulf Hermann: > Some systems don't provide endian.h and byteswap.h. The required > functions are trivial to define using sys/param.h and gcc builtins, > though. > > Also, include endian.h in dwelf_scn_gnu_compressed_size.c as that uses > be64toh(). This is still an issue with non-glibc, non-BSD