On Fri, Aug 18, 2017 at 03:35:35PM +0200, Ulf Hermann wrote:
> They aren't used and cause warnings from autoconf.
Again I don't have internet access to lookup the autoconf manual.
But I don't believe this is correct. Removing the so_SOURCES is not
the same as leaving them empty. The change as prop
On Fri, Aug 18, 2017 at 05:20:02PM +0200, Ulf Hermann wrote:
> We don't know sizeof(pid_t) as it's not specified in any standard. In
> order to still print it, we cast to long long, the largest integer type
> we can easily print.
That is surprising. But then printing it as long long is as good as
On Fri, Aug 18, 2017 at 03:50:42PM +0200, Ulf Hermann wrote:
> If not, throw an error unless symbol versioning was explicitly
> disabled.
I am not sure supporting systems don't do symbol versioning is a
very good thing to do. But since we do (hohum). It does make sense
to explicitly check for it.
On Fri, Aug 18, 2017 at 02:05:10PM +0200, Ulf Hermann wrote:
> gcc defaults to using struct layouts that follow the native conventions,
> even if __attribute__((packed)) is given. In order to get the layout we
> expect, we need to tell gcc to always use the gcc struct layout, at
> least for packed
On Fri, Aug 18, 2017 at 04:04:28PM +0200, Ulf Hermann wrote:
> Some systems don't have rpath. In that case the backends need to be
> made available by some external mechanism. Provide a configure switch
> to explicitly turn off the setting of rpaths. Throw an error if that is
> not set and rpath is
On Fri, Aug 18, 2017 at 01:06:36PM +0200, Ulf Hermann wrote:
> If so, define attribute_hidden to be empty. Also, use attribute_hidden
> in all places where we hide symbols. If this attribute is missing, it
> simply means that we cannot hide private symbols in the binary using
> attributes. This dis
On Fri, Aug 18, 2017 at 05:03:50PM +0200, Ulf Hermann wrote:
> We assume core files from linux systems, so we should use the linux
> version of the signals when reading them. Other OS might have different
> signal numbers.
Thanks, applied.
Note that according to man 7 signal SIGBUS could actually
On Fri, Aug 18, 2017 at 12:41:11PM +0200, Ulf Hermann wrote:
> Those flags are not available on all platforms, and omitting them when
> not available will not cause any harm. In particular:
>
> -z,defs disallows undefined symbols in object files. This option is
> unsupported if the target binary f
On Fri, Aug 18, 2017 at 03:17:38PM +0200, Ulf Hermann wrote:
> -rdynamic is meant for ELF objects that need to export internal
> symbols to libraries they link to, but deleted-lib.so does not link to
> anything else and doesn't have any internal symbols.
>
> Note that the "deleted" test program do
