Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.

2017-07-17 Thread Mark Wielaard
On Tue, Jul 18, 2017 at 01:24:46AM +0300, Dmitry V. Levin wrote: > I reviewed and approved both of these commits assuming that they brought > no regressions. If sys/ptrace.h from glibc 2.25 could be included before > or after linux/ptrace.h, this shouldn't have changed in glibc 2.26. > > In other

Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.

2017-07-17 Thread Dmitry V. Levin
On Mon, Jul 17, 2017 at 06:41:47PM +0200, Mark Wielaard wrote: > On Mon, 2017-07-17 at 19:29 +0300, Dmitry V. Levin wrote: > > On Mon, Jul 17, 2017 at 05:44:54PM +0200, Mark Wielaard wrote: > > > glibc 2.26 changed the sys/ptrace.h header so that it cannot be included > > > after asm/ptrace.h. We s

Re: Dwarf_FDE (libdw)

2017-07-17 Thread Sasha Da Rocha Pinheiro
Yes, that's what I am trying to do right now. Try/catch blocks or exception handling is the right term I guess. From: Mark Wielaard Sent: Monday, July 17, 2017 12:48 PM To: Sasha Da Rocha Pinheiro Cc: elfutils-devel@sourceware.org Subject: Re: Dwarf_FDE (libdw)   On Mon, Jul 17, 2017 at 05:

Re: Dwarf_FDE (libdw)

2017-07-17 Thread Mark Wielaard
On Mon, Jul 17, 2017 at 05:16:00PM +, Sasha Da Rocha Pinheiro wrote: > So you're saying that the augmentation data of a FDE is the augmentation > data of its CIE? > https://refspecs.linuxfoundation.org/LSB_3.0.0/LSB-PDA/LSB-PDA/ehframechpt.html > says differently. If you need to read the low-l

Re: File index given line (libdw)

2017-07-17 Thread Sasha Da Rocha Pinheiro
I understand your argument. Since I was doing: dwarf_getsrclines(&cuDIE, &lineBuffer, &lineCount) dwarf_getsrcfiles(&cuDIE, &files, &filecount) I knew they were related because I used the same DIE. But someone trying to use a function which returns only the index could be confusing abou

Re: Dwarf_FDE (libdw)

2017-07-17 Thread Sasha Da Rocha Pinheiro
So you're saying that the augmentation data of a FDE is the augmentation data of its CIE? https://refspecs.linuxfoundation.org/LSB_3.0.0/LSB-PDA/LSB-PDA/ehframechpt.html says differently. The thing is I need to get catch blocks, and eh_frame is not exactly Dwarf format. That's why I need FDE au

Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.

2017-07-17 Thread Mark Wielaard
On Mon, 2017-07-17 at 19:29 +0300, Dmitry V. Levin wrote: > On Mon, Jul 17, 2017 at 05:44:54PM +0200, Mark Wielaard wrote: > > glibc 2.26 changed the sys/ptrace.h header so that it cannot be included > > after asm/ptrace.h. We still need to include the kernel asm/ptrace.h for > > the ptrace_area de

Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.

2017-07-17 Thread Dmitry V. Levin
On Mon, Jul 17, 2017 at 05:44:54PM +0200, Mark Wielaard wrote: > glibc 2.26 changed the sys/ptrace.h header so that it cannot be included > after asm/ptrace.h. We still need to include the kernel asm/ptrace.h for > the ptrace_area definition. Including it after sys/ptrace.h works against > both old

[COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.

2017-07-17 Thread Mark Wielaard
glibc 2.26 changed the sys/ptrace.h header so that it cannot be included after asm/ptrace.h. We still need to include the kernel asm/ptrace.h for the ptrace_area definition. Including it after sys/ptrace.h works against both old and new glibc. Signed-off-by: Mark Wielaard --- backends/ChangeLog

Re: Dwarf_FDE (libdw)

2017-07-17 Thread Mark Wielaard
On Mon, 2017-07-17 at 04:12 +, Sasha Da Rocha Pinheiro wrote: > So how do you get the augmentation data out of a Dwarf_Frame? You don't. You can only get the actual information relevant for the frame through the augmentation data from the Dwarf_Frame. Is there information missing you need? >

Re: File index given line (libdw)

2017-07-17 Thread Mark Wielaard
On Mon, 2017-07-17 at 04:10 +, Sasha Da Rocha Pinheiro wrote: > [Resending cause it seems it didn't go] Probably because it had an HTML attachement. The mailinglist rejects emails with HTML. > You understood what I need when you said: > "So you want to keep a vector with filenames for a parti

Re: [PATCH] strip: Add --keep-section=SECTION and --remove-section=SECTION.

2017-07-17 Thread Mark Wielaard
On Fri, 2017-07-14 at 12:24 -0700, Josh Stone wrote: > On 07/14/2017 08:28 AM, Mark Wielaard wrote: > > Adds two new output options: > > > > --keep-section=SECTION Keep the named section. SECTION is an extended > > wildcard pattern. May be given more than once. > > I