[PATCH 2/2] Don't overflow in __libdw_in_section

2017-05-09 Thread Ulf Hermann
This exposes a bug in dwarf_formstring as detected by the dwarf-getmacros test. We cannot unconditionally assume that a string is in either the IDX_debug_info or the IDX_debug_types section as determined by cu_sec_idx. Signed-off-by: Ulf Hermann --- libdw/ChangeLog | 4 libdw/libdwP.h | 3

[PATCH 1/2] Initialize type_offset of fake_cu

2017-05-09 Thread Ulf Hermann
Signed-off-by: Ulf Hermann --- libdw/ChangeLog | 4 libdw/dwarf_getmacros.c | 1 + 2 files changed, 5 insertions(+) diff --git a/libdw/ChangeLog b/libdw/ChangeLog index eda35c5..665c232 100644 --- a/libdw/ChangeLog +++ b/libdw/ChangeLog @@ -1,3 +1,7 @@ +2017-05-09 Ulf Hermann + +

Re: Problems with dwarf-getmacros test

2017-05-09 Thread Ulf Hermann
Do you have the whole call stack of that failed __libdw_read_offset call? Which source line in tests/dwarf-getmacros.c prints the "(null)"? Actually I just managed to catch a backtrace by inserting an infinite loop at the point where it would normally return -1. It turns out the address we are l

Re: Problems with dwarf-getmacros test

2017-05-09 Thread Ulf Hermann
Do you have the whole call stack of that failed __libdw_read_offset call? Which source line in tests/dwarf-getmacros.c prints the "(null)"? Actually I just managed to catch a backtrace by inserting an infinite loop at the point where it would normally return -1. It turns out the address we are

Re: Problems with dwarf-getmacros test

2017-05-09 Thread Ulf Hermann
> Is it only with testfile-macros? > All other testfiles always run correctly? Yes, it only happens with the testfile-macros check at 0xb. > Do you have the whole call stack of that failed __libdw_read_offset > call? Which source line in tests/dwarf-getmacros.c prints the "(null)"? I'm having a

Re: don't run elfutils as root in ABRT

2017-05-09 Thread Mark Wielaard
Hi Adam, Please don't include HTML mail. The mailinglist will not accept it. (In this case it is your HTML avast signature that looks like an advertisement.) On Tue, 2017-05-09 at 10:49 +0200, Adam Šulc wrote: > On Mon, May 8, 2017 at 2:10 PM, Mark Wielaard wrote: > > On Fri, 2017-05-05 at 18:25

Re: Problems with dwarf-getmacros test

2017-05-09 Thread Mark Wielaard
On Mon, 2017-05-08 at 18:22 +0200, Ulf Hermann wrote: > I frequently get failures from the run-dwarf-getmacros.sh test, on > testfile-macros:0xb. The test repeatedly outputs "(null)" instead of the > actual macros and then runs into the assert at dwarf-getmacros.c:50. The > failure is very nonde