On Fri, Apr 28, 2017 at 12:35:26PM +0200, Ulf Hermann wrote:
> On 04/27/2017 09:41 PM, Mark Wielaard wrote:
> > On Thu, Apr 20, 2017 at 04:54:26PM +0200, Ulf Hermann wrote:
> >> At least one test (dwfl-addr-sect) depends on the order of elf sections
> >> with equal addresses. This is not guaranteed
On Tue, May 02, 2017 at 12:17:24PM +0200, Ulf Hermann wrote:
> > You can get uname() on Windows through gnulib, but at the cost at
> > linking to additional windows DLLs. It calls gethostname and for that
> > we need to link against ws2_32.dll. That's an unreasonable dependency
> > for getting some
On Thu, 2017-04-27 at 10:31 +0200, Ulf Hermann wrote:
> > Maybe something like the attached patch?
>
> Well that's actually the original patch (as opposed to V2) with relaxed
> test conditions. You can write that a bit nicer by setting the new PC
> directly after retrieving LR and returning earl
Maybe we can cleanup that last
one once we integrate gnulib (which I believe has a good/64-off_t fts.h
already).
gnulib is among the bad ones. Or, at least we detect it as bad.
Ulf
On Thu, 2017-04-20 at 16:31 +0200, Ulf Hermann wrote:
> config.h doesn't have include guards, so including it twice is bad. We
> deal with this by checking for PACKAGE_NAME, but only in some places.
> Once we start using gnulib, we will need to include config.h before any
> gnulib-generated headers
On Thu, 2017-04-20 at 15:58 +0200, Ulf Hermann wrote:
> F_GETFD is both cheaper and easier to port, and otherwise has the same
> effect here.
At least for the specific case of checking for failure with errno ==
EBADF it is identical. Applied to master.
Thanks,
Mark
On Thu, 2017-04-20 at 15:55 +0200, Ulf Hermann wrote:
> __attribute__ is a GNU extension. If we want to link against the
> libraries using a different compiler, it needs to be disabled. It was
> already disabled in libdw.h, and this patch extends this to the other
> headers. We move the defines to
You can get uname() on Windows through gnulib, but at the cost at
linking to additional windows DLLs. It calls gethostname and for that
we need to link against ws2_32.dll. That's an unreasonable dependency
for getting something we cannot use anyway. I suggest we just set
errno to ENOTSUP then.
I
