Re: [Dwarf-Discuss] DWARF and source text embedding

2018-02-13 Thread Andres Freund
Hi, On 2018-02-13 16:45:23 -0800, Michael Eager wrote: > I can imagine situations where embedding ephemeral generated source in a > DWARF debug entry can make sense. But I have the feeling that there is > more to this in your environment than what I imagine. Can you give a > description of the u

Re: [Dwarf-Discuss] DWARF and source text embedding

2018-02-13 Thread Michael Eager
On 02/13/18 09:37, sc...@scottlinder.com wrote: Michael, Paul, In the current proposal, it is not an error to have any value (including an empty string) in the _source attribute when the _has_source flag is true, which allows for embedding an empty source string. After seeing more feedback on

Re: [Dwarf-Discuss] DWARF and source text embedding

2018-02-13 Thread scott
Michael, In the case of this proposal, then, I suggest the CU fields (AT_{name,comp_dir}) retain their exact current definitions. Language implementations, regardless of whether they might want to support embedding source, currently use the filesystem. This extension is essentially just cachein

Re: [Dwarf-Discuss] DWARF and source text embedding

2018-02-13 Thread scott
Michael, Paul, In the current proposal, it is not an error to have any value (including an empty string) in the _source attribute when the _has_source flag is true, which allows for embedding an empty source string. After seeing more feedback on this point, I think you are right that the ext