Why is this WiFi booster so popular across the World?

2019-08-07 Thread Justin
Internet providers make big money by overcharging you for faster internet lines. Could this little device really be the one solution that we've all been waiting for? Frequency: 2.4Ghz Wireless Rate: 300Mbps Interface: 1 10/100Mbps WAN/LAN RJ45 Ports Amazing new technology find out here! http://

Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings

2018-07-03 Thread Justin Skists
e_t count, > continue; > } > > - index = simple_strtoul(cp, &temp, 10); > + index = simple_ktrtoul(cp, &temp, 10); Did you compile this? Justin. ___ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/3] staging: rtl8192u: Prune the rtl819x_HT.h file of unused definitions.

2018-06-30 Thread Justin Skists
easier to visually diff the patches for review. (Plus, the previous code is never lost in the git tree, anyway) :-) Justin ___ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.

2018-06-25 Thread Justin Skists
ootlin.com/linux/v4.18-rc1/source/Documentation/process/submitting-patches.rst See section "13) Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes:" Hope that helps, Justin. ___ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-18 Thread Justin Skists
> On 18 June 2018 at 09:46 Samuel Thibault wrote: > > > Justin Skists, le lun. 18 juin 2018 09:41:44 +0100, a ecrit: > > > On 18 June 2018 at 06:34 Gregory Nowak wrote: > > > With /sys/accessibility/speakup/synth set to bns, I am getting output > > >

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-18 Thread Justin Skists
y/speakup/synth, I get no speech at all from either > synthesizer. Is this a known issue, or a regression due to the patch? Justin. ___ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: speakup: refactor synths array to use a list

2018-06-06 Thread Justin Skists
On Wed, Jun 06, 2018 at 03:26:28PM +0200, Samuel Thibault wrote: > Hello, > > Justin Skists, le lun. 04 juin 2018 10:52:12 +0100, a ecrit: > > The synths[] array is a collection of synths acting like a list. > > There is no need for synths to be an array, so refactor synths[

Re: staging: rtl8192e: Series of coding style changes

2018-06-06 Thread Justin Skists
> On 06 June 2018 at 12:39 John Whitmore wrote: > Again these are just some simple coding style changes to the file, so nothing > of importance. If it keeps grumpy maintainers happy, then it's of great importance! :-) Justin ___ deve

[PATCH] staging: speakup: refactor synths array to use a list

2018-06-04 Thread Justin Skists
: Justin Skists --- drivers/staging/speakup/spk_types.h | 2 ++ drivers/staging/speakup/synth.c | 40 ++--- 2 files changed, 15 insertions(+), 27 deletions(-) diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h index 3e082dc3d45c

Re: [PATCH 2/6] staging: android: Clean up license identifiers

2018-05-14 Thread Justin Skists
/ashmem.h > > @@ -1,13 +1,9 @@ > > -// SPDX-License-Identifier: (GPL-2.0 OR Apache-2.0) > > +/* SPDX-License-Identifier: GPL-2.0 OR Apache-2.0 */ > > > // was correct for SPDX headers. Sorry, header files use the /* ... */ format. :) https://elixir.bootlin.com/linux/v

[PATCH] staging: lustre: lnet: add static to libcfs_dev declaration

2018-05-10 Thread Justin Skists
Add a static prefix to the declaration for libcfs_dev. This would fix the following sparse warning: drivers/staging/lustre/lnet/libcfs/module.c:317:19: warning: symbol 'libcfs_dev' was not declared. Should it be static? Signed-off-by: Justin Skists --- drivers/staging/lustre/l

[PATCH] staging: lustre: lnet: use correct 'magic' test

2018-03-21 Thread Justin Skists
message. Fixes: 80782927e3aa ("staging: lustre: Fix unneeded byte-ordering cast") Cc: NeilBrown Signed-off-by: Justin Skists --- drivers/staging/lustre/lnet/lnet/acceptor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/lnet/accept

Re: [PATCH] staging: lustre: Fix unneeded byte-ordering cast

2018-03-20 Thread Justin Skists
On 20 March 2018 at 01:06, NeilBrown wrote: > On Sat, Mar 17 2018, Justin Skists wrote: > >> Fix sparse warning: >> >> CHECK drivers/staging//lustre/lnet/lnet/acceptor.c >> drivers/staging//lustre/lnet/lnet/acceptor.c:243:30: warning: cast to >> restrict

[PATCH] staging: lustre: Fix unneeded byte-ordering cast

2018-03-17 Thread Justin Skists
ned-off-by: Justin Skists --- drivers/staging/lustre/lnet/lnet/acceptor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/lnet/acceptor.c b/drivers/staging/lustre/lnet/lnet/acceptor.c index fb478e20e204..13e981781b9a 100644 --- a/drivers/staging/lustre

[PATCH] staging/speakup: fix checkpatch.pl warning in speak_char()

2017-09-06 Thread Justin Skists
correct the following warning from checkpatch.pl:- WARNING: Prefer using '"%s...", __func__' to using 'speak_char', this function's name, in a string Signed-off-by: Justin Skists Acked-by: Samuel Thibault --- drivers/staging/speakup/main.c | 2 +- 1 file

Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional

2017-05-05 Thread Justin Vreeland
Bastien Nocera writes: > On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote: >> Ensure checkpatch compliance >> >> > Signed-off-by: Justin Vreeland >> --- >> v2: >>   - Added commit message >>   - Fixed overly long lines >> &g

Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional

2017-05-05 Thread Justin Vreeland
Bastien Nocera writes: > On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote: >> Ensure checkpatch compliance >> >> > Signed-off-by: Justin Vreeland >> --- >> v2: >>   - Added commit message >>   - Fixed overly long lines >> &g

[PATCH v2 7/7] staging: rtl8723bs: Do not use assignment in if condition

2017-05-01 Thread Justin Vreeland
Ensure checkpatch compliance Signed-off-by: Justin Vreeland Reviewed-by: Bastien Nocera --- v2: - Added commit message - Added Reviewed-by tag drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal

[PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional

2017-05-01 Thread Justin Vreeland
Ensure checkpatch compliance Signed-off-by: Justin Vreeland --- v2: - Added commit message - Fixed overly long lines drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 18 -- drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 12 ++-- drivers/staging/rtl8723bs/hal

[PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses

2017-05-01 Thread Justin Vreeland
Enclosing macros with complex values ensures expression is evaluated as expected. Signed-off-by: Justin Vreeland --- v2: - Added spaces around plus signs - Fixed line over 80 columns - Added commit message drivers/staging/rtl8723bs/hal/odm.h | 5 - 1 file changed, 4 insertions(+), 1

[PATCH v2 6/7] staging: rtl8723bs: Fix spacing around '<'

2017-05-01 Thread Justin Vreeland
Ensure checkpatch compliance Signed-off-by: Justin Vreeland Reviewed-by: Bastien Nocera --- v2: - Added commit message - Added Reviewed-by tag drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal

[PATCH v2 5/7] staging: rtl8723bs: Fix pointer style

2017-05-01 Thread Justin Vreeland
Fix "(foo*)" should be "(foo *)" Fix "foo * bar" should be "foo *bar" Signed-off-by: Justin Vreeland Reviewed-by: Bastien Nocera --- v2: - Added Reviewed-by tag drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 +++--- 1 file changed, 3 insertions(

[PATCH v2 2/7] staging: rtl8723bs: Wrap multi-line macros in do-while loop

2017-05-01 Thread Justin Vreeland
Wrapping in do-while ensures macros are executed as expected. Signed-off-by: Justin Vreeland --- v2: - Added commit message drivers/staging/rtl8723bs/hal/odm_debug.h | 81 +-- 1 file changed, 45 insertions(+), 36 deletions(-) diff --git a/drivers/staging

[PATCH v2 1/7] staging: rtl8723bs: Fix initialization of static variables

2017-05-01 Thread Justin Vreeland
Do not initialize static to 0 Do not initialize static to false Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 4 ++-- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +- drivers/staging

[PATCH v2 0/7] staging: rtl8732: Various checkpatch fixes

2017-05-01 Thread Justin Vreeland
v2: Added commit messages Fixed overly long lines Added Bastien Nocera's Reviewed-by tag - Also fixed commit messages marked reviewed, hope that's OK. The patch contents are identical. Justin Vreeland (7): staging: rtl8723bs: Fix initialization of static variables

[PATCH 1/7] staging: rtl8723bs: Fix initialization of static variables

2017-04-27 Thread Justin Vreeland
Do not initialize static to 0 Do not initialize static to false Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 4 ++-- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +- drivers/staging

[PATCH 6/7] staging: rtl8723bs: Fix spacing around '<'

2017-04-27 Thread Justin Vreeland
Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c index 991e3adcc42c..cc6eb32c5f71 100644 --- a

[PATCH 0/7] staging: rtl8732: Various checkpatch fixes

2017-04-27 Thread Justin Vreeland
Justin Vreeland (7): staging: rtl8723bs: Fix initialization of static variables staging: rtl8723bs: Wrap multi-line macros in do-while loop staging: rtl8723bs: Macros with complex values should be enclosed in parentheses staging: rtl8723bs: Move braces to same line as conditional

[PATCH 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses

2017-04-27 Thread Justin Vreeland
Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/odm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h index 0b3541a91548..13c4aebd178e 100644 --- a/drivers/staging/rtl8723bs/hal/odm.h

[PATCH 4/7] staging: rtl8723bs: Move braces to same line as conditional

2017-04-27 Thread Justin Vreeland
Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 15 +-- drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 9 +++-- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 ++ 3 files changed, 10 insertions(+), 20 deletions(-) diff --git a

[PATCH 7/7] staging: rtl8723bs: Do not use assignment in if condition

2017-04-27 Thread Justin Vreeland
Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c index cc6eb32c5f71..c189eb575654 100644 --- a

[PATCH 5/7] staging: rtl8723bs: Fix pointer style

2017-04-27 Thread Justin Vreeland
Fix "(foo*)" should be "(foo *)" Fix "foo * bar" should be "foo *bar" Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs

[PATCH 2/7] staging: rtl8723bs: Wrap multi-line macros in do-while loop

2017-04-27 Thread Justin Vreeland
Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/odm_debug.h | 80 +-- 1 file changed, 44 insertions(+), 36 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm_debug.h b/drivers/staging/rtl8723bs/hal/odm_debug.h index a89690ea6ba9