Re: [PATCH 1/3] clk: fix redefinition of clk_prepare on MIPS with HAVE_LEGACY_CLK

2020-11-17 Thread Krzysztof Kozlowski
On Tue, Nov 17, 2020 at 11:41:57PM -0800, Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2020-11-15 09:09:48) > > COMMON_CLK even though is a user-selectable symbol, is still selected by > > multiple other config options. COMMON_CLK should not be used when > > legacy clocks are provided by arc

Re: [PATCH 1/3] clk: fix redefinition of clk_prepare on MIPS with HAVE_LEGACY_CLK

2020-11-17 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2020-11-15 09:09:48) > COMMON_CLK even though is a user-selectable symbol, is still selected by > multiple other config options. COMMON_CLK should not be used when > legacy clocks are provided by architecture, so it correctly depends on > !HAVE_LEGACY_CLK. > > However

[staging:staging-linus] BUILD SUCCESS 2dde2821b57f12fa8601d35d438b5e300fcbbe1d

2020-11-17 Thread kernel test robot
lmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a006-20201117 i386 randconfig-a005-20201117 i386 randconfig-a001-202

Re: [PATCH 4/8] regulator: hi6421v600-regulator: move it from staging

2020-11-17 Thread Mark Brown
On Tue, Nov 17, 2020 at 09:38:30AM +0100, Mauro Carvalho Chehab wrote: > Mark Brown escreveu: > > This also appears to be missing a DT binding document, binding > > documentation is required for anything with DT support. > The DT binding is documented on patch 3/8, together with MFD. > As there

Re: [PATCH 2/8] spmi: hi6421-spmi-pmic: move driver from staging

2020-11-17 Thread kernel test robot
Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10-rc4 next-20201117] [cannot apply to staging/staging-testing robh/for-next lee-mfd/for-mfd-next] [If your patch is applied to the wrong git tree, kindly drop us a

Re: [PATCH 4/8] regulator: hi6421v600-regulator: move it from staging

2020-11-17 Thread Mark Brown
On Tue, Nov 17, 2020 at 09:08:22AM +0100, Mauro Carvalho Chehab wrote: > Mark Brown escreveu: > > This probe code looks very different to other regulator drivers, this > > alone should have been a warning that the driver needs some substantial > > refactoring here. As indicated information about

Re: [PATCH v2] drivers: most: add ALSA sound driver

2020-11-17 Thread Christian.Gromm
On Tue, 2020-11-17 at 11:41 +0300, Dan Carpenter wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Tue, Nov 17, 2020 at 08:08:50AM +, [email protected] wrote: > > On Tue, 2020-11-10 at 11:48 +0300, Dan Carpenter wrote: > >

Re: [PATCH v2] drivers: most: add ALSA sound driver

2020-11-17 Thread Christian.Gromm
On Tue, 2020-11-10 at 11:48 +0300, Dan Carpenter wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, Nov 06, 2020 at 05:30:54PM +0100, Christian Gromm wrote: > > +static struct list_head adpt_list; > > + > > +#define MOST_PCM_INFO (SND

Re: [PATCH 1/8] phy: phy-hi3670-usb3: move driver from staging into phy

2020-11-17 Thread Vinod Koul
On 17-11-20, 07:55, Mauro Carvalho Chehab wrote: > Em Mon, 16 Nov 2020 09:31:06 -0600 > Rob Herring escreveu: > > > On Mon, Nov 16, 2020 at 01:59:27PM +0100, Mauro Carvalho Chehab wrote: > > > The phy USB3 driver for Hisilicon 970 (hi3670) is ready > > > for mainstream. Mode it from staging into

Re: [PATCH v2] drivers: most: add ALSA sound driver

2020-11-17 Thread Dan Carpenter
On Tue, Nov 17, 2020 at 08:08:50AM +, [email protected] wrote: > On Tue, 2020-11-10 at 11:48 +0300, Dan Carpenter wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Fri, Nov 06, 2020 at 05:30:54PM +0100, Christian G

Re: [PATCH 4/8] regulator: hi6421v600-regulator: move it from staging

2020-11-17 Thread Mauro Carvalho Chehab
Em Mon, 16 Nov 2020 18:38:33 + Mark Brown escreveu: > On Mon, Nov 16, 2020 at 01:59:30PM +0100, Mauro Carvalho Chehab wrote: > > > This driver is ready for mainstream. Move it out of staging. > > There's quite a few issues here, to be honest I'm disappointed some of > them weren't caught

[PATCH] media: atomisp: remove redundant NULL check of "params"

2020-11-17 Thread Ding Xiang
The check result of (!A || (A && B)) is equivalent to (!A || B), so remove redundant NULL check of "params" Signed-off-by: Ding Xiang --- drivers/staging/media/atomisp/pci/sh_css_params.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/sh_

Re: [PATCH 4/8] regulator: hi6421v600-regulator: move it from staging

2020-11-17 Thread Mauro Carvalho Chehab
Hi Mark, Em Mon, 16 Nov 2020 18:38:33 + Mark Brown escreveu: > > This driver is ready for mainstream. Move it out of staging. > > There's quite a few issues here, to be honest I'm disappointed some of > them weren't caught during staging review, this needs fairly substantial > work and th