On Tue, May 15 2018, Sergio Paracuellos wrote:
> The following patch series fix some checkpatch complains
> about this driver. There is still some complains about dt-bindings
> not being added to its correct Documentation place inside the kernel
> but it should be ok when this driver will be move
Recommended indentation by Lindent on file comedi_compat32.c
Signed-off-by: Pratik Jain
---
drivers/staging/comedi/comedi_compat32.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/comedi_compat32.c
b/drivers/staging/comedi/comedi_compat32
On Tue, May 15, 2018 at 11:01:20AM +1000, NeilBrown wrote:
> On Mon, May 14 2018, Sergio Paracuellos wrote:
>
> > The following patch series fix all remaining checkpatch complains
> > about this driver. Changes have not been tested and also compiled
> > but it should not have any problem about the
On Tue, May 15, 2018 at 11:26:38AM +1000, NeilBrown wrote:
> On Mon, May 14 2018, Sergio Paracuellos wrote:
>
> > Documentation related with device tree and its checkpatch complains
> > have been added. Update TODO file accordingly.
> >
> > Signed-off-by: Sergio Paracuellos
> > ---
> > drivers/s
On Tue, May 15, 2018 at 11:21:20AM +1000, NeilBrown wrote:
> On Mon, May 14 2018, Sergio Paracuellos wrote:
>
> > This commit add missing dt bindings documentation for mt7621-gpio
> > driver. After this checkpatch script complain about this
> > issue dissapears.
> >
> > Signed-off-by: Sergio Parac
There is a complain of checkpatch script about the not documented
DT compatible string for vendor "mtk". Add it to vendor-prefixes.txt
file.
Signed-off-by: Sergio Paracuellos
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentati
This commit updates TODO file with missing things to
get this driver ready to be mainlined.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-gpio/TODO | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-gpio/TODO b/drivers/staging/mt7621-gpio/
This patch silence some complains of checkpatch script because
of the use of long lines.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-gpio/gpio-mt7621.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/mt7621-gpio/gpio-mt762
This commit add missing dt bindings documentation for mt7621-gpio
driver. There is some missing stuff here about interrupts with is
not also being used in the mt7621.dtsi file. So just include in
staging a incomplete version before moving this to kernel's dt-bindings
place.
Signed-off-by: Sergio P
It's good to have SPDX identifiers in driver files to make it easier to
audit the kernel tree for correct licenses.
Fix up the one of staging gpio-mt7621 file to have a proper SPDX
identifier, based on the license text in the file itself. The SPDX
identifier is a legally binding shorthand, which c
The following patch series fix some checkpatch complains
about this driver. There is still some complains about dt-bindings
not being added to its correct Documentation place inside the kernel
but it should be ok when this driver will be move out of staging.
Changes have not been tested and also co
On Mon, May 14 2018, James Simmons wrote:
> From: Dmitry Eremin
>
> Linux kernel v3.14 adds set_acl method to inode operations.
> This patch adds support to Lustre for proper acl management.
>
> Signed-off-by: Dmitry Eremin
> Signed-off-by: John L. Hammond
> Signed-off-by: James Simmons
> Inte
On Mon, May 14 2018, James Simmons wrote:
> From: Lai Siyao
>
> Currently we set LU_OBJECT_HEARD_BANSHEE on object when we want
> to remove object from cache, but this may lead to deadlock, because
> when other process lookup such object, it needs to wait for this
> object until release (done at
From: Andrew Perepechko
The refill operation of the xattr cache does not know the
reply size in advance, so it makes a guess based on
the maxeasize value returned by the MDS.
In practice, it allocates 16 KiB for the common case and
4 MiB for the large xattr case. However, a typical reply
is just
From: "John L. Hammond"
Pre 2.10.1 MDTs will crash when they receive a listxattr (MDS_GETXATTR
with OBD_MD_FLXATTRLS) RPC for an orphan or dead object. So for
clients connected to these older MDTs, try to avoid sending listxattr
RPCs by making the bulk getxattr (MDS_GETXATTR with OBD_MD_FLXATTRAL
Fixed the bugs in the set_acl patch pointed out by Dan Carpenter.
Rebased the next patch 'remove unused parameter..." on the parent
patch. Added newer xattr fixes that were recently pushed.
Andrew Perepechko (1):
staging: lustre: mdc: excessive memory consumption by the xattr cache
Dmitry Eremi
From: Fan Yong
Originally, the limitation of ACL entries is 32, that is not
enough for some use cases. In fact, restricting ACL entries
count is mainly for preparing the RPC reply buffer to receive
the ACL data. So we cannot make the ACL entries count to be
unlimited. But we can enlarge the RPC r
From: "John L. Hammond"
md_getxattr() and md_setxattr() each have several unused
parameters. Remove them and improve the naming or remaining
parameters.
Signed-off-by: John L. Hammond
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10792
Reviewed-on: https://review.whamcloud.com/
Reviewed-b
From: Dmitry Eremin
Linux kernel v3.14 adds set_acl method to inode operations.
This patch adds support to Lustre for proper acl management.
Signed-off-by: Dmitry Eremin
Signed-off-by: John L. Hammond
Signed-off-by: James Simmons
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183
Review
From: Lai Siyao
Currently we set LU_OBJECT_HEARD_BANSHEE on object when we want
to remove object from cache, but this may lead to deadlock, because
when other process lookup such object, it needs to wait for this
object until release (done at last refcount put), while that process
maybe already h
> >> On Wed, May 02 2018, James Simmons wrote:
> >>
> >> > From: Lai Siyao
> >> >
> >> > Currently we set LU_OBJECT_HEARD_BANSHEE on object when we want
> >> > to remove object from cache, but this may lead to deadlock, because
> >> > when other process lookup such object, it needs to wait for t
On Tue, May 15 2018, James Simmons wrote:
>> On Wed, May 02 2018, James Simmons wrote:
>>
>> > From: Lai Siyao
>> >
>> > Currently we set LU_OBJECT_HEARD_BANSHEE on object when we want
>> > to remove object from cache, but this may lead to deadlock, because
>> > when other process lookup such ob
On Mon, May 14 2018, Sergio Paracuellos wrote:
> Documentation related with device tree and its checkpatch complains
> have been added. Update TODO file accordingly.
>
> Signed-off-by: Sergio Paracuellos
> ---
> drivers/staging/mt7621-gpio/TODO | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --g
On Mon, May 14 2018, Sergio Paracuellos wrote:
> This commit add missing dt bindings documentation for mt7621-gpio
> driver. After this checkpatch script complain about this
> issue dissapears.
>
> Signed-off-by: Sergio Paracuellos
> ---
> .../devicetree/bindings/gpio/mtk,mt7621-gpio.txt | 51
On Mon, May 14 2018, Sergio Paracuellos wrote:
> The following patch series fix all remaining checkpatch complains
> about this driver. Changes have not been tested and also compiled
> but it should not have any problem about them.
Thanks for these. As you say, nothing in them could change behav
On Mon, May 14 2018, Kamal Heib wrote:
> Remove unused variable 'condition' which was set but not used.
>
> Signed-off-by: Kamal Heib
Reviewed-by: NeilBrown
This is the same patch as
Commit: f03b06f3bae8 ("net: ethernet: mediatek: remove useless code in
mtk_poll_tx()")
which applies to driv
> On Wed, May 02 2018, James Simmons wrote:
>
> > From: Lai Siyao
> >
> > Currently we set LU_OBJECT_HEARD_BANSHEE on object when we want
> > to remove object from cache, but this may lead to deadlock, because
> > when other process lookup such object, it needs to wait for this
> > object until
In C, we don't need such a cast.
Fixes: ae20b254306a ("Drivers: hv: vmbus: enable VMBus protocol version 5.0")
Signed-off-by: Dexuan Cui
Cc: Stephen Hemminger
Cc: K. Y. Srinivasan
---
Thanks Stephen Hemminger for pointing this out!
So far, ae20b254306a ("Drivers: hv: vmbus: enable VMBus prot
Syzbot reported yet another warning with Ion:
WARNING: CPU: 0 PID: 1467 at drivers/staging/android/ion/ion.c:122
ion_buffer_destroy+0xd4/0x190 drivers/staging/android/ion/ion.c:122
Kernel panic - not syncing: panic_on_warn set ...
This is catching that a buffer was freed with an existing kernel m
On Mon, May 14, 2018 at 4:00 PM, Geert Uytterhoeven
wrote:
> Patch sent.
Thanks for the quick turn-around!
>
> BTW, sh also doesn't seem to have 64-bit get_user().
> There may be others.
I checked quickly, nios2 is the only other arch that explicitly
doesn't support it and would result in a bui
Coding style edit to clear the checkpatch.pl check:
CHECK: Unnecessary parentheses around ...
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/r
Coding style edit to clear the checkpatch.pl check:
CHECK: spaces preferred around that 'x'
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211
Coding style edit to clear the checkpatch.pl check:
CHECK: Lines should not end with a '('
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc
Coding style edit to clear the checkpatch.pl warning:
WARNING: please, no spaces at the start of a line
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl8
Coding style edit to clear the checkpatch.pl check:
CHECK: spaces preferred around that '&'
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_
Coding style edit to clear the checkpatch.pl check:
CHECK: Alignment should match open parenthesis
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192u/ie
Coding style edit to clear the checkpatch.pl check:
CHECK: Please don't use multiple blank lines
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 24 --
1 file changed, 24 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl81
Coding style edit to clear the checkpatch.pl Warnings:
WARNING: Block comments should align the * on each line
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 181 +++--
1 file changed, 97 insertions(+), 84 deletions(-)
diff --git a/drivers/
Coding style edit to clear the checkpatch.pl warning:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/stagi
Coding style edit to clear the checkpatch.pl warnings:
WARNING: void function return statements are not generally useful
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rt
Coding style edit to clear the checkpatch.pl check:
CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee802
Coding style edit to clear the checkpatch.pl check:
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_
Coding style edit to clear the checkpatch.pl error:
ERROR: space required after that close brace '}'
And balanced the brace of the same else statement:
CHECK: Unbalanced braces around else statement
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 ++--
1
Coding style edit to clear the checkpatch.pl warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/r
Coding style edit to clear the checkpatch.pl errors of the type:
ERROR: space required before the open parenthesis '('
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 176 ++---
1 file changed, 87 insertions(+), 89 deletions(-)
diff --git a/
Spelling correction in comment: singal -> signal
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl8
Second attempt at this commit, apologies for that.
Coding style changes to resolve some of the scripts/checkpatch.pl issues with
the file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c.
There remain line length and CamelCase issues unresolved in the file.
___
Coding style edit to clear the checkpatch.pl check:
CHECK: Please use a blank line after function/struct/union/enum declarations
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/staging/rtl8192
Coding style edit to clear the checkpatch.pl check:
CHECK: Comparison to NULL could be written "!..."
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee8
Coding style edit to clear the checkpatch.pl warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTP
Coding style edit to clear the checkpatch.pl warnings:
WARNING: Prefer using '"%s...", __func__' to using '', this function's
name, in a string
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletion
Coding style edit to clear the checkpatch.pl errors of the type:
ERROR: that open brace { should be on the previous line
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 197 -
1 file changed, 70 insertions(+), 127 deletions(-)
diff --git
Coding style edit to clear the checkpatch.pl errors of the type:
ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/dri
Coding style edit to clear the checkpatch.pl warning:
WARNING: void function return statements are not generally useful
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl
Coding style edit to clear the checkpatch.pl errors of the type:
ERROR: spaces required around that...
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 122 ++---
1 file changed, 61 insertions(+), 61 deletions(-)
diff --git a/drivers/staging/
Coding style edit to clear the remaining checkpatch.pl errors:
ERROR: trailing whitespace
ERROR: space prohibited after that open parenthesis '('
ERROR: space required before the open brace '{'
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 6 +++---
1 fil
Coding style edit to clear the checkpatch.pl error:
ERROR: switch and case should be at the same indent
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 48 +++---
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging
Coding style edit to clear the checkpatch.pl errors of the type:
ERROR: space prohibited before that ','
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211
Signed-off-by: Samuel Thibault
---
drivers/staging/speakup/buffers.c |2 +-
drivers/staging/speakup/main.c|2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/staging/speakup/buffers.c
+++ b/drivers/staging/speakup/buffers.c
@@ -80,7 +80,7 @@ void synth_buffer_add(u1
On 05/09/2018 11:59 PM, Dmitry Vyukov wrote:
On Wed, Jan 10, 2018 at 7:14 PM, Laura Abbott wrote:
On 01/09/2018 02:58 PM, syzbot wrote:
Hello,
syzkaller hit the following crash on
06d41862286aa7bc634a1dd9e6e7e96f925ef30a
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/maste
Remove unused variable 'condition' which was set but not used.
Signed-off-by: Kamal Heib
---
drivers/staging/mt7621-eth/mtk_eth_soc.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c
b/drivers/staging/mt7621-eth/mtk_eth_soc.c
index
Greg,
> On 14 May 2018, at 10:02 pm, Greg Kroah-Hartman
> wrote:
>
> Can you please fix up the issues reported in this series, rebase on my
> latest tree, and resend so that I can apply them?
>
> thanks,
>
> greg k-h
I’m working on a version 2 patch set and will post when it is ready.
Jame
Dan,
> On 14 May 2018, at 11:47 pm, Dan Carpenter wrote:
>
> On Mon, May 07, 2018 at 11:20:29AM +1000, James Kelly wrote:
>> +static int clk_wzrd_probe(struct platform_device *pdev)
>> +{
>> +int ret;
>> +struct device *dev = &pdev->dev;
>> +
>> +ret = clk_wzrd_get_device_tree_data(d
> From: Stephen Hemminger
> Sent: Monday, May 14, 2018 11:18
> To: Dexuan Cui
> > > ...
> > > Hate to pick o the details, but buffer is void * so cast is not necessary
> > > here.
> >
> > Yes, it's unnecessary in C, though it's necessary in C++.
> >
> > I found the patch went into char-misc 4 ho
GCC warns that vaddr is set but unused. Check the return value of
ion_buffer_kmap_get to make vaddr useful and make sure everything
is properly configured before beginning a DMA.
Suggested-by: Laura Abbott
Signed-off-by: Nathan Chancellor
---
drivers/staging/android/ion/ion.c | 10 --
1
On Mon, 14 May 2018 18:14:15 +
Dexuan Cui wrote:
> > From: devel On Behalf Of
> > Stephen Hemminger
> > Sent: Sunday, May 13, 2018 10:24
> > > ...
> > > @@ -372,6 +400,18 @@ int vmbus_post_msg(void *buffer, size_t buflen,
> > bool can_sleep)
> > > ...
> > > + hdr = (str
> From: devel On Behalf Of
> Stephen Hemminger
> Sent: Sunday, May 13, 2018 10:24
> > ...
> > @@ -372,6 +400,18 @@ int vmbus_post_msg(void *buffer, size_t buflen,
> bool can_sleep)
> > ...
> > + hdr = (struct vmbus_channel_message_header *)buffer;
>
> Hate to pick o the details,
On 05/07/2018 07:51 AM, Nathan Chancellor wrote:
On Mon, May 07, 2018 at 06:46:23AM -0700, Laura Abbott wrote:
On 05/06/2018 06:43 PM, Nathan Chancellor wrote:
Hi everyone,
I compiled the ion driver with W=1 where I encountered the two following
warnings and I had a couple of questions about s
On Mon, May 14, 2018 at 04:53:07PM +0100, John Whitmore wrote:
> Signed-off-by: John Whitmore
> ---
> .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 93
> ++
> 1 file changed, 44 insertions(+), 49 deletions(-)
And I can't take patches without any changelog comments at
On Mon, May 14, 2018 at 04:53:06PM +0100, John Whitmore wrote:
> The file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c has a lot of
> coding style issues, this will be the first of many small patches which clear
> up some, if not all, of the problems with the file.
This isn't a good changel
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index f26b01c56d66..25db00
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index 742eb35ae442..af
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index 925a8f313e9f..13f1
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index 56cc1192cf9f..254
I few other minor coding style issues.
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 42 ++
1 file changed, 19 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index 13f1eee7d8b1..56cc1192cf9f 100644
--- a/driv
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index af6508dfd897..7a765b022f8c 1006
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index 254d536c21d8..f26b01c56d66 1006
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 148 ++---
1 file changed, 74 insertions(+), 74 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index 110fa8b
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 273 +
1 file changed, 112 insertions(+), 161 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index 9e596
The file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c has a lot of
coding style issues, this will be the first of many small patches which clear
up some, if not all, of the problems with the file.
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 319 ++
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 134 +++--
1 file changed, 42 insertions(+), 92 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index 9366b62
There were a lot of coding style issues with this file, but I think I've
reduced the number down to mainly line length and CamelCase issues. I've put
it in 13 patches to, hopefully, make it easier to review, and see that I've
made no changes to functionality of the code, (I hope).
John
__
Signed-off-by: John Whitmore
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 93 ++
1 file changed, 44 insertions(+), 49 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index 17a7209
On Mon, May 14, 2018 at 04:47:26PM +0300, Dan Carpenter wrote:
> On Mon, May 07, 2018 at 11:20:29AM +1000, James Kelly wrote:
> > +static int clk_wzrd_probe(struct platform_device *pdev)
> > +{
> > + int ret;
> > + struct device *dev = &pdev->dev;
> > +
> > + ret = clk_wzrd_get_device_tree_da
On Mon, May 14, 2018 at 07:06:22AM -0700, Nathan Chancellor wrote:
> On Mon, May 14, 2018 at 04:17:36PM +0300, Dan Carpenter wrote:
> > On Sun, May 06, 2018 at 03:03:00PM -0700, Nathan Chancellor wrote:
> > > uwrq is an unsigned 32-bit integer, it cannot be less than zero.
> > >
> > > Signed-off-b
On Mon, May 14, 2018 at 02:52:16PM +0100, Justin Skists wrote:
>
> > On 14 May 2018 at 14:29 Dan Carpenter wrote:
> >
> >
> > On Sun, May 06, 2018 at 06:13:24PM -0700, Nathan Chancellor wrote:
> > > Add the identifiers when missing and fix the ones already present
> > > according to checkpatch.
On Mon, May 14, 2018 at 04:17:36PM +0300, Dan Carpenter wrote:
> On Sun, May 06, 2018 at 03:03:00PM -0700, Nathan Chancellor wrote:
> > uwrq is an unsigned 32-bit integer, it cannot be less than zero.
> >
> > Signed-off-by: Nathan Chancellor
> > ---
> > drivers/staging/ks7010/ks_wlan_net.c | 6 +
After commit 6d6612deaf55 ("staging: ks7010: Remove unnecessary limit
checks"), this define is not used anywhere. Remove it as well.
Suggested-by: Dan Carpenter
Signed-off-by: Nathan Chancellor
---
drivers/staging/ks7010/ks_wlan.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/stagi
Documentation related with device tree and its checkpatch complains
have been added. Update TODO file accordingly.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-gpio/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/mt7621-gpio/TODO b/drivers/staging/mt7621-g
This patch silence some complains of checkpatch script because
of the use of long lines.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-gpio/gpio-mt7621.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/mt7621-gpio/gpio-mt762
There is a complain of checkpatch script about the not documented
DT compatible string for vendor "mtk". Add it to vendor-prefixes.txt
file.
Signed-off-by: Sergio Paracuellos
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentati
This commit add missing dt bindings documentation for mt7621-gpio
driver. After this checkpatch script complain about this
issue dissapears.
Signed-off-by: Sergio Paracuellos
---
.../devicetree/bindings/gpio/mtk,mt7621-gpio.txt | 51 ++
1 file changed, 51 insertions(+)
cre
It's good to have SPDX identifiers in driver files to make it easier to
audit the kernel tree for correct licenses.
Fix up the one of staging gpio-mt7621 file to have a proper SPDX
identifier, based on the license text in the file itself. The SPDX
identifier is a legally binding shorthand, which c
The following patch series fix all remaining checkpatch complains
about this driver. Changes have not been tested and also compiled
but it should not have any problem about them.
Sergio Paracuellos (5):
staging: mt7621-gpio: fix some warnings because of lines exceded 80
characters
staging:
Hi Christoph,
On Mon, May 14, 2018 at 2:03 PM, Christoph Hellwig wrote:
> On Fri, May 11, 2018 at 09:57:52AM +0200, Martijn Coenen wrote:
>> On Sat, May 5, 2018 at 2:10 PM, kbuild test robot wrote:
>> >drivers/android/binder.o: In function `binder_thread_write':
>> >>> binder.c:(.text+0x6a16
> On 14 May 2018 at 14:29 Dan Carpenter wrote:
>
>
> On Sun, May 06, 2018 at 06:13:24PM -0700, Nathan Chancellor wrote:
> > Add the identifiers when missing and fix the ones already present
> > according to checkpatch.pl.
> >
> > Signed-off-by: Nathan Chancellor
> > ---
> > drivers/staging/a
On Mon, May 14, 2018 at 04:29:45PM +0300, Dan Carpenter wrote:
> On Sun, May 06, 2018 at 06:13:24PM -0700, Nathan Chancellor wrote:
> > Add the identifiers when missing and fix the ones already present
> > according to checkpatch.pl.
> >
> > Signed-off-by: Nathan Chancellor
> > ---
> > drivers/s
On Mon, May 07, 2018 at 11:20:29AM +1000, James Kelly wrote:
> +static int clk_wzrd_probe(struct platform_device *pdev)
> +{
> + int ret;
> + struct device *dev = &pdev->dev;
> +
> + ret = clk_wzrd_get_device_tree_data(dev);
> + if (ret)
> + return ret;
> +
> + ret =
On Fri, May 11, 2018 at 08:04:01AM +0200, Michal Simek wrote:
>
> There are some double spaces in the text without any reason.
>
Are you talking about two spaces after a period?? Kernel style guide
has no official position on this. It's up to the author.
regards,
dan carpenter
__
1 - 100 of 114 matches
Mail list logo
