On Fri, Jan 27, 2017 at 10:36:16AM -0800, Stephen Hemminger wrote:
> On Fri, 27 Jan 2017 18:08:35 +
> KY Srinivasan wrote:
>
> > > -Original Message-
> > > From: Stephen Hemminger [mailto:[email protected]]
> > > Sent: Monday, January 23, 2017 5:40 PM
> > > To: KY Srinivasan
A style fix across whole driver.
changed permissions to octal style, found using checkpatch
Signed-off-by: Derek Robson
---
First version had spaces before praenthesis, now fixed in this version.
drivers/staging/speakup/main.c | 4 ++--
drivers/staging/speakup/speakup.h| 4
A style fix across whole driver.
changed permissions to octal style, found using checkpatch
Signed-off-by: Derek Robson
---
drivers/staging/speakup/main.c | 4 ++--
drivers/staging/speakup/speakup.h| 4 ++--
drivers/staging/speakup/speakup_acntpc.c | 26 +-
On Fri, 27 Jan 2017 18:08:35 +
KY Srinivasan wrote:
> > -Original Message-
> > From: Stephen Hemminger [mailto:[email protected]]
> > Sent: Monday, January 23, 2017 5:40 PM
> > To: KY Srinivasan ; Haiyang Zhang
> >
> > Cc: [email protected]; Stephen Hemminger
> >
On Fri, 27 Jan 2017 16:01:37 -0800
Stephen Hemminger wrote:
> On Fri, 27 Jan 2017 18:08:35 +
> KY Srinivasan wrote:
>
> > > -Original Message-
> > > From: Stephen Hemminger [mailto:[email protected]]
> > > Sent: Monday, January 23, 2017 5:40 PM
> > > To: KY Srinivasan ; Hai
On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote:
> Generated with checkpatch.pl --fix-inplace and git add -p out of the
> results.
Maybe another.
> diff --git a/drivers/staging/media/platform/bcm2835/mmal-vchiq.c
> b/drivers/staging/media/platform/bcm2835/mmal-vchiq.c
[]
> @@ -239,7 +239,7
This is derived from the downstream tree's build system, but with just
a single Kconfig option.
For now the driver only builds on 32-bit arm -- the aarch64 build
breaks due to the driver using arm-specific cache flushing functions.
Signed-off-by: Eric Anholt
---
drivers/staging/media/Kconfig
Generated with checkpatch.pl --fix-inplace, some manual fixes for
cases where checkpatch fixed one out of multiple lines of mis-indented
function parameters, and then git add -p out of the results.
I skipped some fixes that should probably instead be replaced with the
BIT() macro.
Signed-off-by:
49bec49fd7f2 ("staging: vc04_services: remove vchiq_copy_from_user")
removed the flags/msg_handle arguments, which were unused, and pushed
the implementation of copying using memcpy vs copy_from_user to the
caller.
Signed-off-by: Eric Anholt
---
drivers/staging/media/platform/bcm2835/mmal-vchiq.
Generated with checkpatch.pl --fix-inplace and git add -p out of the
results.
Signed-off-by: Eric Anholt
---
drivers/staging/media/platform/bcm2835/bcm2835-camera.c | 6 +++---
drivers/staging/media/platform/bcm2835/mmal-vchiq.c | 12 ++--
2 files changed, 9 insertions(+), 9 deletio
Here's my first pass at importing the camera driver. There's a bunch
of TODO left to it, most of which is documented, and the rest being
standard checkpatch fare.
Unfortunately, when I try modprobing it on my pi3, the USB network
device dies, consistently. I'm not sure what's going on here yet,
Signed-off-by: Eric Anholt
---
drivers/staging/media/platform/bcm2835/TODO | 39 +
1 file changed, 39 insertions(+)
create mode 100644 drivers/staging/media/platform/bcm2835/TODO
diff --git a/drivers/staging/media/platform/bcm2835/TODO
b/drivers/staging/media/platfo
> -Original Message-
> From: Long Li [mailto:[email protected]]
> Sent: Monday, January 23, 2017 9:46 PM
> To: KY Srinivasan ; Haiyang Zhang
> ; Bjorn Helgaas
> Cc: [email protected]; [email protected]; linux-
> [email protected]; Long Li
> Subject: [
On Fri, 27 Jan 2017 18:08:35 +
KY Srinivasan wrote:
> > -Original Message-
> > From: Stephen Hemminger [mailto:[email protected]]
> > Sent: Monday, January 23, 2017 5:40 PM
> > To: KY Srinivasan ; Haiyang Zhang
> >
> > Cc: [email protected]; Stephen Hemminger
> >
> -Original Message-
> From: Long Li [mailto:[email protected]]
> Sent: Monday, January 23, 2017 9:45 PM
> To: KY Srinivasan ; Haiyang Zhang
> ; Bjorn Helgaas
> Cc: [email protected]; [email protected]; linux-
> [email protected]; Long Li
> Subject: [
Convert leading spaces to tabs
Signed-off-by: William Blough
---
drivers/staging/rtl8188eu/core/rtw_security.c | 128 +-
1 file changed, 64 insertions(+), 64 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c
b/drivers/staging/rtl8188eu/core/rtw_sec
> -Original Message-
> From: Stephen Hemminger [mailto:[email protected]]
> Sent: Monday, January 23, 2017 5:40 PM
> To: KY Srinivasan ; Haiyang Zhang
>
> Cc: [email protected]; Stephen Hemminger
>
> Subject: [PATCH 07/14] vmbus: remove conditional locking of vmbus_w
Currently user can input any value for amplitude and period.
This patch set a sane max value for auto-configuration mode.
For manual configuration mode, it is assumed this is taken care of
by the COMEDI userspace tool since there's no limit set here from
day one in the staging tree. If otherwise t
On Fri, Jan 27, 2017 at 05:43:47PM +0300, Dan Carpenter wrote:
> Heh. I would just leave this one alone for now.
>
> Everyone hates all the potential changes more than we hate going over
> 80 characters.
>
> regards,
> dan carpenter
>
Understood.
Thanks
Maxime
_
> -Original Message-
> From: Christoph Hellwig [mailto:[email protected]]
> Sent: Thursday, January 19, 2017 7:12 AM
> To: Cathy Avery
> Cc: KY Srinivasan ; Haiyang Zhang
> ; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]
Heh. I would just leave this one alone for now.
Everyone hates all the potential changes more than we hate going over
80 characters.
regards,
dan carpenter
___
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mai
On Fri, Jan 27, 2017 at 05:13:01PM +0300, Dan Carpenter wrote:
> I guess I'm not a fan of really long prefixes... I've complained before
> to other people so don't feel special. Prefixes are something that
> people add without thinking as if they always make the code better and
> I do blame JAVA
I guess I'm not a fan of really long prefixes... I've complained before
to other people so don't feel special. Prefixes are something that
people add without thinking as if they always make the code better and
I do blame JAVA influence for this...
The "_interface" really doesn't add anything bec
On Fri, Jan 27, 2017 at 04:24:47PM +0300, Dan Carpenter wrote:
> On Fri, Jan 27, 2017 at 02:08:06PM +0100, Johan Hovold wrote:
> > On Fri, Jan 27, 2017 at 03:47:21PM +0300, Dan Carpenter wrote:
> > > The name sucks is what I'm saying. Please fix it eventually.
> >
> > I disagree. The name uses a
On Fri, Jan 27, 2017 at 02:08:06PM +0100, Johan Hovold wrote:
> On Fri, Jan 27, 2017 at 03:47:21PM +0300, Dan Carpenter wrote:
> > The name sucks is what I'm saying. Please fix it eventually.
>
> I disagree. The name uses a common prefix that reflects the object it is
> working on. This should no
On Fri, Jan 27, 2017 at 03:47:21PM +0300, Dan Carpenter wrote:
> The name sucks is what I'm saying. Please fix it eventually.
I disagree. The name uses a common prefix that reflects the object it is
working on. This should not be changed. As it is currently named, the
function is also self-docume
The name sucks is what I'm saying. Please fix it eventually.
regards,
dan carpenter
___
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, Jan 27, 2017 at 03:29:30PM +0300, Dan Carpenter wrote:
> On Fri, Jan 27, 2017 at 11:11:21AM +0100, [email protected] wrote:
> > From: Maxime Rossi Bellom
> >
> > Split line before funtion argument.
> >
> > Error was reported by checkpatch.pl as
> > WARNING: line over 80 characters
>
On Fri, Jan 27, 2017 at 11:11:21AM +0100, [email protected] wrote:
> From: Maxime Rossi Bellom
>
> Split line before funtion argument.
>
> Error was reported by checkpatch.pl as
> WARNING: line over 80 characters
>
> Signed-off-by: Maxime Rossi Bellom
> ---
> drivers/staging/greybus/fw-m
From: Maxime Rossi Bellom
Replace a mix of tabs and spaces indentation by tabs only.
Errors were reported by checkpatch.pl as
WARNING: Statements should start on a tabstop
WARNING: suspect code indent for conditional statement
Signed-off-by: Maxime Rossi Bellom
---
drivers/staging/lustre/lnet
- Original Message -
Sent: Fri, 27 Jan 2017 04:59:49 -0500 (EST)
Subject: Hi
Attention is needed
___
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, Jan 27, 2017 at 11:11:21AM +0100, [email protected] wrote:
> From: Maxime Rossi Bellom
>
> Split line before funtion argument.
>
> Error was reported by checkpatch.pl as
> WARNING: line over 80 characters
>
> Signed-off-by: Maxime Rossi Bellom
> ---
> drivers/staging/greybus/fw-m
From: Maxime Rossi Bellom
Split line before funtion argument.
Error was reported by checkpatch.pl as
WARNING: line over 80 characters
Signed-off-by: Maxime Rossi Bellom
---
drivers/staging/greybus/fw-management.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/st
On Tue, Jan 24, 2017 at 03:57:54PM +, Bryan O'Donoghue wrote:
> On 24/01/17 15:09, Johan Hovold wrote:
>
> > Bryan, if you could consider my review feedback and respin your last
> > three patches on top of my timeout patch, I think we should be good.
>
> Sure thing
Bryan, can I get an Acked-
34 matches
Mail list logo
