Re: [PATCH] drm/amd/amdgpu : Fix NULL pointer comparison

Am 08.11.2016 um 06:49 schrieb Ravikant Bijendra Sharma: From: Ravikant B Sharma Replace direct comparisons to NULL i.e. 'x == NULL' with '!x'. As per coding standard. Signed-off-by: Ravikant B Sharma Please stop CCing random people who contributed to the driver in the past on something as

Re: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

On Tue, Nov 08, 2016 at 12:14:14AM -0800, Long Li wrote: > From: Long Li > > hv_do_hypercall assumes that we pass a segment from a physically continuous > buffer. Buffer allocated on the stack may not work if CONFIG_VMAP_STACK=y is > set. Use kmalloc to allocate this buffer. Please wrap your c

[Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

From: Long Li hv_do_hypercall assumes that we pass a segment from a physically continuous buffer. Buffer allocated on the stack may not work if CONFIG_VMAP_STACK=y is set. Use kmalloc to allocate this buffer. Signed-off-by: Long Li Reported-by: Haiyang Zhang --- drivers/pci/host/pci-hyperv.

[PATCH] drm/armada: Fix NULL pointer comparison warning

From: Ravikant B Sharma Replace direct comparisons to NULL i.e. 'x == NULL' with '!x'. As per coding standard. Signed-off-by: Ravikant B Sharma --- drivers/gpu/drm/armada/armada_debugfs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/armada/armada_debug

[PATCH] drm/amd/amdgpu : Fix NULL pointer comparison

From: Ravikant B Sharma Replace direct comparisons to NULL i.e. 'x == NULL' with '!x'. As per coding standard. Signed-off-by: Ravikant B Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c |2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c |3 +-- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c

Re: [PATCH 01/11] staging: wlan-ng: fix line style issue in macro WLAN_GET_FC_FSTYPE

Thanks for pointing that Joe. There other files and macros where GENMASK stuff could be applied in wlan-ng driver. Maybe it should be better to apply this patch as it is now and send another patch later which changes all of them. What do you think? Cheers, Sergio Paracuellos El 2016年1

[PATCH] staging: lustre: ldlm: pl_recalc time handling is wrong

The ldlm_pool field pl_recalc_time is set to the current monotonic clock value but the interval period is calculated with the wall clock. This means the interval period will always be far larger than the pl_recalc_period, which is just a small interval time period. The correct thing to do is to use

[PATCH] staging: vc04_services: Add 32-bit compatibility ioctls

VCHIQ/vc04_services has a userland device interface that includes ioctls. The ioctls are very pointer dependent, so in the case of 32-bit running on top of a 64-bit kernel, it is necessary to deal with the structure differences. The solution to this is that the standard ioctl numbering mechanism

RE: [PATCH 1/6] Staging: fsl-mc: bus: dpmcp: Kernel type 'u32' preferred over 'uint32_t'

> -Original Message- > From: Shiva Kerdel [mailto:[email protected]] > Sent: Monday, November 07, 2016 6:01 AM > To: [email protected] > Cc: Stuart Yoder ; [email protected]; German > Rivera > ; [email protected]; [email protected]; Bharat > Bhushan ; > Nipun Gupta ; lin

RE: [PATCH 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

> -Original Message- > From: Ruxandra Ioana Radulescu > Sent: Friday, November 04, 2016 10:04 AM > To: Stuart Yoder ; [email protected] > Cc: German Rivera ; [email protected]; > [email protected]; > [email protected]; [email protected]; Leo Li ; Roy Pledge > > Sub

[PATCH] staging: lustre: obd: rename health sysfs file to health_check

Testing revealed that the sysfs file health is actually the wrong name. Rename to the proper name health_check. Signed-off-by: James Simmons --- .../lustre/lustre/obdclass/linux/linux-module.c|8 drivers/staging/lustre/sysfs-fs-lustre |2 +- 2 files changed, 5 in

Re: [PATCH 2/2] staging: lustre: obdclass: Add handling of error returned by lustre_cfg_new

On Nov 7, 2016, at 4:33 PM, Dilger, Andreas wrote: > On Nov 6, 2016, at 10:26, Drokin, Oleg wrote: >> >> Hello! >> >> On Nov 6, 2016, at 12:11 PM, Christophe JAILLET wrote: >> >>> 'lustre_cfg_new()' can return ERR_PTR(-ENOMEM). >>> Handle these errors and propagate the error code to the calle

[PATCH v3] staging: lustre: mdc: manage number of modify RPCs in flight

From: Gregoire Pichon This patch is the main client part of a new feature that supports multiple modify metadata RPCs in parallel. Its goal is to improve metadata operations performance of a single client, while maintening the consistency of MDT reply reconstruction and MDT recovery mechanisms.

Re: [lustre-devel] [PATCH 1/2] staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES

On Nov 7, 2016, at 02:07, Aya Mahfouz wrote: > > On Mon, Nov 7, 2016 at 6:22 AM, Oleg Drokin wrote: > >> On Nov 4, 2016, at 4:37 AM, Aya Mahfouz wrote: >> >> > >> > On Thu, Nov 3, 2016 at 1:05 AM, Dilger, Andreas >> > wrote: >> > On Oct 25, 2016, at 10:47, Aya Mahfouz >> > wrote: >> > > >>

[PATCH] Staging: used dma_map_single in place of pci_map_single

pci_map_single is unneeded and can be replaced with dma_map_single to avoid inconcitent api usage. The Coccinelle semantic patch used to make this change is as follows: @@ expression E1,E2,E3; @@ - pci_map_single(E1, + dma_map_single(&E1->dev, E2, E3, ( - PCI_DMA_BIDIRECTIONAL + DMA_BIDIRCTION

Re: [PATCH 2/2] staging: lustre: obdclass: Add handling of error returned by lustre_cfg_new

On Nov 6, 2016, at 10:26, Drokin, Oleg wrote: > > Hello! > > On Nov 6, 2016, at 12:11 PM, Christophe JAILLET wrote: > >> 'lustre_cfg_new()' can return ERR_PTR(-ENOMEM). >> Handle these errors and propagate the error code to the callers. >> >> Error handling has been rearranged in 'lustre_proce

Re: [PATCH] staging: lustre: o2iblnd: use bool assignment to true/false

On Nov 7, 2016, at 12:01, Nicholas Hanley wrote: > > Replace 0 with false in tx_pages_mapped = 0 to be consistent with > the rest of the lustre code. > > Signed-off-by: Nicholas Hanley Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 2 +- > 1 file cha

RE: [PATCH] vmbus: fix lockup if ring fills up

> -Original Message- > From: Stephen Hemminger [mailto:[email protected]] > Sent: Monday, November 7, 2016 8:50 AM > To: Haiyang Zhang ; KY Srinivasan > > Cc: [email protected]; [email protected] > Subject: [PATCH] vmbus: fix lockup if ring fills up > > Fr

[PATCH] staging: lustre: o2iblnd: use bool assignment to true/false

Replace 0 with false in tx_pages_mapped = 0 to be consistent with the rest of the lustre code. Signed-off-by: Nicholas Hanley --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2ib

Re: [PATCH 01/11] staging: wlan-ng: fix line style issue in macro WLAN_GET_FC_FSTYPE

On Mon, 2016-11-07 at 18:55 +0100, Sergio Paracuellos wrote: > This patch fix the following checkpatch.pl script warning: > WARNING: line over 80 characters > > It also add spaces between or operators inside the macro to > comply with the standard kernel coding style. [] > diff --git a/drivers/sta

[PATCH 01/11] staging: wlan-ng: fix line style issue in macro WLAN_GET_FC_FSTYPE

This patch fix the following checkpatch.pl script warning: WARNING: line over 80 characters It also add spaces between or operators inside the macro to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211hdr.h | 3 ++- 1 file changed

[PATCH 03/11] staging: wlan-ng: remove unnecessary parenthesis in hfa384x_usb.c

This patch removes unnecessary parentheses in different statements of hfa384x_usb.c file in order to to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x_usb.c | 24 1 file changed, 12 insertions(+), 12 de

[PATCH 08/11] staging: wlan-ng: remove unnecessary blank lines in p80211wep.c

This patch removes unnecessary blank line in p80211wep.c file to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211wep.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211wep.c b/drivers/staging/w

[PATCH 04/11] staging: wlan-ng: replace BUG_ON() into WARN_ON() on hfa384x_usbin_callback

This patch avoids using BUG_ON() from driver, and return from hfa384x_usbin_callback with WARN_ON() if skb was NULL or data in skb is different from expected one. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x_usb.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[PATCH 10/11] staging: wlan-ng: remove unnecessary blank lines in prism2fw.c

This patch removes unnecessary blank lines in prism2fw.c file to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2fw.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/w

[PATCH 02/11] staging: wlan-ng: remove unnecessary out of memory message in p80211conv.c

This patch fix the following checkpatch script warning: WARNING: Possible unnecessary 'out of memory' message. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211conv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/w

[PATCH 05/11] staging: wlan-ng: match open parenthesis alignment in hfa384x_usb.c

This patch fix open parenthesis alignment in hfa384x_usb.c file to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/hfa384x_usb.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wlan

[PATCH 09/11] staging: wlan-ng: fix parenthesis alignment in prism2fw.c

This patch fix open parenthesis alignment matching in prism2fw.c file to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2fw.c | 51 -- 1 file changed, 27 insertions(+), 24 deletions(-) diff --g

[PATCH 06/11] staging: wlan-ng: match open parenthesis alignment in p80211req.c

This patch fix open parenthesis alignment in p80211req.c file to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211req.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211re

[PATCH 07/11] staging: wlan-ng: change comparison to NULL to preferred style.

Comparison to NULL could be written in preferred form. Change it to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/p80211wep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211wep.c b/d

[PATCH 11/11] staging: wlan-ng: remove unnecessary parenthesis in prism2fw.c

This patch removes unnecessary parentheses in different statements of prism2fw.c file in order to to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos --- drivers/staging/wlan-ng/prism2fw.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/

[PATCH 00/11] staging: wlan-ng: fix some style issues

This patchset fix several style issues to comply with the standard kernel coding style. Sergio Paracuellos (11): staging: wlan-ng: fix line style issue in macro WLAN_GET_FC_FSTYPE staging: wlan-ng: remove unnecessary out of memory message in p80211conv.c staging: wlan-ng: remove unneces

[PATCH] vmbus: fix lockup if ring fills up

From: Stephen Hemminger --- Please queue for stable as well include/linux/hyperv.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index cd184bd..28f88de 100644 --- a/include/linux/hyperv.h +++ b/include/linux/hyperv.h @@ -15

Re: [PATCH v2] staging: vc04_services: setup DMA and coherent mask

Michael Zoran writes: > VCHI messages between the CPU and firmware use 32-bit > bus addresses. Explicitly set the DMA mask and coherent > on all platforms. Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ devel mailing list de..

Re: [PATCH v2] staging: vc04_services: add vchiq_pagelist_info structure

Michael Zoran writes: > The current dma_map_sg based implementation for bulk messages > computes many offsets into a single allocation multiple times in > both the create and free code paths. This is inefficient, > error prone and in fact still has a few lingering issues > with arm64. > > This c

Re: [PATCH] staging: vc04_services: add vchiq_pagelist_info structure

On Mon, 2016-11-07 at 11:03 +0100, Greg KH wrote: > On Mon, Oct 31, 2016 at 01:10:35AM -0700, Michael Zoran wrote: > > The current dma_map_sg based implementation for bulk messages > > computes many offsets into a single allocation multiple times in > > both the create and free code paths.  This is

[PATCH v2] staging: vc04_services: add vchiq_pagelist_info structure

The current dma_map_sg based implementation for bulk messages computes many offsets into a single allocation multiple times in both the create and free code paths. This is inefficient, error prone and in fact still has a few lingering issues with arm64. This change replaces a small portion of tha

[PATCH 6/6] Staging: fsl-mc: include: mc-bus: Kernel type 's16' preferred over 'int16_t'

Follow the kernel type preferrences of using 's16' over 'int16_t'. Signed-off-by: Shiva Kerdel --- drivers/staging/fsl-mc/include/mc-bus.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fsl-mc/include/mc-bus.h b/drivers/staging/fsl-mc/include/mc-bus.h in

[PATCH 3/6] Staging: fsl-mc: bus: dpmcp: Kernel type 'u8' preferred over 'uint8_t'

Follow the kernel type preferrences of using 'u8' over 'uint8_t'. Signed-off-by: Shiva Kerdel --- drivers/staging/fsl-mc/bus/dpmcp.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/dpmcp.h b/drivers/staging/fsl-mc/bus/dpmcp.h ind

[PATCH 2/6] Staging: fsl-mc: bus: dpmcp: Kernel type 'u16' preferred over 'uint16_t'

Follow the kernel type preferrences of using 'u16' over 'uint16_t'. Signed-off-by: Shiva Kerdel --- drivers/staging/fsl-mc/bus/dpmcp.h | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/dpmcp.h b/drivers/staging/fsl-mc

[PATCH 1/6] Staging: fsl-mc: bus: dpmcp: Kernel type 'u32' preferred over 'uint32_t'

Follow the kernel type preferrences of using 'u32' over 'uint32_t'. Signed-off-by: Shiva Kerdel --- drivers/staging/fsl-mc/bus/dpmcp.h | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/dpmcp.h b/drivers/staging/fs

[PATCH 5/6] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

Follow the kernel type preferrences of using 's32' over 'int32_t'. Signed-off-by: Shiva Kerdel --- drivers/staging/fsl-mc/include/mc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/include/mc.h b/drivers/staging/fsl-mc/include/mc.h index f6e720e..5c3

[PATCH 4/6] Staging: fsl-mc: bus: dpmcp: Kernel type 'u64' preferred over 'uint64_t'

Follow the kernel type preferrences of using 'u64' over 'uint64_t'. Signed-off-by: Shiva Kerdel --- drivers/staging/fsl-mc/bus/dpmcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/dpmcp.h b/drivers/staging/fsl-mc/bus/dpmcp.h index 854621a..c4e5d

Re: [PATCH] Staging: lustre: llite: refactor lov_object_fiemap()

On Mon, Nov 07, 2016 at 10:56:19AM +, Xu, Bobijam wrote: > * Change loff_t to u64 in lov_object_fiemap() since loff_t is a > signed value type. > * Add fiemap_for_stripe() to get file map extent from each stripe > device. > > Reported-by: Dan Carpenter > Signed-off-by: Bobi Jam Why are

Re: [PATCH 1/2] mm: add locked parameter to get_user_pages()

On Mon, Nov 07, 2016 at 11:49:18AM +0100, Jesper Nilsson wrote: > For the cris-part: > Acked-by: Jesper Nilsson Thanks very much for that, however just to avoid any confusion, I realised this series was not not the right way forward after discussion with Paolo and rather it makes more sense to ke

[PATCH] Staging: lustre: llite: refactor lov_object_fiemap()

* Change loff_t to u64 in lov_object_fiemap() since loff_t is a signed value type. * Add fiemap_for_stripe() to get file map extent from each stripe device. Reported-by: Dan Carpenter Signed-off-by: Bobi Jam --- drivers/staging/lustre/lustre/lov/lov_object.c | 458 +

Re: [PATCH 1/2] mm: add locked parameter to get_user_pages()

On Mon, Oct 31, 2016 at 10:02:27AM +, Lorenzo Stoakes wrote: > This patch adds an int *locked parameter to get_user_pages() to allow > VM_FAULT_RETRY faulting behaviour similar to get_user_pages_[un]locked(). > > It additionally clears the way for get_user_pages_locked() to be removed as > it

Re: [PATCH 2/2] staging: lustre: obdclass: Add handling of error returned by lustre_cfg_new

On Mon, Nov 07, 2016 at 04:10:16AM +, James Simmons wrote: > > > On Nov 6, 2016, at 12:11 PM, Christophe JAILLET wrote: > > > > > 'lustre_cfg_new()' can return ERR_PTR(-ENOMEM). > > > Handle these errors and propagate the error code to the callers. > > > > > > Error handling has been rearran

Re: [PATCH v2] staging: lustre: mdc: manage number of modify RPCs in flight

On Wed, Nov 02, 2016 at 02:46:52PM -0400, James Simmons wrote: > From: Gregoire Pichon > > This patch is the main client part of a new feature that supports > multiple modify metadata RPCs in parallel. Its goal is to improve > metadata operations performance of a single client, while maintening >

Re: [PATCH] Staging: fsl-mc: Changed allocation types into the types that the kernel prefers

On Mon, Nov 07, 2016 at 12:12:01AM +0100, Shiva Kerdel wrote: > Fixed reports from checkpatch that pointed out that the code was not > using the preferred types of the kernel. > > Signed-off-by: Shiva Kerdel > --- > drivers/staging/fsl-mc/bus/dpmcp.h | 80 >

Re: [PATCH] staging: vc04_services: add vchiq_pagelist_info structure

On Mon, Oct 31, 2016 at 01:10:35AM -0700, Michael Zoran wrote: > The current dma_map_sg based implementation for bulk messages > computes many offsets into a single allocation multiple times in > both the create and free code paths. This is inefficient, > error prone and in fact still has a few li

Re: [PATCH] Staging: vme: vme_pio2: Prefer using the BIT macro

On Sat, Nov 05, 2016 at 08:31:11PM +0100, Shiva Kerdel wrote: > Replace all occurences of (1 << x) by BIT(x) in the file vme_pio2.h to > get rid of checkpatch.pl "check" output "Prefer using the BIT macro". > > Signed-off-by: Shiva Kerdel > --- > drivers/staging/vme/devices/vme_pio2.h | 86 > ++

Re: [PATCH 02/15] staging: unisys: visorbus: convert client_bus_info sysfs to debugfs

On Thu, Nov 03, 2016 at 11:44:16AM -0400, David Kershner wrote: > From: Tim Sell > > Previously, the sysfs entry (assuming traditional sysfs mountpoint): > > /sys/bus/visorbus/devices/visorbus/client_bus_info > > violated kernel conventions by printing more than one item. This along > with

Re: [PATCH] Staging: rtl8188eu: fix brace coding style issue in rtw_recv.c

On Thu, Nov 03, 2016 at 10:08:55AM +0100, bits4me wrote: > Patch to the rtw_recv. file to fix up 2 brace warnings > (unnecessary braces) found by the checkpath.pl tool > > Signed-off-by: Florian Winter > --- > drivers/staging/rtl8188eu/core/rtw_recv.c | 9 - > 1 file changed, 4 insertion

Re: Greybus Future

On Sat, Nov 5, 2016 at 1:18 PM, Greg KH wrote: > On Tue, Nov 01, 2016 at 12:13:06PM -0700, Joël Porquet wrote: >> I don't have much hope but would there be a way to find out whether >> all the code that was developed between the moment we stopped using >> github and the project was canceled could