On Sat, Oct 31, 2015 at 12:32:29AM +0300, Alexey Khoroshilov wrote:
> Hello,
>
> hfi1_ioctl() contains many calls to might sleep functions with
> dd->hfi1_snoop.snoop_lock spinlock held (for example, access_ok,
> copy_from_user, kzalloc(GFP_KERNEL), etc.).
>
> Should dd->hfi1_snoop.snoop_lock be
On Thu, Oct 29, 2015 at 07:28:21PM -0400, James Simmons wrote:
> With nidstring now having the latest fixes we can
> now clean up all the remaining checkpatch errors
> for nidstring.c.
Please be specific as to exactly what you changed, and break it up into
one-patch-per-thing. And no, "fix all ch
From: Mike Marciniszyn
The workqueue is currently single threaded per port which for a small number of
SDMA engines is ok.
For hfi1, the there are up to 16 SDMA engines that can be fed descriptors in
parallel.
Use alloc_workqueue with a workqueue limit of the number of sdma engines and
with WQ_
From: Mitko Haralanov
Expected receives work by user-space libraries (PSM) calling into the driver
with information about the user's receive buffer and have the driver DMA-map
that buffer and program the HFI to receive data directly into it.
This is an expensive operation as it requires the driv
From: Mike Marciniszyn
Now that we have a multi-threaded work queue we precomputed and store the SC
and SDE on RC and UC QPs for faster access.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Mike Marciniszyn
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/qp.c| 27
From: Ira Weiny
Remove the following macros in favor of explicit use of struct hfi1_filedata and
various sub structures.
ctxt_fp
subctxt_fp
tidcursor_fp
user_sdma_pkt_fp
user_sdma_comp_fp
Reviewed-by: Mitko Haralanov
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/file_ops.c | 124 ++
From: Mitko Haralanov
These includes were not used in file_ops.c
Signed-off-by: Mitko Haralanov
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/file_ops.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/file_ops.c
b/drivers/staging/rdma/hfi1/fi
From: Mike Marciniszyn
Move hfi1_migrate_qp from ruc.c to qp.[hc] in prep for modifying the QP
workqueue.
Signed-off-by: Mike Marciniszyn
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/qp.c| 20
drivers/staging/rdma/hfi1/qp.h| 2 ++
drivers/staging/rdma/h
From: Mitko Haralanov
Add mmu notify helper functions and TID caching function stubs in preparation
for the TID caching implementation.
TID caching makes use of the MMU notifier to allow the driver to respond to the
user freeing memory which is allocated to the HFI.
This patch implements the ba
From: Mitko Haralanov
In preparation of implementing TID caching move EXP_TID macros to a common
header user_exp_rcv.h
Signed-off-by: Mitko Haralanov
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/file_ops.c | 13 +-
drivers/staging/rdma/hfi1/user_exp_rcv.h | 74 ++
From: Mitko Haralanov
In preparation for implementing Expected TID caching we do some simple clean up
of header file macros.
Signed-off-by: Mitko Haralanov
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/common.h | 15 ---
include/uapi/rdma/hfi/hfi1_user.h | 26 +++
From: Ira Weiny
The following are fixes to the hfi1 driver for stability, security, and
performance.
New series based off of the latest staging-next. Large patches were split up
and a new patch was added to remove offending macros.
NOTE: My apologies for not putting v4 in all the patches. I w
Meta-comment, you put "v4" in the subject, in a place where I can't sort
this series and expect them to be applied in the correct order. You
need a 'v4' in all of the patches (git format-patch will do it
automatically for you.)
As this is, it's a pain to apply, please fix up and resend.
thanks,
From: Mitko Haralanov
These includes were not used in file_ops.c
Signed-off-by: Mitko Haralanov
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/file_ops.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/file_ops.c
b/drivers/staging/rdma/hfi1/fi
From: Mitko Haralanov
Expected receives work by user-space libraries (PSM) calling into the driver
with information about the user's receive buffer and have the driver DMA-map
that buffer and program the HFI to receive data directly into it.
This is an expensive operation as it requires the driv
From: Mike Marciniszyn
Move hfi1_migrate_qp from ruc.c to qp.[hc] in prep for modifying the QP
workqueue.
Signed-off-by: Mike Marciniszyn
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/qp.c| 20
drivers/staging/rdma/hfi1/qp.h| 2 ++
drivers/staging/rdma/h
From: Mitko Haralanov
Add mmu notify helper functions and TID caching function stubs in preparation
for the TID caching implementation.
TID caching makes use of the MMU notifier to allow the driver to respond to the
user freeing memory which is allocated to the HFI.
This patch implements the ba
From: Mike Marciniszyn
Now that we have a multi-threaded work queue we precomputed and store the SC
and SDE on RC and UC QPs for faster access.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Mike Marciniszyn
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/qp.c| 27
From: Mitko Haralanov
In preparation of implementing TID caching move EXP_TID macros to a common
header user_exp_rcv.h
Signed-off-by: Mitko Haralanov
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/file_ops.c | 13 +-
drivers/staging/rdma/hfi1/user_exp_rcv.h | 74 ++
From: Mitko Haralanov
In preparation for implementing Expected TID caching we do some simple clean up
of header file macros.
Signed-off-by: Mitko Haralanov
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/common.h | 15 ---
include/uapi/rdma/hfi/hfi1_user.h | 26 +++
From: Mike Marciniszyn
The workqueue is currently single threaded per port which for a small number of
SDMA engines is ok.
For hfi1, the there are up to 16 SDMA engines that can be fed descriptors in
parallel.
Use alloc_workqueue with a workqueue limit of the number of sdma engines and
with WQ_
From: Ira Weiny
The following are fixes to the hfi1 driver for stability, security, and
performance.
New series based off of the latest staging-next. Large patches were split up
and a new patch was added to remove offending macros.
Ira Weiny (1):
staging/rdma/hfi1: Remove file pointer macros
From: Ira Weiny
Remove the following macros in favor of explicit use of struct hfi1_filedata and
various sub structures.
ctxt_fp
subctxt_fp
tidcursor_fp
user_sdma_pkt_fp
user_sdma_comp_fp
Reviewed-by: Mitko Haralanov
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/file_ops.c | 124 ++
Am 30.10.2015 um 23:03 schrieb Haiyang Zhang:
>
>
>> -Original Message-
>> From: Vitaly Kuznetsov [mailto:[email protected]]
>> Sent: Friday, October 30, 2015 6:56 AM
>> To: Haiyang Zhang
>> Cc: Richard Weinberger ; David Miller
>> ; [email protected]; [email protected]; driverdev-
>> d
> -Original Message-
> From: Vitaly Kuznetsov [mailto:[email protected]]
> Sent: Friday, October 30, 2015 6:56 AM
> To: Haiyang Zhang
> Cc: Richard Weinberger ; David Miller
> ; [email protected]; [email protected]; driverdev-
> [email protected]; LKML ;
> [email protected].
On Fri, Oct 30, 2015 at 11:11 PM, wrote:
> From: Jake Oshins
>
> This patch adds a second way of finding an IRQ domain associated with
> a root PCI bus. After looking to see if one can be found through
> the OF tree, it attempts to look up the IRQ domain through an
> fwnode_handle stored in the
Hello,
hfi1_ioctl() contains many calls to might sleep functions with
dd->hfi1_snoop.snoop_lock spinlock held (for example, access_ok,
copy_from_user, kzalloc(GFP_KERNEL), etc.).
Should dd->hfi1_snoop.snoop_lock be acquired just before updating state?
Found by Linux Driver Verification project (
From: Jake Oshins
This patch exposes the mapping between Linux CPU number and Hyper-V virtual
processor number. This is necessary because the hypervisor needs to know which
virtual processor to target when making a mapping in the Interrupt Redirection
Table in the I/O MMU.
Signed-off-by: Jake Os
From: Jake Oshins
This patch exposes the function that hv_vmbus.ko uses to make hypercalls. This
is necessary for retargeting an interrupt when it is given a new affinity and
vector.
Signed-off-by: Jake Oshins
---
drivers/hv/hv.c | 20 ++--
drivers/hv/hyperv_vmbus.h |
From: Jake Oshins
This patch adds a second way of finding an IRQ domain associated with
a root PCI bus. After looking to see if one can be found through
the OF tree, it attempts to look up the IRQ domain through an
fwnode_handle stored in the pci_sysdata struct.
Signed-off-by: Jake Oshins
---
From: Jake Oshins
This patch introduces a new driver which exposes a root PCI bus whenever a PCI
Express device is passed through to a guest VM under Hyper-V. The device can
be single- or multi-function. The interrupts for the devices are managed by an
IRQ domain, implemented within the driver.
From: Jake Oshins
This defines the channel type for PCI front-ends in Hyper-V VMs.
Signed-off-by: Jake Oshins
---
include/linux/hyperv.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index ea0a0e3..5587899 100644
--- a/include/
From: Jake Oshins
This patch adds an fwnode_handle to struct pci_sysdata, which is
used by the next patch in the series when trying to locate an
IRQ domain associated with a root PCI bus.
Signed-off-by: Jake Oshins
---
arch/x86/include/asm/pci.h | 11 +++
1 file changed, 11 insertions(
From: Jake Oshins
This patch series incorporates feedback related to the version sent yesterday.
First, export functions that allow correlating Hyper-V virtual processors
and Linux cpus, along with the means for invoking a hypercall that targets
interrupts at chosen vectors on specfic cpus.
Sec
From: Jake Oshins
The Linux kernel already has the concpet of IRQ domain, whereing a component
can expose a set of IRQs which are managed by a particular interrupt controller
chip or other subsystem. The PCI driver exposes the notion of an IRQ domain
for Message-Signaled Interrupts (MSI) from PCI
Destroy mc_io in error path in dprc_probe() only if the mc_io was
created in this function.
Signed-off-by: J. German Rivera
---
Changes in v2:
- Addressed comment from Dan Carpenter
* Renamed goto error labels to indicate what the goto does
drivers/staging/fsl-mc/bus/dprc-driver.c | 17 ++
Scan the corresponding DPRC container to get total count
of IRQs needed by all its child DPAA2 objects. Then,
preallocate a set of MSI IRQs with the DPRC's ICID
(GIT-ITS device Id) to populate the the DPRC's IRQ pool.
Each child DPAA2 object in the DPRC and the DPRC object itself
will allocate thei
Since an FSL-MC bus is a new bus type that is neither PCI nor
PLATFORM, we need a new domain bus token to disambiguate the
IRQ domain for FSL-MC MSIs.
Signed-off-by: J. German Rivera
---
Changes in v2: none
include/linux/irqdomain.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/li
THE MSI domain associated with a root DPRC object is
obtained form the device tree. Child DPRCs inherit
the parent DPRC MSI domain.
Signed-off-by: J. German Rivera
---
Changes in v2: none
drivers/staging/fsl-mc/bus/dprc-driver.c | 39
1 file changed, 39 insertio
All the IRQs for DPAA2 objects in the same DPRC must use
the ICID of that DPRC, as their device Id in the GIC-ITS.
Thus, all these IRQs must share the same ITT table in the GIC.
As a result, a pool of IRQs with the same device Id must be
preallocated per DPRC (fsl-mc bus instance). So, the fsl-mc
b
Created an MSI domain for the fsl-mc bus-- including functions
to create a domain, find a domain, alloc/free domain irqs, and
bus specific overrides for domain and irq_chip ops.
Signed-off-by: J. German Rivera
---
Changes in v2: none
drivers/staging/fsl-mc/bus/Kconfig | 1 +
drivers/
FSL-MC is a bus type different from PCI and platform, so it needs
its own member in the msi_desc's union.
Signed-off-by: J. German Rivera
---
Changes in v2:
- Addressed comment from Jiang Liu
* Added a dedicated structure for FSL-MC in struct msi_desc
include/linux/msi.h | 9 +
1 file
The interrupt handler for DPRC IRQs is added. DPRC IRQs are
generated for hot plug events related to DPAA2 objects in a given
DPRC. These events include, creating/destroying DPAA2 objects in
the DPRC, changing the "plugged" state of DPAA2 objects and moving
objects between DPRCs.
Signed-off-by: J.
This patch series addresses the following item from the TODO list
for the MC bus driver to exit staging:
* Interrupt support. For meaningful driver support we need
interrupts, and thus need message interrupt support by the bus
driver.
MC Bus MSI Support Architecture
==
The DPRC built-in portal's mc_io is used to send commands to the MC
to program MSIs for MC objects. This is done by the
fsl_mc_msi_write_msg() callback, which is invoked by the generic MSI
layer with interrupts disabled. As a result, the mc_io used in
fsl_mc_msi_write_msg needs to be an atomic mc_i
Initialize/Cleanup ITS-MSI support for the MC bus driver at driver
init/exit time. Associate an MSI domain with each DPAA2 child device.
Signed-off-by: J. German Rivera
---
Changes in v2: none
drivers/staging/fsl-mc/bus/mc-bus.c | 12
1 file changed, 12 insertions(+)
diff --git a/
Added platform-specific MSI support layer for FSL-MC devices.
Signed-off-by: J. German Rivera
---
Changes in v2: none
drivers/staging/fsl-mc/bus/Makefile| 1 +
.../staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 127 +
drivers/staging/fsl-mc/include/mc-pri
Demonstrate why sysfs rescan attribute is helpful for
moving fsl-mc bus out of staging.
Signed-off-by: Lijun Pan
---
drivers/staging/fsl-mc/TODO | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/fsl-mc/TODO b/drivers/staging/fsl-mc/TODO
index 3894368..5065821 100644
--- a
The kernel support for the restool (a user space resource management
tool) is a driver for the /dev/dprc.N device file.
Its purpose is to provide an ioctl interface,
which the restool uses to interact with the MC bus driver
and with the MC firmware.
We allocate a dpmcp at driver initialization,
and
Add the sysfs documentation for the rescan attribute of
dprc devices.
Signed-off-by: Lijun Pan
---
Documentation/ABI/testing/sysfs-devices-dprc | 13 +
1 file changed, 13 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-devices-dprc
diff --git a/Documentation/ABI/te
Define a static inline function is_root_dprc(dev) to tell whether
a device is root dprc or not via platform_bus_type.
Remove fsl_mc_is_root_dprc() because is_root_dprc() is simpler
and easier to understand.
Signed-off-by: Lijun Pan
---
v2: use static inline function instead of macro
replace t
Introduce the rescan attribute as a bus attribute to
synchronize the fsl-mc bus objects and the MC firmware.
To rescan the fsl-mc bus, e.g.,
echo 1 > /sys/bus/fsl-mc/rescan
Signed-off-by: Lijun Pan
---
drivers/staging/fsl-mc/bus/mc-bus.c | 46 +
1 file change
This series of patches are based on
http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=63f2be5c3b358db031f86eafa9cd450f6558a55b
patch v1 1/5 "staging: fsl-mc: section mismatch bug fix" is already accepted.
This v2 series have,
patch 1/8 use inline function to
Introduce the rescan attribute as a device attribute to
synchronize the fsl-mc bus objects and the MC firmware.
To rescan the root dprc only, e.g.
echo 1 > /sys/bus/fsl-mc/devices/dprc.1/rescan
Signed-off-by: Lijun Pan
---
drivers/staging/fsl-mc/bus/mc-bus.c | 43 +++
Add the sysfs documentation for the rescan attribute of
fsl-mc bus.
Signed-off-by: Lijun Pan
---
Documentation/ABI/testing/sysfs-bus-fsl-mc | 11 +++
1 file changed, 11 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-bus-fsl-mc
diff --git a/Documentation/ABI/testing/sy
Add more introduction of restool driver and state why
restool driver is needed in helping moving fsl-mc bus
out of staging tree.
Signed-off-by: Lijun Pan
---
drivers/staging/fsl-mc/README.txt | 11 ++-
drivers/staging/fsl-mc/TODO | 18 --
2 files changed, 26 inserti
The PCI-1710 series boards are multifunction data acquisition boards with
analog inputs and outputs, digital inputs and outputs, and counter/timer
functions.
The PCI-1720 is a simple 4 channel analog output board. It also uses a
unique register map.
Separate out the PCI-1720 support as a new driv
Fixed a comment issue.
Signed-off-by: Philippe Loctaux
---
drivers/staging/comedi/drivers/ssv_dnp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c
b/drivers/staging/comedi/drivers/ssv_dnp.c
index acc7f34..c28b6cb 100644
--- a/drive
> -Original Message-
> From: Andy Shevchenko [mailto:[email protected]]
> Sent: Friday, October 30, 2015 9:59 AM
> To: KY Srinivasan
> Cc: Jake Oshins ; Greg Kroah-Hartman
> ; [email protected];
> [email protected]; [email protected]; [email protected]; Vitaly
On Fri, Oct 30, 2015 at 6:56 PM, KY Srinivasan wrote:
>> >> What about
>> >> #include
>> >>
>> >> UUID_LE(...)
>> >>
>> >> And you may use uuid_le type instead of custom raw buffer.
>> >>
>> >
>> > Thanks. I was just following the form of all the others in this file. I
>> > think
>> that this
> -Original Message-
> From: Andy Shevchenko [mailto:[email protected]]
> Sent: Friday, October 30, 2015 9:52 AM
> To: Jake Oshins
> Cc: Greg Kroah-Hartman ; KY Srinivasan
> ; [email protected];
> [email protected]; [email protected]; [email protected]; Vitaly
On Fri, Oct 30, 2015 at 5:57 PM, Jake Oshins wrote:
>> > + * PCI Express Pass Through
>> > + * {44C4F61D--4400-9D52-802E27EDE19F}
>> > + */
>> > +
>> > +#define HV_PCIE_GUID \
>> > + .guid = { \
>> > + 0x1D, 0xF6, 0xC4, 0x44, 0x44, 0x44, 0x00, 0x44, \
>> > +
> -Original Message-
> From: Pan Lijun-B44306
> Sent: Thursday, October 29, 2015 6:55 PM
> To: Wood Scott-B07421
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; Yoder Stuart-B08248
> ; katz Itai-RM05202 ;
> Rivera Jose-B46482 ;
> -Original Message-
> From: Jiang Liu [mailto:[email protected]]
> Sent: Thursday, October 29, 2015 6:55 PM
> To: Jake Oshins ; [email protected]; KY
> Srinivasan ; [email protected];
> [email protected]; [email protected]; [email protected];
> vkuzn...
> -Original Message-
> From: Andy Shevchenko [mailto:[email protected]]
> Sent: Thursday, October 29, 2015 5:28 PM
> To: Jake Oshins
> Cc: Greg Kroah-Hartman ; KY Srinivasan
> ; [email protected];
> [email protected]; [email protected]; [email protected]; Vitaly
> -Original Message-
> From: Andy Shevchenko [mailto:[email protected]]
> Sent: Thursday, October 29, 2015 5:45 PM
> To: Jake Oshins
> Cc: Greg Kroah-Hartman ; KY Srinivasan
> ; [email protected];
> [email protected]; [email protected]; [email protected]; Vitaly
This fixes spaces preferred around that ... from checkpatch.pl
Signed-off-by: Bogicevic Sasa
---
drivers/staging/gdm724x/gdm_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c
b/drivers/staging/gdm724x/gdm_tty.c
index d600728..60b52a3 100
This fixes Prefer kmalloc(sizeof(*gdm)...) over
kmalloc(sizeof(struct gdm)...) message from checkpatch.pl
Signed-off-by: Bogicevic Sasa
---
drivers/staging/gdm724x/gdm_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c
b/drivers/staging/g
This fixes message from checkpatch.pl Comparison to NULL could be
written "!gdm"
Signed-off-by: Bogicevic Sasa
---
drivers/staging/gdm724x/gdm_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c
b/drivers/staging/gdm724x/gdm_tty.c
index 0d
This fixes message "Blank lines aren't necessary after an open
brace '{'"
Signed-off-by: Bogicevic Sasa
---
drivers/staging/gdm724x/gdm_tty.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c
b/drivers/staging/gdm724x/gdm_tty.c
index 001348c..0d54a73 100644
--
Head Office:
Reliable Business Consultants
No.299 Broadway,New York City
NY 10007 United State
Pone: +12095807858
Branch off
This fixes all messages from checkpatch.pl about comparison to NULL
could be written according to coding style preferences
Signed-off-by: Bogicevic Sasa
---
drivers/staging/gdm724x/gdm_mux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c
This fixes all messages from checkpatch.pl about spaces preffered around
that +
Signed-off-by: Bogicevic Sasa
---
drivers/staging/gdm724x/gdm_mux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c
b/drivers/staging/gdm724x/gdm_mux.c
index
This fixes the errors about the use of multiple blank lines from
checkpatch.pl
Signed-off-by: Bogicevic Sasa
---
drivers/staging/gdm724x/gdm_mux.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c
b/drivers/staging/gdm724x/gdm_mux.c
index 0389680..45007ec
This fixes "Blank lines aren't necessary after an open brace '{'"
message from checkpatch.pl
Signed-off-by: Bogicevic Sasa
---
drivers/staging/gdm724x/gdm_mux.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c
b/drivers/staging/gdm724x/gdm_mux.c
index 1cf24e4
On Fri, Oct 30, 2015 at 08:13:48AM -0200, Albino B Neto wrote:
> 2015-10-29 19:12 GMT-02:00 Greg KH :
> >> 0 - https://www.kernel.org/doc/Documentation/CodingStyle
> >
> > I don't understand what you are saying here, what does this email mean?
>
> I have to send private him ? The link for help.
A
On 29/10/15 17:19, H Hartley Sweeten wrote:
The PCI-1710 series boards are multifunction data acquisition boards with
analog inputs and outputs, digital inputs and outputs, and counter/timer
functions.
The PCI-1720 is a simple 4 channel analog output board. It also uses a
unique register map.
S
Haiyang Zhang writes:
>> -Original Message-
>> From: Richard Weinberger [mailto:[email protected]]
>> Sent: Tuesday, October 27, 2015 6:36 PM
>> To: David Miller
>> Cc: Haiyang Zhang ; [email protected]; Greg Kroah-
>> Hartman ; [email protected]; [email protected];
>> dri
On Fri, Oct 30, 2015 at 08:13:48AM -0200, Albino B Neto wrote:
> 2015-10-29 19:12 GMT-02:00 Greg KH :
> >> 0 - https://www.kernel.org/doc/Documentation/CodingStyle
> >
> > I don't understand what you are saying here, what does this email mean?
>
> I have to send private him ? The link for help.
N
2015-10-29 19:12 GMT-02:00 Greg KH :
>> 0 - https://www.kernel.org/doc/Documentation/CodingStyle
>
> I don't understand what you are saying here, what does this email mean?
I have to send private him ? The link for help.
Albino
___
devel mailing li
Use wilc instead of g_linux_wlan. g_liux_wlan is not used anymore, just
delete it.
Signed-off-by: Glen Lee
---
Changes in v2: use sizeof(*wl) instead of sizeof(struct wilc).
drivers/staging/wilc1000/linux_wlan.c | 22 +++---
drivers/staging/wilc1000/wilc_wfi_netdevice.h
This patch adds new argument struct wilc and use it instead of g_linux_wlan,
pass wilc to the functions as well.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan.c | 44 ++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/sta
This patch add new argument struct net_device and use netdev private data
member wilc instead of g_linux_wlan, pass dev to the function as well.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 4 +---
drivers/staging/wilc1000/linux_wlan.c | 10 +++---
dri
This patch adds struct wilc and use it instead of g_linux_wlan, pass dev
to the functions as well.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan.c | 47 ++--
1 file changed, 34 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/wilc1000/
This patch adds new argument struct net_device and pass dev to the function.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_wlan.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
dif
This patch adds new argument struct net_device and use netdev private data
member wilc instead of g_linux_wlan, pass dev to the function as well.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --g
This patch add new argument struct net_device and pass dev to the function
as well.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/wilc_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_wlan.h | 1 +
3 files changed, 4 insertions(+),
This patch adds new argument struct net_device and pass dev to the functions.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 4 ++--
drivers/staging/wilc1000/wilc_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_wlan.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
Add new argument struct net_device and pass dev to the function as well.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_wlan.c | 3 ++-
drivers/staging/wilc1000/wilc_wlan.h | 3 ++-
3 files changed, 5 insertions(+), 3 deletions(-)
diff
Remove unused function wilc_wlan_global_reset.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
b/drivers/staging/wilc1000/wilc_wlan.c
index d4eef3d..c464cd7 100644
--- a/drivers/sta
Just remove unused function remove_TCP_related.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
b/drivers/staging/wilc1000/wilc_wlan.c
index b503f07..c8ce1f6 100644
--- a/drivers
This patch adds new argument net_device and use netdev private data member
wilc instead of g_linux_wlan, pass dev to the functions also.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/coreconfigurator.c | 3 +-
drivers/staging/wilc1000/linux_wlan.c | 86 ++---
This patch adds new argument struct net_device and use netdev private data
member wilc instead of g_linux_wlan, pass dev to the function.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/stagi
Add argument struct net_device and pass dev to the functions as well.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/wilc_wlan.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
b/drivers/staging/wilc1000/wilc_wlan.c
index a72
Adds argument struct net_device and use netdev private data member wilc
instead of g_linux_wlan, pass dev to the functions as well.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/coreconfigurator.c | 3 ++-
drivers/staging/wilc1000/linux_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_w
This patch adds new argument struct net_device and pass dev to the function
as well.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/coreconfigurator.c | 3 +-
drivers/staging/wilc1000/coreconfigurator.h | 3 +-
drivers/staging/wilc1000/host_interface.c | 196 +
This patch defines wiphy private data priv in struct host_if_drv and set
priv to priv in host_if_drv to reference it's wiphy private data.
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/host_interface.h | 1 +
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 +
2 files changed
On 2015년 10월 30일 17:35, Dan Carpenter wrote:
On Fri, Oct 30, 2015 at 12:10:42PM +0900, Glen Lee wrote:
/*create the common structure*/
- g_linux_wlan = kzalloc(sizeof(*g_linux_wlan), GFP_KERNEL);
- if (!g_linux_wlan)
+ wl = kzalloc(sizeof(struct wilc), GFP_KERNEL);
T
On Fri, Oct 30, 2015 at 12:10:42PM +0900, Glen Lee wrote:
> /*create the common structure*/
> - g_linux_wlan = kzalloc(sizeof(*g_linux_wlan), GFP_KERNEL);
> - if (!g_linux_wlan)
> + wl = kzalloc(sizeof(struct wilc), GFP_KERNEL);
This introduces a checkpatch.pl warning. The prefe
On Thu, Oct 29, 2015 at 07:28:21PM -0400, James Simmons wrote:
> With nidstring now having the latest fixes we can
> now clean up all the remaining checkpatch errors
> for nidstring.c.
>
> Signed-off-by: James Simmons
> ---
You are doing different types of changes in this patch. Please split
the
100 matches
Mail list logo
