This is a patch to move opening braces to the lines on which their
corresponding if-statements exist in ieee80211_softmac_wx.c.
Signed-off-by: Mike Dupuis
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/dr
This is a patch to correct two flavors of brace styling issues in
ieee80211_softmac_wx.c.
Signed-off-by: Mike Dupuis
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee8
This is a patch to add blank lines after declaration ins several
instances in iee80211_softmac_wx.c.
Signed-off-by: Mike Dupuis
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softma
This is a patch to add missing spaces around == and || operators in one
instance in ieee80211_softmac_wx.c.
Signed-off-by: Mike Dupuis
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80
This is a patch to add spaces around = operators in several instances
in ieee80211_softmac_wx.c
Signed-off-by: Mike Dupuis
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee802
This is a fix to add spaces after commas in ieee80211_softmac_wx.c.
Signed-off-by: Mike Dupuis
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c
b/drivers/st
This series of patches addresses several checkpatch.pl issues in
ieee80211_softmac_wx.c.
Before: total: 14 errors, 24 warnings, 59 checks, 602 lines checked
After: total: 0 errors, 20 warnings, 59 checks, 599 lines checked
Mike Dupuis (6):
Staging: rtl8192u: space required after ','
Staging:
On Thu, Sep 24, 2015 at 02:38:26AM +0530, Punit Vara wrote:
> This is a patch to the rtl871x_sta_mgt.c file that fixes up following
> warning reported by checkpatch.pl:
>
> -Block comments use a trailing */ on a separate line
>
> Signed-off-by: Punit Vara
> ---
When you are sending multiple patc
On Thu, Sep 24, 2015 at 01:22:33AM +0530, Punit Vara wrote:
> This patch is to the rtl871x_io.h file that fixes up following warning
> reported by checkpatch.pl :
>
> Signed-off-by: Punit Vara
> ---
You missed copying the warning after mentioning "following warning" in
your commit message.
regar
On Wed, Sep 23, 2015 at 09:13:42PM +0200, Arnd Bergmann wrote:
> This time is only printed in procfs, and can be easily converted
> to 64-bit to avoid overflowing on 32-bit systems in 2038.
>
> Signed-off-by: Arnd Bergmann
> ---
This introduces new build warnings:
drivers/staging/lustre/lustre/o
On Wed, Sep 23, 2015 at 11:22:09PM +0530, punit vara wrote:
> On Wed, Sep 23, 2015 at 10:25 PM, punit vara wrote:
> > Thank you very much sir I will definitely follow that. I have seen so
> > many people fixing patches over here. Now I know process of submitting
> > patches.I am able to fix severa
On Sep 23, 2015, at 3:13 PM, Arnd Bergmann wrote:
> The lustre tracefile has a timestamp defined as
>
> __u32 ph_sec;
> __u64 ph_usec;
>
> which seems completely backwards, as the microsecond portion of
> a time stamp will always fit into a __u32 value, while the second
> portion wi
On Sep 23, 2015, at 3:13 PM, Arnd Bergmann wrote:
> The last request time is stored as an 'unsigned long', which is
> good enough until 2106, but it is then converted to 'long' in
> some places, which overflows in 2038.
>
> This changes the type to time64_t to avoid those problems.
Hm…
All this
On Fri, Jun 26, 2015 at 01:36:14PM -0300, Gaston Gonzalez wrote:
> On Thu, Jun 25, 2015 at 02:06:44PM +0200, Arnd Bergmann wrote:
> > On Wednesday 24 June 2015 13:34:58 Gaston Gonzalez wrote:
> > > On Tue, Jun 23, 2015 at 12:13:47PM +0200, Arnd Bergmann wrote:
> > > > On Sunday 21 June 2015 19:12:0
On Wed, Sep 23, 2015 at 12:10:13PM -0500, atull wrote:
> On Tue, 22 Sep 2015, Josh Cartwright wrote:
[..]
> > > +struct fpga_manager *of_fpga_mgr_get(struct device_node *node)
> > > +{
> > > + struct fpga_manager *mgr;
> > > + struct device *dev;
> > > +
> > > + if (!node)
> > > + return ER
The kbuild test robot reports the following build error for
i386-randconfig-c0-09230740:
>> ERROR: "ieee80211_hdrlen" [drivers/staging/rtl8188eu/r8188eu.ko] undefined!
Add a dependency on CFG80211 to fix it.
Signed-off-by: Jakub Sitnicki
---
Same issue has also been reported by Jim Davis for
r
Add cmd_flags parameter to all dprc APIs to comply
with the dprc 4.0 MC interface. Updated MC version
major number. Pass irq args in struct instead of
separate args.
dprc 4.0 uses MC-relative offsets to specify object regions,
instead of physical addresses. So, translate_mc_addr() and
struct fsl_
The DPAA2 management complex has a versioned binary interface
that has to be kept in sync with the DPAA2 drivers. This patch
uprevs the APIs that build MC commands and parse results.
This uprev is needed to support object interrupts.
MC binary interface changes
-overall version from 6.0 to 8.0
Add cmd_flags parameter to all dpbp APIs to comply
with the dpbp 2.0 MC interface. Updated MC version
major number. Pass irq args in struct instead of
separate args.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/dpbp.c | 94 +++
drivers/stagin
Add cmd_flags parameter to all dpbp APIs to comply
with the dpmcp 2.0 MC interface. Updated version
major number. Pass irq args in struct instead of
separate args.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/dpmcp-cmd.h| 2 +-
drivers/staging/fsl-mc/bus/dpmcp.c|
dpcon object minor version number updated to match latest
MC firmware. This change is needed because the dpcon
object binds to the allocator and the current driver match
logic uses object version numbers.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/include/dpcon-cmd.h | 2 +-
1 fi
The Management Complex (MC) binary interface added a new "flags"
field to the command header.
Add the definitions for this field in preparation for adding the
new cmd_flags parameter to all MC interface APIs.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/include/mc-cmd.h | 30 ++
Add cmd_flags parameter to all dpmng APIs to comply
with 8.0 MC firmware interface. Updated MC version
major number.
---
drivers/staging/fsl-mc/bus/dpmng.c | 14 ++
drivers/staging/fsl-mc/bus/mc-bus.c| 4 ++--
drivers/staging/fsl-mc/include/dpmng.h | 14 ++
3 files
This is a patch to the rtl871x_sta_mgt.c file that fixes up following
warning reported by checkpatch.pl:
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_sta_mgt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --g
Declare non-exported functions as static.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
b/drivers/staging/lustre/lustre/ptlrpc
This patch is to the rtl871x_security.h file that fixes up following
warning reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_security.h | 24
1 file changed, 16 insertions(+),
Include the header with declarations of variables that are shared between
several sources in ptlrpc module into the appropriate source files.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/sec_null.c | 2 ++
drivers/staging/lustre/lustre/ptlrpc/wiretest.c | 2 ++
2 files
This patch moves declarations of variables used in several files
across the ptlrpc module from source files to a local header.
Signed-off-by: Anton Gerasimov
---
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c| 1 -
drivers/staging/lustre/lustre/ptlrpc/nrs.c | 1 -
drivers/st
This series of patches eliminates some sparse warnings concerning
static variables in lustre rtlrpc module where it seemed reasonable.
Symbols that are really local to a source file are made static and
declarations added to a header for symbols that are shared between
source files.
v2: Thank Andre
This is patch to the rtl871x_security.c that fixes up following warning
reported by checkpatch.pl :
-Block comments use * on subsequent lines
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_security.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/s
This patch is to the rtl871x_recv.h file that fixes up following
warnings reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
-Block comments use * on subsequent lines
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_recv.h | 21 -
1
This patch is to the rtl871x_recv.c that fixes up following warnings
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
-Block comments use * on subsequent lines
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_recv.c | 27 ---
This is patch to the rtl871x_pwrctrl.c file that fixes following warning
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
-Block comments use * on subsequent lines
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_pwrctrl.c | 41 --
On Wednesday, September 23, 2015 11:36 AM, Ian Abbott wrote:
> Expand the descriptions of the functions and document the return values.
>
> Signed-off-by: Ian Abbott
Thanks,
Reviewed-by: H Hartley Sweeten
___
devel mailing list
de...@linuxdriverproje
This patch is to the rtl871x_mp_phy_regdef.h file that fixes up
following warning reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_mp_phy_regdef.h | 33 -
1 file changed, 22 in
This patch is for the rtl871x_mp_ioctl.h that fixes up following warning
reported by checkpatch.pl:
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_mp_ioctl.h | 39 --
1 file changed, 26 insertions(+)
This is a patch to the rtl871x_mp.h that fixes up following warnings
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_mp.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/
This patch is to the rtl871x_mp.c file that fixes up following warning
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit vara
---
drivers/staging/rtl8712/rtl871x_mp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/driver
This patch is to the rtl871x_mlme.h file that fixes up following warning
reported by checkpatch.pl :
-Block comments use * on subsequent lines
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_mlme.h | 28 -
This patch is to the rtl871x_mlme.c file that fixes up following warning
reported by checkpatch.pl:
- Block comments use * on subsequent lines
- Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_mlme.c | 45
This patch is to the rtl871x_led.h that fixes up following warnings
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_led.h | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff -
The result variable is not set anywhere beyond its initialization,
therefore it can be remove.
Signed-off-by: Tillmann Heidsieck
---
drivers/staging/wlan-ng/prism2fw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2fw.c
b/drivers/staging/wlan
We test for an END marker in the element beyond the current one, this
effectively limits the size of the array to be HFA384x_PDA_LEN_MAX/2 - 1
not HFA384x_PDR_END_OF_PDA/2. This patch fixes a possible buffer
overflow in case there was no END marker.
Signed-off-by: Tillmann Heidsieck
---
drivers/
Hi,
smatch found a possible buffer overflow in staging/wlan-ng, the first patch
of this series fixes this issue. The remaining two patches clean up
redundant code.
Cheers
Tillmann
Tillmann Heidsieck (3):
staging: wlan-ng fix buffer overflow in firmware handling
staging: wlan-ng remove redund
We exit the above loop either if curroff >= (HFA384x_PDA_LEN_MAX / 2 - 1)
or if we found the END marker in the element beyond the current one. The
first case is checked for in the preceding if statement, therefore the
second if statement is redundant and can be removed.
Signed-off-by: Tillmann Hei
This patch is to the rtl871x_io.h file that fixes up following warning
reported by checkpatch.pl :
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_io.h | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_io.h
b/drive
This patch is to the rtl871x_ioctl_set.c file that fixes up following
warning reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_ioctl_set.c | 12
1 file changed, 8 insertions(+), 4 deletion
This patch is to the rtl871x_ioctl.h that fixes up following warning
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_ioctl.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/d
Use the macros to clarify the divisor calculations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/rtd520.c
b/drivers/stag
This patch is to the rtl871x_ht.h that fixes up following warning
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_ht.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers
Use the preferred block command style.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 68 +
1 file changed, 36 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/comedi/drivers/rtd52
For aesthetics, rename this function and tidy it up a bit.
Use the comedi_range_is_bipolar() and comedi_offset_munge() helpers
to handle the 2's complement munging.
Save the readback value after the conversion is complete.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
The cfs_duration_usec() function has a timeval as its output, which we
want to avoid in general because of the y2038 problem.
There are only two locations remaining in lustre, so we can for now
replace one with jiffies_to_timeval(), which is a generic kernel function
that does the same thing, the
The cfs_duration_sec() converts a relative jiffies value into seconds,
and returns that number as a time_t. We know that a 32-bit type is
enough here, because the result is order of magnitudes smaller than
the difference in jiffies that is also expressed as a 'long', so
we can safely replace the ti
These three functions have not been in used for a long time,
so lets just remove them.
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lustre/include/obd.h | 62 -
1 file changed, 62 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/obd.h
b/dri
This ioctl function passes a 64-bit time argument but then performs
a computation with a 32-bit get_seconds() value.
In order to avoid overflow here, this changes the code to use
64-bit math and ktime_get_real_seconds().
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lnet/lnet/api-ni.c
The connection starting/failing time stamps will overflow in 2038
on 32-bit machines, so we need to use time64_t and ktime_get_real_seconds()
instead.
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c| 2 +-
drivers/staging/lustre/lnet/klnds/socklnd/socklnd
These function description comments are cut-and-paste cruft from the
old skeleton driver. Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 30 --
1 file changed, 30 deletions(-)
diff -
These three are timestamps that are sent over the wire in mdc_lib
and the obd logging 64-bit values, but are generated using the 32-bit
get_seconds() function, which will eventually overflow.
Changing them to use 64-bit ktime_get_real_seconds() solves the problem.
Signed-off-by: Arnd Bergmann
--
The exp_flvr_expire and imp_sec_expire are defined as 'unsigned long',
which doesn't overflow until 2106, but to be on the safe side, this
changes the code to use time64_t like we do everywhere else.
Signed-off-by: Arnd Bergmann
---
.../staging/lustre/lustre/include/lustre_export.h | 2 +-
...
All request timestamps and deadlines in lustre are recorded in time_t
and timeval units, which overflow in 2038 on 32-bit systems.
In this patch, I'm converting them to time64_t and timespec64,
respectively. Unfortunately, this makes a relatively large patch,
but I could not find an obvious way to
The llite procfs interface contains timestamps that are computed
from timeval, which overflows in 2038 on 32-bit systems.
This changes the output to use a timespec64 type to avoid the
overflow. I also change the format to print the sub-second portion
as 9 digits (nanoseconds) for clarity, rather t
The ni_last_alive member of lnet_ni uses a 'long' to store a timestamp,
which breaks on 32-bit systems in 2038.
This changes it to use time64_t and the respective functions for it.
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/include/linux/lnet/lib-types.h | 2 +-
drivers/staging/lus
The lnet_eq_wait_locked tries to wait for time to pass or an event to
wake up the wait queue. The entire logic seems to be a very elaborate
reimplementation of wait_event().
I'm not trying to clean up the entire logic here, but this at least
gets rid of the multi-way conversion between miliseconds
ptlrpc_enc_page_pool computes time deltas using 'long' values from
get_seconds(). This is probably safe beyond y2038, but it's better
to go use monotonic times and 64-bit here for consistency.
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 24 -
The wire protocol for the ping uses a 64-bit seconds/microseconds
pair, but this won't work when one side uses a 32-bit timeval
to look up the current time beyond 2038.
This changes the code to use ktime_get_real_ts64() to create
a timestamp that has the right format on all machines.
Signed-off-b
process_param2_config() tries to print how much time has passed
across a call_usermodehelper() function, and uses struct timeval
for that.
We want to remove this structure, so this is better expressed
in terms of ktime_t and ktime_us_delta().
Signed-off-by: Arnd Bergmann
---
drivers/staging/lus
The obd_eviction_timer will overflow in 2038 on 32-bit systems,
so replace it with a 64-bit time and ktime_get_real_seconds().
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lustre/include/obd.h| 2 +-
drivers/staging/lustre/lustre/ptlrpc/service.c | 4 ++--
2 files changed, 3 inser
The recently introduced lnet_peer_set_alive() function uses
get_seconds() to read the current time into a shared variable,
but all other uses of that variable compare it to jiffies values.
This changes the current use to jiffies as well for consistency.
This likely changes behavior, and should be
The lustre tracefile has a timestamp defined as
__u32 ph_sec;
__u64 ph_usec;
which seems completely backwards, as the microsecond portion of
a time stamp will always fit into a __u32 value, while the second
portion will overflow in 2038 or 2106 (in case of unsigned seconds).
This r
A bunch of API functions deal with time values but are now
completely unused in lustre. This removes them in order to
remove all references to time_t from the header files.
Signed-off-by: Arnd Bergmann
---
.../lustre/include/linux/libcfs/libcfs_time.h | 49 --
.../lustre
This is a simple cleanup that I did after noticing that the abstraction
for the timer functions in completely pointless, and the one user (ptlrpc)
can just as well call the native Linux functions.
For good measure, this also removes the empty libcfs_arch_init()
and libcfs_arch_cleanup() functions
The last request time is stored as an 'unsigned long', which is
good enough until 2106, but it is then converted to 'long' in
some places, which overflows in 2038.
This changes the type to time64_t to avoid those problems.
Signed-off-by: Arnd Bergmann
---
.../staging/lustre/lustre/include/lustr
The ll_setattr_raw() function prints the new inode timestamps
along with the current time using '%lu', which overflows in
2106. This changes the printing of the current time for
now, the other two will change when we migrate the VFS code
to use 64-bit timestamps.
Signed-off-by: Arnd Bergmann
---
The s2dhms computes the day/hour/minute/second values from a time_t,
which stops working in 2038. This changes the code to take a time64_t
argument, and use div_u64_rem() to implement the first division.
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lustre/include/lprocfs_status.h | 6
This adapts the format string and get_seconds() call to not
overflow in 2038 in the libcfs_debug_dumplog_internal()
function.
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lustre/libcfs/debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lust
Here, we actually have a problem in 2038 or at the latest in 2106 when
the lc_expiry variable on the wire protocol overflows, including on
64-bit architectures.
I'm changing the internal implementation so it only compares the lower
31 bits of the current time, using the algorithm from time_before(
The CFS_TIME_T macro serves no real purpose as we stopped using time_t
and changed over to time64_t, so we can remove the last remaining uses
of this.
Two uses of this macro are incorrect and refer to jiffies values
rather than time_t, and one refers to an inode timespec that gets
changed separate
Here we use an unsigned long to store the timeout for gc,
which is probably safe until 2106, but this patch converts it
to use ktime_get_real_seconds() and time64_t for consistency.
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lustre/include/lustre_sec.h | 2 +-
drivers/staging/lustre
The lustre selftest code has multiple time stamps that are kept
as 'time_t' or 'unsigned long' and can therefore overflow on
32-bit systems.
This changes the code to use time64_t instead.
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lnet/selftest/brw_test.c | 6 +++---
drivers/stag
The ldlm pool calculates elapsed time by comparing the previous and
current get_seconds() values, which is unsafe on 32-bit machines
after 2038.
This changes the code to use time64_t and ktime_get_real_seconds(),
keeping the 'real' instead of 'monotonic' time because of the
debug prints.
Signed-o
This time is only printed in procfs, and can be easily converted
to 64-bit to avoid overflowing on 32-bit systems in 2038.
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lustre/include/lustre_import.h | 4 ++--
.../staging/lustre/lustre/obdclass/lprocfs_status.c | 19 +---
We want to get rid of all uses of time_t, and it turns out
that obd.h contains a bunch of them that are completely unused.
This removes those structures, along with a couple of other
structures and functions in the same file that also turned
out to be unused.
Signed-off-by: Arnd Bergmann
---
dr
The l_last_activity struct member is used to keep track lock hold
times, and it is printed for debugging purposes. For the elapsed
time, we can use 'long' here, but it's better to use time64_t
for storing the real time to avoid an overflow in 2038.
Signed-off-by: Arnd Bergmann
---
drivers/stagin
The adaptive timeout handling stores absolute times in 32-bit time_t
quantities, which will overflow in 2038.
This changes it to use time64_t.
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lustre/include/lustre_import.h | 6 +++---
drivers/staging/lustre/lustre/obdclass/lprocfs_stat
For aesthetics, convert the defines for the various DAC registers into
macros that take the comedi channel and return the correct offset.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 33 -
1
First of all, sorry for the overly long series that this turned into.
I'm currently doing a survey of all code using time_t/timeval/timespec
to get an idea of what work needs to be done where, in particular in
terms of user interface changes.
Lustre is by far the most pervasive user of time types
ibn_incarnation is a 64-bit value, but using timeval to compute
it will cause an overflow in 2038. This changes it to use
ktime_get_real_ts64() instead.
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-
The rq_at_index member of ptlrpc_request is incorrectly declared as
time_t, when it is only used as an index into an array, and assigned
from a __u32 variable.
This changes the type to u32, so we can kill off another use of time_t.
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lustre/
Lustre has 64-bit timestamps in its network data structures, but
on 32 bit systems, it converts them directly into time_t, which is
32 bit wide.
This changes the code to use 64-bit time stamps for files. The Linux
VFS code still uses time_t though, and will be changed in a separate
patch series.
Fix the checkpatch.pl issues about:
WARNING: Comparisons should place the constant on the right side of the test
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions
Some lustre procfs files contain the current time. Make sure
we use a format here that does not overflow in 2038.
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lustre/osc/lproc_osc.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/lu
This function uses do_gettimeofday() to get a pseudo-random number.
There is no bug here, but changing it to use ktime_get_ts64()
gets us closer to deprecating do_gettimeofday() and makes slightly
more random.
Signed-off-by: Arnd Bergmann
---
drivers/staging/lustre/lnet/lnet/router.c
These comments are cut-and-paste from the old skeleton driver. Remove
them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/rtd520.c
b/drive
Fix checkpatch issue: "CHECK: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt". `udelay()` is only used in the
firmware upload process. Replace them with `usleep_range()` with a
reasonable upper limit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kr
For aesthetics, rename this CamelCase array.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/rtd520.c
b/drivers/staging/c
Fix the checkpatch.pl issues about:
CHECK: Logical continuations should be on the previous line
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers
Use the BIT macro to define the register bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 54 -
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/comedi/drive
Tidy up this driver and fix all the checkpatch.pl issues.
H Hartley Sweeten (11):
staging: comedi: rtd520: prefer using the BIT macro
staging: comedi: rtd520: fix logical continuations
staging: comedi: rtd529: usleep_range is preferred over udelay
staging: comedi: rtd520: rename rtd520Boar
This patch is to the rtl871x_cmd.h file that fixes up following warnings
reported by checkpatch.pl :
-Block comments use * on subsequent lines
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara
---
drivers/staging/rtl8712/rtl871x_cmd.h | 282 +
1 - 100 of 148 matches
Mail list logo
