Re: [PATCH 11/18] staging: wilc1000: rename WILC_WFI_set_cqm_rssi_config

On Sun, Sep 20, 2015 at 03:51:18PM +0900, Chaehyun Lim wrote: > This patch replaces WILC_WFI_set_cqm_rssi_config with > set_cqm_rssi_config to avoid CamelCase. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 > 1 file changed, 4 insertions(+

Re: [PATCH 08/18] staging: wilc1000: remove declaration of WILC_WFI_frame_register

On Mon, Sep 21, 2015 at 03:20:12PM +0900, Tony Cho wrote: > > > On 2015년 09월 21일 15:07, Greg KH wrote: > >On Mon, Sep 21, 2015 at 02:54:28PM +0900, Tony Cho wrote: > >> > >>On 2015년 09월 21일 11:01, Greg KH wrote: > >>>On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote: > This patch r

Re: [PATCH 08/18] staging: wilc1000: remove declaration of WILC_WFI_frame_register

On 2015년 09월 21일 15:07, Greg KH wrote: On Mon, Sep 21, 2015 at 02:54:28PM +0900, Tony Cho wrote: On 2015년 09월 21일 11:01, Greg KH wrote: On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote: This patch removes function declaration of WILC_WFI_frame_register in linux_wlan.c file, then

Re: [PATCH 08/18] staging: wilc1000: remove declaration of WILC_WFI_frame_register

On Mon, Sep 21, 2015 at 02:54:28PM +0900, Tony Cho wrote: > > > On 2015년 09월 21일 11:01, Greg KH wrote: > >On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote: > >>This patch removes function declaration of WILC_WFI_frame_register in > >>linux_wlan.c file, then adds it in wilc_wfi_cfgoper

Re: [PATCH 1/2] staging: wilc1000: replace s32Error with result

On Mon, Sep 21, 2015 at 09:25:31AM +0900, Chaehyun Lim wrote: > Most of functions use s32Error variable to check error and return its value. > This patch replaces s32Error with result to avoid CamelCase. > > Signed-off-by: Chaehyun Lim This doesn't apply at all anymore. I suggest doing as Julia

Re: [PATCH v2 02/34] staging: wilc1000: remove typedef from the struct

On 2015년 09월 21일 14:54, Greg KH wrote: On Mon, Sep 21, 2015 at 12:16:31PM +0900, Tony Cho wrote: The Linux kernel coding style does not recommend to use typedef for the structure. This patch removes typedef from the host_if_msg structure. Signed-off-by: Tony Cho Signed-off-by: Greg Kroah-Har

Re: [PATCH 08/18] staging: wilc1000: remove declaration of WILC_WFI_frame_register

On 2015년 09월 21일 11:01, Greg KH wrote: On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote: This patch removes function declaration of WILC_WFI_frame_register in linux_wlan.c file, then adds it in wilc_wfi_cfgoperations.h file. The compilation warning occurs because it is assigned to

Re: [PATCH v2 01/34] staging: wilc1000: rename tstrHostIFmsg

On Mon, Sep 21, 2015 at 12:16:30PM +0900, Tony Cho wrote: > This patch changes the name, tstrHostIFmsg to host_if_msg not to use > camelcase notation in the Linux. > > Signed-off-by: Tony Cho > Signed-off-by: Greg Kroah-Hartman Is this already in my tree? Why send it to me again? confused, g

Re: [PATCH v2 02/34] staging: wilc1000: remove typedef from the struct

On Mon, Sep 21, 2015 at 12:16:31PM +0900, Tony Cho wrote: > The Linux kernel coding style does not recommend to use typedef for the > structure. This patch removes typedef from the host_if_msg structure. > > Signed-off-by: Tony Cho > Signed-off-by: Greg Kroah-Hartman This too is already in my t

Re: [PATCH 3/3] drivers:hv: Define the channel type for Hyper-V PCI Express pass-through

On Tue, Sep 15, 2015 at 06:26:49PM -0700, K. Y. Srinivasan wrote: > From: Jake Oshins > > This defines the channel type for PCI front-ends in Hyper-V VMs. > > Signed-off-by: Jake Oshins > Signed-off-by: K. Y. Srinivasan > --- > include/linux/hyperv.h | 11 +++ > 1 files changed, 11

Re: [PATCH 2/3] drivers:hv: Export the API to invoke a hypercall on Hyper-V

On Tue, Sep 15, 2015 at 06:26:48PM -0700, K. Y. Srinivasan wrote: > From: Jake Oshins > > This patch exposes the function that hv_vmbus.ko uses to make hypercalls. > This > is necessary for retargeting an interrupt when it is given a new affinity. > > Since we are exporting this API, rename th

Re: [PATCH 4/5] hv: kvp: use wrappers to propaigate state

On Tue, Sep 15, 2015 at 05:37:53PM -0700, K. Y. Srinivasan wrote: > From: Olaf Hering > > The "state" is used by several threads of execution. > Propagate the state to make changes visible. Also propagate context > change in kvp_on_msg. > > Signed-off-by: Olaf Hering > Signed-off-by: K. Y. Srin

Re: [PATCH 2/5] hv: add helpers to handle hv_util device state

On Tue, Sep 15, 2015 at 05:37:51PM -0700, K. Y. Srinivasan wrote: > From: Olaf Hering > > The callbacks in kvp, vss and fcopy code are called both from the main thread > as well as from interrupt context. If a state change is done by the main > thread it is not immediately seen by the interrupt.

Re: [PATCHv3 02/15] staging: rtl8192u: r8192U_core: add temporary variables to keep lines under 80 characters

On Sun, Sep 20, 2015 at 01:14:14PM -0400, Raphaël Beamonte wrote: > Add some temporary variables to reduce line length under the maximum > of 80 characters, as per the kernel code style. > > Signed-off-by: Raphaël Beamonte > --- > drivers/staging/rtl8192u/r8192U_core.c | 139 > +

Re: [PATCH] staging: lustre: lustre: libcfs: Added a blank line

On Sun, Sep 20, 2015 at 10:35:01PM +0530, Anjali Menon wrote: > Added a blank line after declaration. Coding style > warning detected by checkpatch.pl > > WARNING: Missing a blank line after declarations > > Signed-off-by: Anjali Menon > --- > drivers/staging/lustre/lustre/libcfs/module.c | 1 +

Re: [PATCH 08/18] staging: wilc1000: remove declaration of WILC_WFI_frame_register

On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote: > This patch removes function declaration of WILC_WFI_frame_register in > linux_wlan.c file, then adds it in wilc_wfi_cfgoperations.h file. > > The compilation warning occurs because it is assigned to incorrect > pointer type of second

Re: [PATCH 10/18] staging: wilc1000: rename WILC_WFI_set_power_mgmt

On Sun, Sep 20, 2015 at 03:51:17PM +0900, Chaehyun Lim wrote: > This patch replaces WILC_WFI_set_power_mgmt with set_power_mgmt to avoid > CamelCase. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 > 1 file changed, 4 insertions(+), 4 delet

Re: [PATCH 08/18] staging: wilc1000: remove declaration of WILC_WFI_frame_register

On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote: > This patch removes function declaration of WILC_WFI_frame_register in > linux_wlan.c file, then adds it in wilc_wfi_cfgoperations.h file. > > The compilation warning occurs because it is assigned to incorrect > pointer type of second

Re: [PATCH 001/192] staging: rtl8192e: Rename rtl8192_init

On Sun, Sep 20, 2015 at 10:09:22AM +0200, Mateusz Kulikowski wrote: > Use naming schema found in other rtlwifi devices. > Rename rtl8192_init to _rtl92e_init. > > Signed-off-by: Mateusz Kulikowski > --- > drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH] staging: lustre: lustre: libcfs: Removed a space

On Sun, Sep 20, 2015 at 10:59:16PM +0530, Anjali Menon wrote: > Removed space between function name and open paranthesis > detected by checkpatch.pl > > 112: WARNING: space prohibited between function name and open > parenthesis '(' Please don't wrap error/warning messages like these. And this p

Re: [PATCH] Staging: fbtft: Remove debug messages

On Sat, Sep 19, 2015 at 10:19:17PM +0530, Shraddha Barke wrote: > Remove debug messages related to fbtft_par_dbg(DEBUG_INIT_DISPLAY.. ) > as this info can be obtained using kernel function tracer > > Signed-off-by: Shraddha Barke Something is messed up in this patch, when trying to apply it I ge

Re: [PATCH v3] staging: unisys: Add s-Par visorhba

On Wed, Aug 26, 2015 at 12:11:12AM -0400, Benjamin Romer wrote: > + /* convert buffer to phys information */ > + if ((scsi_sg_count(scsicmd) == 0) && (scsi_bufflen(scsicmd) > 0)) { > + BUG_ON(scsi_sg_count(scsicmd) == 0); Ah nice, you just crashed the kernel and all data is now

Re: [PATCH 07/18] staging: wilc1000: replaces PRINT_D with netdev_err

On Sun, Sep 20, 2015 at 03:51:14PM +0900, Chaehyun Lim wrote: > This patch replaces PRINT_D with netdev_err which is used at error > checking. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >

Re: [PATCH 06/18] staging: wilc1000: replace PRINT_D with netdev_info

On Sun, Sep 20, 2015 at 03:51:13PM +0900, Chaehyun Lim wrote: > This patch replaces PRINT_D with netdev_info in wilc_free_wiphy function. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > dif

[PATCH v2 23/34] staging: wilc1000: remove typedef from the struct tstrHostIFSetMulti

This patch removes typedef from the struct tstrHostIFSetMulti and renames it to set_multicast in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH v2 25/34] staging: wilc1000: remove typedef from the struct tstrHostIfSetMacAddress

This patch removes typedef from the struct tstrHostIfSetMacAddress and renames it set_mac_addr in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 5 +++-- drivers/staging/wilc1000/host_interface.h | 4 ++-- 2 files changed, 5 i

[PATCH v2 32/34] staging: wilc1000: remove unnecessary global variable

The global variable msgQ_created is removed because it is not necessary. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 0c8bc0

[PATCH v2 33/34] staging: wilc1000: remove u32Intialized which is unnecessary

This patch removes the global variable, u32Intialized which is not necessary from the host_interface.c file. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/driv

[PATCH v2 34/34] staging: wilc1000: delete unnecessary comments and dead code

The comments in union message_body are not essential and cross 80 ending line, so they are deleted and also a dead code commented out in the union is deleted. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 27 +-- 1 file changed, 13 insertions(+),

[PATCH v2 16/34] staging: wilc1000: remove typedef from the struct tstrHostIFDelBeacon

This patch removes typedef from the struct tstrHostIFDelBeacon and renames it to del_beacon in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/driv

[PATCH v2 26/34] staging: wilc1000: remove typedef from the struct tstrHostIfGetMacAddress

This patch removes typedef from the struct tstrHostIfGetMacAddress and renames it get_mac_addr in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 5 +++-- drivers/staging/wilc1000/host_interface.h | 4 ++-- 2 files changed, 5 i

[PATCH v2 31/34] staging: wilc1000: remove typedef from the struct tstrHostIFDelAllSta

This patch removes typedef from the struct tstrHostIFDelAllSta and renames it to del_all_sta in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dr

[PATCH v2 12/34] staging: wilc1000: remove typedef from the struct tstrHostIFCfgParamAttr

This patch removes typedef from the struct tstrHostIFCfgParamAttr and renames it to cfg_param_attr in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --gi

[PATCH v2 29/34] staging: wilc1000: remove typedef from the struct tstrHostIfRemainOnChan

This patch removes typedef from the struct tstrHostIfRemainOnChan and renames it to remain_ch in order to comply with the Linux coding style Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 +--- drivers/staging/wilc1000/host_interface.h | 6 +++--- 2 files changed,

[PATCH v2 13/34] staging: wilc1000: remove typedef from the struct tstrHostIFSetChan

This patch removes typedef from the struct tstrHostIFSetChan and ranames it to set_channel in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drive

[PATCH v2 06/34] staging: wilc1000: rename uniHostIFmsgBody

This patch changes the camelcase notation, uniHostIFmsgBody which is a member variable of structure host_if_msg to body in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 296 +++--- 1 file changed, 148

[PATCH v2 30/34] staging: wilc1000: remove typedef from the struct tstrHostIfRegisterFrame

This patch removes typedef from the struct tstrHostIfRegisterFrame and renames it to reg_frame in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 5 +++-- drivers/staging/wilc1000/host_interface.h | 7 ++- 2 files changed,

[PATCH v2 28/34] staging: wilc1000: remove typedef from the struct tstrHostIFDelSta

This patch removes typedef from the struct tstrHostIFDelSta and renames it del_sta in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/st

[PATCH v2 27/34] staging: wilc1000: remove typedef from the struct tstrHostIfBASessionInfo

This patch removes typedef from the struct tstrHostIfBASessionInfo and renames it to ba_session_info in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 17 ++--- drivers/staging/wilc1000/host_interface.h | 4 ++--

[PATCH v2 22/34] staging: wilc1000: remove typedef from the struct tstrHostIfSetDrvHandler

This patch removes typedef from the struct tstrHostIfSetDrvHandler and renames it to drv_handler in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 7 --- drivers/staging/wilc1000/host_interface.h | 4 ++-- 2 files changed,

[PATCH v2 15/34] staging: wilc1000: remove typedef from the struct tstrHostIFSetBeacon

This patch removes typedef from the struct tstrHostIFSetBeacon and renames it to set_beacon in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/dr

[PATCH v2 24/34] staging: wilc1000: remove typedef from the struct tstrHostIfSetOperationMode

This patch removes typedef from the struct tstrHostIfSetOperationMode and renames it to op_mode in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 5 +++-- drivers/staging/wilc1000/host_interface.h | 4 ++-- 2 files changed, 5

[PATCH v2 21/34] staging: wilc1000: remove typedef from the struct tstrHostIFSetIPAddr

This patch removes typedef from the struct tstrHostIFSetIPAddr and renames it to set_ip_addr in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/

[PATCH v2 17/34] staging: wilc1000: remove typedef from the struct tstrWILC_AddStaParam

This patch removes typedef from the struct tstrWILC_AddStaParam and renames it to add_sta_param in oder to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 37 +-- drivers/staging/wilc1000/host_interface.h

[PATCH v2 19/34] staging: wilc1000: remove typedef from the struct tstrHostIfPowerMgmtParam

This patch removes typedef from the struct tstrHostIfPowerMgmtParam and renames it to power_mgmt_param in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff -

[PATCH v2 20/34] staging: wilc1000: remove typedef from the struct tstrHostIfStaInactiveT

This patch removes typedef from the struct tstrHostIfStaInactiveT and renames it to sta_inactive_t in oder to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a

[PATCH v2 18/34] staging: wilc1000: remove typedef from the struct tstrTimerCb

This patch removes typedef from the tstrTimerCb and renames it to timer_cb in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/ho

[PATCH v2 09/34] staging: wilc1000: remove typedef from the struct tstrRcvdNetworkInfo

This patch removes typedef from the struct tstrRcvdNetworkInfo and renames it to rcvd_net_info in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 7 --- drivers/staging/wilc1000/host_interface.h | 6 +++--- 2 files changed,

[PATCH v2 07/34] staging: wilc1000: remove typedef from the struct tstrHostIFscanAttr

This patch removes typedef from the structure tstrHostIFscanAttr and changes the camelcase name, tstrHostIFscanAttr to scan_attr in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 14 +++--- 1 file changed, 7 insertions

[PATCH v2 14/34] staging: wilc1000: remove typedef from the struct tstrHostIFGetChan

This patch removes typedef from the struct tstrHostIFGetChan and renames it to get_channel in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/sta

[PATCH v2 08/34] staging: wilc1000: remove typedef from the struct tstrHostIFconnectAttr

This patch removes typedef from the struct tstrHostIFconnectAttr and renames it to connect_attr to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/s

[PATCH v2 10/34] staging: wilc1000: remove typedef from the struct tstrRcvdGnrlAsyncInfo

This patch removes typedef from the struct tstrRcvdGnrlAsyncInfo and renames it to rcvd_async_info in order to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git

[PATCH v2 11/34] staging: wilc1000: remove typedef from the struct tstrHostIFkeyAttr

This patch removes typedef from the struct tstrHostIFkeyAttr and renames it to key_attr in oder to comply with the Linux coding style. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/s

[PATCH v2 02/34] staging: wilc1000: remove typedef from the struct

The Linux kernel coding style does not recommend to use typedef for the structure. This patch removes typedef from the host_if_msg structure. Signed-off-by: Tony Cho Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wilc1000/host_interface.c | 294 +++--- 1 file chan

[PATCH v2 05/34] staging: wilc1000 remove typedef from the union

This patch gets rid of typedef from the union and renames tuniHostIFmsgBody with simply message_body because the Linux coding style does not recommend camelcase notation and typedef for structure, enmu and also union. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8

[PATCH v2 04/34] staging: wilc1000: rename u16MsgId

This patch changes the name, u16MsgId simply to id to avoid the camelcase notation. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 102 +++--- 1 file changed, 51 insertions(+), 51 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.

[PATCH v2 03/34] staging: wilc1000: rename strHostIFmsg

This patch changes the name, strHostIFmsg simply to msg because the camelcase notation is not recommended in Linux. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 794 +++--- 1 file changed, 397 insertions(+), 397 deletions(-) diff --git a/driver

[PATCH v2 01/34] staging: wilc1000: rename tstrHostIFmsg

This patch changes the name, tstrHostIFmsg to host_if_msg not to use camelcase notation in the Linux. Signed-off-by: Tony Cho Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wilc1000/host_interface.c | 294 +++--- 1 file changed, 147 insertions(+), 147 deletions(-)

[PATCH v2 00/34] resending v2 for the patches of removing typedef

This is the version 2 for the series of the patch that mostly removes the typedef from the structures and renames its names to comply with the Linux coding style. The version 2 is rebased again onto the staging-testing branch to synchronize with the mainstream. Tony Cho (34): stagi

Re: [PATCH 03/34] staging: wilc1000: rename strHostIFmsg

On 2015년 09월 19일 12:00, Greg KH wrote: On Fri, Sep 18, 2015 at 06:11:05PM +0900, Tony Cho wrote: This patch changes the name, strHostIFmsg simply to msg because the camelcase notation is not recommended in Linux. Signed-off-by: Tony Cho Because of the other patches I didn't accept, and I th

Re: [PATCH v2 1/4] staging: wilc1000: fix null check routine

On 2015년 09월 19일 11:50, Greg KH wrote: On Thu, Sep 17, 2015 at 07:02:17PM +0900, Tony Cho wrote: From: Leo Kim This patch removes the potential faults which may happen when unexpectedly getting access to invalid pointer. The pointer of pstrWFIDrv is unlikely to be invalid. However, it is saf

Re: [PATCH 1/2] staging: wilc1000: replace s32Error with result

On Mon, Sep 21, 2015 at 9:52 AM, Chaehyun Lim wrote: > On Mon, Sep 21, 2015 at 9:40 AM, Julian Calaby > wrote: >> Hi Chaehyun, >> >> >> On Mon, Sep 21, 2015 at 10:25 AM, Chaehyun Lim >> wrote: >>> Most of functions use s32Error variable to check error and return its value. >>> This patch repla

Re: [PATCH 1/2] staging: wilc1000: replace s32Error with result

On Mon, Sep 21, 2015 at 9:40 AM, Julian Calaby wrote: > Hi Chaehyun, > > > On Mon, Sep 21, 2015 at 10:25 AM, Chaehyun Lim wrote: >> Most of functions use s32Error variable to check error and return its value. >> This patch replaces s32Error with result to avoid CamelCase. >> >> Signed-off-by: Cha

Re: [PATCH 1/2] staging: wilc1000: replace s32Error with result

Hi Chaehyun, On Mon, Sep 21, 2015 at 10:25 AM, Chaehyun Lim wrote: > Most of functions use s32Error variable to check error and return its value. > This patch replaces s32Error with result to avoid CamelCase. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/coreconfigurator.c

[PATCH 1/2] staging: wilc1000: replace s32Error with result

Most of functions use s32Error variable to check error and return its value. This patch replaces s32Error with result to avoid CamelCase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 40 +- drivers/staging/wilc1000/host_interface.c | 900 ++

[PATCH 2/2] staging: wilc1000: rename SendConfigPkt

This patch replaces SendConfigPkt with send_config_pkt to avoid CamelCase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.c | 4 +- drivers/staging/wilc1000/coreconfigurator.h | 4 +- drivers/staging/wilc1000/host_interface.c | 102 ++-- 3

[PATCH 8/9] staging: rtl8192e: Simplify _rtl92e_calculate_bit_shift

Use ffs instead of iteration. Behaviour of function doesn't change. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi

[PATCH 4/9] staging: rtl8192e: Fix FSF_MAILING_ADDRESS warnings

Remove FSF address from licenses at the beginning of files. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/dot11d.c | 4 drivers/staging/rtl8192e/dot11d.h | 4 drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 4 drivers/stag

[PATCH 7/9] staging: rtl8192e: Remove extra braces

Remove extra braces in _rtl92e_dm_check_tx_power_tracking_thermal. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c index

[PATCH 5/9] staging: rtl8192e: Remove _rtl92e_silent_reset_mesh

Function is empty. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index d4cef20..2e3c25c 100644 --- a/drive

[PATCH 6/9] staging: rtl8192e: Remove _rtl92e_dm_check_pbc_gpio

Function is empty. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c index a2aba40..716a8c9 100644 --- a/drivers/sta

[PATCH 3/9] staging: rtl8192e: Fix CONSTANT_COMPARISON warnings

Remove yoda conditions where pointed by checkpatch. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 6 +++--- drivers/staging/rtl8192e/rtl8192e/rtl_cam.c| 4 ++-- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 4 ++-- drivers/staging/rtl8192e/rtl819x_

[PATCH 9/9] staging: rtl8192e: Merge/Remove _rtl92e_dm_bb_initialgain_backup

Merge rtl92e_dm_backup_state and _rtl92e_dm_bb_initialgain_backup. Static function is called only once and dm_backup_state had short body. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff -

[PATCH 0/9] staging: rtl8192e: Various cleanups

This series contains various cleanups for rtl8192e driver. It will apply cleanly to staging-next/testing only after static function rename series is applied. Series was target tested (although only patches #8 and #9 may affect driver behavior). Patches #2, #8 and #9 generate some checkpatch wa

[PATCH 1/9] staging: rtl8192e: rtl_wx: Fix BRACES warning

Fix checkpatch BRACES warning. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c index 240d765..18dc3

[PATCH 2/9] staging: rtl8192e: Fix SUSPECT_CODE_INDENT warnings

Fix SUSPECT_CODE_INDENT warnings (indentation). Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 4 ++-- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 4 ++-- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 10 +- drivers/staging/rt

[PATCH] staging: lustre: lustre: libcfs: Removed a space

Removed space between function name and open paranthesis detected by checkpatch.pl 112: WARNING: space prohibited between function name and open parenthesis '(' 152: WARNING: space prohibited between function name and open parenthesis '(' 164: WARNING: space prohibited between function name and op

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

On Sat, Sep 19, 2015 at 10:49:52PM +, Weiny, Ira wrote: > > > > On Fri, Sep 18, 2015 at 11:51:09AM -0400, Doug Ledford wrote: > > > On 09/16/2015 02:22 AM, Dan Carpenter wrote: > > > > __get_txreq() returns an ERR_PTR() but this checks for NULL so it > > > > would oops on failure. > > > > > >

[PATCHv3 15/15] staging: rtl8192u: remove all code framed by symbol TO_DO_LIST

The symbol TO_DO_LIST was used in the code to frame sections of code unused or unusable. This patch remove all code framed by that symbol in this driver. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 4 +- drivers/staging/rtl8192u/ieee80211/ieee80211_

[PATCHv3 14/15] staging: rtl8192u: r8192U_core: replace else { if() {} } by else if () {}

An else block only contained an if statement. Replace that else block by an else if block instead. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b

[PATCHv3 12/15] staging: rtl8192u: r8192U_core: rtl8192_tx: replace some inline conditions

Replace some inline conditions by a full if-else statement to make the source clearer and follow the 80 characters kernel code style rule. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --gi

[PATCHv3 13/15] staging: rtl8192u: r8192U_core: rtl8192_ioctl: reorganize function

Reorganize function rtl8192_ioctl to replace a switch with only one case besides the default by an if statement. This also allows to follow the 80 characters kernel code style rule. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 141 -

[PATCHv3 09/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: remove unneeded variable

Local variable last_beacon_adc_pwdb was used to store a value that wasn't used after. This patch removes that variable. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/r81

[PATCHv3 10/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable rfpath to rfp

Rename variable to a shorter name to allow easier code refactoring in following patches. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192

[PATCHv3 11/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: reorganize function

Reorganize function to make it cleaner, and respect the 80 characters kernel code style rule. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 140 +++-- 1 file changed, 81 insertions(+), 59 deletions(-) diff --git a/drivers/staging/rtl819

[PATCHv3 08/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable slide_beacon_adc_pwdb_statistics to sb_stats

Rename variable to a shorter name to allow easier code refactoring in following patch. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/

[PATCHv3 06/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable pprevious_stats to prev_stats

Rename variable to a shorter name to allow easier code refactoring in following patch. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 84 +- 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/drivers/staging/rtl8192u/r819

[PATCHv3 05/15] staging: rtl8192u: r8192U_core: rtl8192_read_eeprom_info: reorganize function

Refactor code to avoid multiple check of same boolean value, and to make the code clearer. This patches also implements the necessary changes for the code lines in this function to be under 80 chars. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 259 +++

[PATCHv3 07/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable slide_beacon_adc_pwdb_index to sb_index

Rename variable to a shorter name to allow easier code refactoring in following patch. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/sta

[PATCHv3 04/15] staging: rtl8192u: r8192U_core: rtl8192_adapter_start: reorganize function

Reverse conditions and use goto in the function rtl8192_adapter_start to have most of it under 80 characters per line. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 91 ++ 1 file changed, 47 insertions(+), 44 deletions(-) diff --git

[PATCHv3 00/15] staging: rtl8192u: code clean up

Hi, Following Greg's comments on the previous version, here's an updated and rebased one without the already committed patch. Difference with v2: - Some line breaks were removed as it was less readable with them (patch 01) - A temporary variable has been created instead of reusing an exis

[PATCHv3 02/15] staging: rtl8192u: r8192U_core: add temporary variables to keep lines under 80 characters

Add some temporary variables to reduce line length under the maximum of 80 characters, as per the kernel code style. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 139 ++--- 1 file changed, 94 insertions(+), 45 deletions(-) diff --git a

[PATCHv3 01/15] staging: rtl8192u: r8192U_core: add line breaks to keep lines under 80 characters

Add line breaks in multiple lines to keep them under 80 characters, as to follow the kernel code style. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 608 ++--- 1 file changed, 409 insertions(+), 199 deletions(-) diff --git a/drivers/st

[PATCHv3 03/15] staging: rtl8192u: r8192U_core: reverse conditions to get lines under 80 characters

Reverse some conditions to clean the code and allow to have lines under 80 characters, as to follow the kernel code style. Signed-off-by: Raphaël Beamonte --- drivers/staging/rtl8192u/r8192U_core.c | 48 ++ 1 file changed, 25 insertions(+), 23 deletions(-) diff -

[PATCH] staging: lustre: lustre: libcfs: Added a blank line

Added a blank line after declaration. Coding style warning detected by checkpatch.pl WARNING: Missing a blank line after declarations Signed-off-by: Anjali Menon --- drivers/staging/lustre/lustre/libcfs/module.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/l

[PATCH] staging/rdma/hfi1: do not use u8 to store a 32-bit integer

hfi1_rc_hdrerr() stores the result of be32_to_cpu() into opcode, which is a local variable declared as u8. Later this variable is used in a 24-bit logical right shift, which makes clang complains (when building an allmodconfig kernel with LLVMLinux patches): drivers/staging/rdma/hfi1/rc.c:239

[PATCH] Staging: rtl8712: Coding style warning fix for block comment

This is a patch to mlme_linux.c that fixes up following warning reported by checkpatch.pl : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/mlme_linux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/stagi

Re: [PATCH] Staging: comedi: Fix coding style issues

On Sun, Sep 20, 2015 at 6:50 AM, Jaime Arrocha wrote: > > On 09/19/2015 01:13 PM, punit vara wrote: >> >> [PATCH] Staging: comedi: Fix block comment warning > > > [PATCH] Staging: comedi: Coding style warnings fix for block comments > Thank you for suggestion sir .I would appreciate your help. _

[PATCH 168/192] staging: rtl8192e: Rename dm_EndHWFsync

Use naming schema found in other rtlwifi devices. Rename dm_EndHWFsync to _rtl92e_dm_end_hw_fsync. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c

[PATCH 166/192] staging: rtl8192e: Rename dm_dig_init

Use naming schema found in other rtlwifi devices. Rename dm_dig_init to _rtl92e_dm_dig_init. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/dr

  1   2   3   >