Greg,
On Sun, Jan 18, 2015 at 04:02:22PM +0900, Greg KH wrote:
> On Sat, Jan 17, 2015 at 10:41:44PM -0800, Tristan Lelong wrote:
> > Hi Greg,
> >
> > On Sat, Jan 17, 2015 at 03:28:27PM -0800, Greg KH wrote:
> > >
> > > I took your v2 version, please send me the difference as this is a
> > > mess
Fixed the following warnings (reported by cppcheck):
[drivers/staging/iio/impedance-analyzer/ad5933.c:363]: (warning) %d in format
string (no. 1)
requires 'int' but the argument type is 'unsigned int'.
[drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format
string (no. 1)
re
Checkpatch doesn't like kmalloc with multiply very much:
drivers/staging/comedi/drivers/das1800.c:1377: WARNING: Prefer kmalloc_array
over kmalloc with multiply
So this patch swaps that use out for kmalloc_array instead.
Signed-off-by: Chase Southwood
---
drivers/staging/comedi/drivers/das1800
On 01/19/2015 03:47 PM, Lee Jones wrote:
> On Mon, 19 Jan 2015, 敬锐 wrote:
>> >On 01/18/2015 08:29 PM, Lee Jones wrote:
>>> > >On Thu, 15 Jan 2015,[email protected] wrote:
>>> > >
> >>From: Micky Ching
> >>
> >>update phy register value and using direct value instead of mac
On Monday, January 19, 2015 at 09:30:47 PM, Kristina Martšenko wrote:
> On 18/01/15 13:21, Stefan Wahren wrote:
> > Hi Kristina,
>
> Hi Stefan!
Hi all,
[...]
> > i have a iMX233-Olinuxino-MAXI, but no touchscreen. If it does make sense
> > to you, could you please send me testing instructions a
On Monday, January 19, 2015 at 08:02:03 PM, Kristina Martšenko wrote:
> On 18/01/15 02:19, Marek Vasut wrote:
> > On Saturday, January 17, 2015 at 01:22:08 AM, Kristina Martšenko wrote:
> >
> > Hi!
>
> Hi!
Hi!
> > Good stuff, thank you! Just minor nitpicks below.
> >
> > [...]
> >
> >> diff -
Prezado usuário
Seu e-mail excedeu 2GB criado pelo webmaster, que atualmente
rodando a 2,30 GB, que não é possível enviar ou receber mensagem nova
dentro das próximas 24 horas, até que tenha certeza que você conta de e-mail.
Por favor, digite seus dados abaixo para verificar a sua conta:
(1) e-m
On 18/01/15 13:21, Stefan Wahren wrote:
> Hi Kristina,
Hi Stefan!
>> Kristina Martšenko hat am 17. Januar 2015 um
>> 01:22 geschrieben:
>> These patches fix some issues with using the touchscreen and reading
>> other ADC channels at the same time.
>>
>> The main issue is that the "virtual" chann
On 19/01/15 09:57, Marek Vasut wrote:
> On Monday, January 19, 2015 at 08:20:31 AM, Juergen Borleis wrote:
>> On Saturday 17 January 2015 01:22:10 Kristina Martšenko wrote:
>>> Reading a channel through sysfs, or starting a buffered capture, can
>>> occasionally turn off the touchscreen.
>>> [...]
On 18/01/15 02:21, Marek Vasut wrote:
> On Saturday, January 17, 2015 at 01:22:09 AM, Kristina Martšenko wrote:
>> Reading a channel through sysfs, or starting a buffered capture, will
>> currently turn off the touchscreen. This is because the read_raw() and
>> buffer preenable()/postdisable() call
On 18/01/15 02:19, Marek Vasut wrote:
> On Saturday, January 17, 2015 at 01:22:08 AM, Kristina Martšenko wrote:
>
> Hi!
Hi!
> Good stuff, thank you! Just minor nitpicks below.
>
> [...]
>
>> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
>> b/drivers/staging/iio/adc/mxs-lradc.c index e0e91836
On Mon, Jan 19, 2015 at 08:58:58PM +0300, Dan Carpenter wrote:
> "error" is a crap label name because it doesn't tell you what the code
> does. A better name is "err_free_chan" or something which talks about
> freeing the channel.
If you choose your label names correctly, then most of the time yo
On Mon, Jan 19, 2015 at 05:56:11PM +0100, Vitaly Kuznetsov wrote:
> vmbus_device_create() result is not being checked in vmbus_process_offer() and
> it can fail if kzalloc() fails. Add the check and do minor cleanup to avoid
> additional duplication of "free_channel(); return;" block.
>
> Reported
This patch fixes the checkpatch.pl warning:
WARNING: space prohibited before semicolon
Signed-off-by: Peter Poklop
---
v2: Commit message cleanup
drivers/staging/rtl8723au/os_dep/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/os_dep/os_
sc_lock spinlock in struct vmbus_channel is being used to not only protect the
sc_list field, e.g. vmbus_open() function uses it to implement test-and-set
access to the state field. Rename it to the more generic 'lock' and add the
description.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/chann
Commit 4b2f9abea52a ("staging: hv: convert channel_mgmt.c to not call
osd_schedule_callback")' was written under an assumption that we never receive
Rescind offer while we're still processing the initial Offer request. However,
the issue we fixed in 04a258c162a8 could be caused by this assumption n
vmbus_device_create() result is not being checked in vmbus_process_offer() and
it can fail if kzalloc() fails. Add the check and do minor cleanup to avoid
additional duplication of "free_channel(); return;" block.
Reported-by: Jason Wang
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/channel_mg
This patch series is a successor of "[PATCH] Drivers: hv: vmbus: serialize
Offer and Rescind offer processing" and thereby have 'v2' in its name.
Changes from v1:
- Separate vmbus_device_create() return value check [K. Y. Srinivasan]
- Do not lose a rescind offer received during offer processing.
The hardware range code values and list of valid ranges for the AI
subdevice is incorrect for several supported boards. The hardware range
code values for all boards except PCI-DAS4020/12 is determined by
calling `ai_range_bits_6xxx()` based on the maximum voltage of the range
and whether it is bi
This patch fixes the following checkpatch.pl error:
fix space prohibited before that ','
Signed-off-by: Mohamed Lotfy Hammad
---
drivers/staging/vt6655/mac.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index e1e7
On Sun, Jan 18, 2015 at 09:55:50AM +, Ben Hutchings wrote:
> On Sat, 2015-01-17 at 23:57 -0800, Shirish Gajera wrote:
> > This patch fixes the checkpatch.pl warning:
> >
> > WARNING: line over 80 characters
> >
> > All line over 80 characters in driver/staging/speakup/* are fixed
> [...]
>
>
Generally this patch is fine. There were a couple places which weren't
perfect.
On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
> + if ((spk_bleeps & 2) && (msg_id < edge_quiet)) {
> + synth_printf("%s\n",
> + spk_msg_get(MSG_EDGE_MSGS_START + msg_id -
On Sun, Jan 18, 2015 at 09:29:21AM +0100, Robin Schroer wrote:
> On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
> > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> > index e9f0c15..141abb7 100644
> > --- a/drivers/staging/speakup/main.c
> > +++ b/driv
This patch fixes the following checkpatch.pl error:
fix space prohibited before that ','
Signed-off-by: Ahmad Hassan
---
v2: adjusted From name field
v3: added description message
drivers/staging/vt6655/device_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/st
On Mon, Jan 19, 2015 at 01:05:52PM -0900, Ahmad Hassan wrote:
> ---
> drivers/staging/vt6655/device_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Something went really wrong with your subject line :(
___
devel mailing list
de...@linuxdr
---
drivers/staging/vt6655/device_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655/device_main.c
index f5cc78e..34e3a76 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_mai
Den 18.01.2015 23:37, skrev Greg KH:
On Sun, Jan 18, 2015 at 01:00:31PM +0100, Noralf Tronnes wrote:
Den 18.01.2015 03:54, skrev Greg KH:
On Sun, Jan 18, 2015 at 03:26:56AM +0100, Noralf Tronnes wrote:
When I started this rewrite I didn't anticipate fbtft entering the kernel,
and to me it was
On 18/01/15 11:53, Nicholas Mc Guire wrote:
The if and the else branch code are identical - so the condition has no
effect on the effective code - this patch removes the condition and the
duplicated code.
Signed-off-by: Nicholas Mc Guire
---
Patch is against 3.19.0-rc4 -next-20150116
This pat
This patch fixes the following checkpatch.pl error:
fix space prohibited before that ','
Signed-off-by: Mohamed Lotfy Hammad
---
drivers/staging/vt6655/mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
index 63c9
This patch fixes the following checkpatch.pl error:
fix space prohibited before that ','
Signed-off-by: Heba Aamer
---
v2: added Signed-off line
drivers/staging/vt6655/mac.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt
On Thu, 15 Jan 2015, Roger Tseng wrote:
> A card insertion happens after the lastest polling before reader is
> suspended may never have a chance to be detected. Under current 1-HZ
> polling interval setting in mmc_core, the worst case of such
> undetectablility is about 1 second.
>
> To further
On Thu, 15 Jan 2015, Roger Tseng wrote:
> sd_set_power_mode() in derived module drivers/mmc/host/rtsx_usb_sdmmc.c
> acquires dev_mutex and then calls pm_runtime_get_sync() to make sure the
> device is awake while initializing a newly inserted card. Once it is
> called during suspending state and e
checkpatch cleanup to add missing blank line after declaration
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm7xxfb/sm7xxfb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers/staging/sm7xxfb/sm7xxfb.c
index c550b71..6bce9f1 100644
--- a/dri
checkpatch cleanup: alignment should match open parenthesis
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm7xxfb/sm7xxfb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers/staging/sm7xxfb/sm7xxfb.c
index 097747c..2ae9fd0
checkpatch cleanup: blank lines are not necessary before closing brace
and after opening brace.
Signed-off-by: Sudip Mukherjee
---
these are actually two different checkpatch warning, but am sending
them together as they are of similar type.
drivers/staging/sm7xxfb/sm7xxfb.c | 4
1 file c
add myself and Teddy Wang as the Maintainer of the
SM7XX FRAME BUFFER DRIVER.
Signed-off-by: Sudip Mukherjee
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index dbc17b3..4fd647e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9220,6 +9220,14
update the email addresses in the TODO file, also update the final
destination of this driver.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm7xxfb/TODO | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm7xxfb/TODO b/drivers/staging/sm7xxfb/TODO
checkpatch cleanup: space is not necessary after cast
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm7xxfb/sm7xxfb.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers/staging/sm7xxfb/sm7xxfb.c
index 6bce9f1..6f0469
This reverts commit "dc93c85235efa5201e9a3c116bc3fbd1afc1a182"
Signed-off-by: Sudip Mukherjee
---
v2: checkpatch cleanup has been added to the series.
after this series CamelCase is the only pending style related issue.
i have two doubts:
1) will it be easier if i have a git tree somewhere?
2)
On Mon, 19 Jan 2015, 敬锐 wrote:
>
> On 01/18/2015 08:28 PM, Lee Jones wrote:
> > On Thu, 15 Jan 2015, [email protected] wrote:
> >
> >> From: Micky Ching
> >>
> >> To enable/disable ASPM we should find LINK CONTROL register
> >> in PCI config space. All old chip use 0x80 address, but new
40 matches
Mail list logo
