On Thu, May 29, 2014 at 09:17:09AM +0900, DaeSeok Youn wrote:
> Hi, Dan.
>
> 2014-05-28 19:11 GMT+09:00 Dan Carpenter :
> > On Wed, May 28, 2014 at 06:29:38PM +0900, DaeSeok Youn wrote:
> >> > In your patch it has:
> >> > + dgap_tty_uninit(brd, false);
> >> >
> >> > But it should only be "fa
Fixed a misplaced brace in the r8192_wx_set_scan_type function.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 1af7c
Added a space around '|' to address:
ERROR: need consistent spacing around '|' (ctx:VxW)
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u
Removed dead code, commented out printks and DMESG.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 675a12d..7dc2a96 100644
Removed dead code from the file.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 09b1e81..f2c970e 100644
--- a/drivers/
To address the error -
ERROR: do not use C99 // comments
Removed all C99 comments.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 130 +--
1 file changed, 65 insertions(+), 65 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192
Hi, Dan.
2014-05-28 19:11 GMT+09:00 Dan Carpenter :
> On Wed, May 28, 2014 at 06:29:38PM +0900, DaeSeok Youn wrote:
>> > In your patch it has:
>> > + dgap_tty_uninit(brd, false);
>> >
>> > But it should only be "false" if dgap_tty_init() failed. If
>> > dgap_tty_register_ports() fails then
Cleanup the existing defines and add some missing bit defines.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adq12b.c | 32 +---
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/drivers/stagi
For aesthetics, add some whitespace to the subdevice init.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adq12b.c | 52 -
1 file changed, 25 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/
This member of the private data is only used during the attach to
determine if there are 8 differential or 16 single-ended analog
inputs. Remove the member and use the comedi_devconfig option
directly.
Also, fix the subdev_flags when differential analog inputs are used.
Signed-off-by: H Hartley S
This driver does not support async commands so the len_chanlist init is
unnecessary. Remove it and allow the core to default the value to '1'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adq12b.c | 3 ---
1 file changed, 3 deletions
This define is only used in the comedi_request_region() call to
specify the I/O resource size. Remove it and just open code the
value.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adq12b.c | 4 +---
1 file changed, 1 insertion(+), 3
This driver only updates the ctreg (ai channel/range) register if the
desired channel or range has changed since the last analog input read
operation. It does this becuase the hardware requires an udelay to
allow the multiplexor to settle. Unfortunatly the current code never
updates the 'last_chann
ok will send a new one out soon.
Thanks for looking into this and sorry about the repetition.
Chaitanya
On Wed, May 28, 2014 at 4:36 PM, Greg KH wrote:
> On Wed, May 28, 2014 at 04:23:48PM -0700, Chaitanya Hazarey wrote:
>> Removed dead code
>> Deleted stray newlines
>> Added newlines for bette
For aesthetics, rename this function.
Clean up the local variables by reusing 'val' instead of using
separate variables for the:
'status' - use once to trigger the first A/D conversion
'hi' and 'lo' - used to read the A/D conversion result
For aesthetics, change the final return to insn->n an
This member of the private data is only used during the attach to
determine which range table to use for the analog inputs. Remove
the member and use the comedi_devconfig option directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/
Cleanup this driver and remove the unnecessary private data members.
H Hartley Sweeten (8):
staging: comedi: adq12b: fix ctreg (ai channel/range) programming
staging: comedi: adq12b: tidy up adq12b_ai_rinsn()
staging: comedi: adq12b: remove 'unipolar' from private data
staging: comedi: adq
The (*attach) in ni_E_init() sets the dev->write_subdev to the analog
output subdevice. Use that instead of accessing the dev->subdevices
array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 6 +++---
1 file
On Wed, May 28, 2014 at 04:23:48PM -0700, Chaitanya Hazarey wrote:
> Removed dead code
> Deleted stray newlines
> Added newlines for better code readability
These should all be broken up into individual patches.
Remember, each patch should just do _one_ thing.
thanks,
greg k-h
_
Absorb the helper functions that handle the INSN_CONFIG_SET_CLOCK_SRC and
INSN_CONFIG_GET_CLOCK_SRC comedi instructions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 67 ++
1 file changed, 26
The (*attach) in ni_E_init() sets the dev->read_subdev to the analog
input subdevice. Use that instead of accessing the dev->subdevices
array directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 16 ---
The (*insn_write) functions are supposed to write insn->n data values and
return the number of values written. For this subdevice it only makes sense
to write the last data value.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_c
The (*insn_read) functions are supposed to "read" insn->n data values and
return the number of values read.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-
I have not determined if the code in these functions is actually
usable. For now just move the disabled code closer to the working
gpct functions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 177 ---
Move ni_cdio_cmd() to remove the need for the forward declaration
of ni_cdo_inttrig().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 80 +-
1 file changed, 39 insertions(+), 41 deletions(-)
d
Move ni_set_master_clock() and its helper functions to remove the need
for the forward declaration.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 395 -
1 file changed, 197 insertions(+), 198
Move ni_ai_insn_read() to remove the need for a forward declaration.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 201 -
1 file changed, 100 insertions(+), 101 deletions(-)
diff --git a/driv
Move ni_E_interrupt() to remove the need for some forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 130 +++--
1 file changed, 59 insertions(+), 71 deletions(-)
diff --git a/dri
Move ni_ai_insn_config() to remove the need for a forward declaration.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 115 -
1 file changed, 55 insertions(+), 60 deletions(-)
diff --git a/driv
Move shutdown_ai_command() to remove the need for the forward
declaration.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 31 +-
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/
Move ni_ai_inttrig() to remove the need for the forward declaration.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 36 --
1 file changed, 17 insertions(+), 19 deletions(-)
diff --git a/driver
Move ni_rtsi_insn_config() and its helper functions to remove the need
for the forward declaration.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 333 -
1 file changed, 165 insertions(+), 168
Move ni_rtsi_init() to remove the need for the forward declaration.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 86 --
1 file changed, 40 insertions(+), 46 deletions(-)
diff --git a/drivers
Move some functions to remove the need for the remaining forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 513 -
1 file changed, 253 insertions(+), 260 deletions(-)
diff --
This source file is included by the ni_atmio, ni_mio_cs, and ni_pcmio
drivers to support the common hardware on National Instruments DAQ-STC
based boards.
The only functions actually used by the external source files are
ni_E_interrupt(), ni_alloc_private(), ni_E_init(), and mio_common_detach().
T
Move the get_last_sample_*() helpers to remove the need for the forward
declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 84 +-
1 file changed, 41 insertions(+), 43 deletions(-)
di
Move ni_serial_insn_config() to remove the need for some forward
declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 192 -
1 file changed, 92 insertions(+), 100 deletions(-)
diff --g
These forward declarations are not needed.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c
b/drivers/sta
Move ni_ai_drain_dma() to remove the need for the forward declaration.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 73 --
1 file changed, 35 insertions(+), 38 deletions(-)
diff --git a/driv
Remove the need for the forward declaration of ni_cdio_cancel() by
indirectly calling it using the subdevice (*cancel).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 4 +---
1 file changed, 1 insertion(+), 3 deletion
Move the cs5529 calibration subdevice functions and helpers to remove
the need for the forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 280 -
1 file changed, 136 insertions
Move the programmable function inputs subdevice functions and helpers
to remove the need for the forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 372 -
1 file changed, 179
Move the calibration subdevice functions and helpers to remove the need
for the forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 365 -
1 file changed, 177 insertions(+), 18
Move the ni_gpct_cmd() and ni_gpct_cancel() functions to remove the
need for the forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 68 --
1 file changed, 31 insertions(+), 37
Move ni_rtsi_insn_bits() to remove the need for the forward declaration.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/driver
Move the caldac "packbits" callbacks to remove the need for the forward
declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 101 -
1 file changed, 47 insertions(+), 54 deletions(-)
di
Move the eeprom read functions to remove the need for the forward
declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 110 +++--
1 file changed, 47 insertions(+), 63 deletions(-)
diff --g
Remove all the forward declarations and do a bit of cleanup to this
file.
H Hartley Sweeten (31):
staging: comedi: ni_mio_common: remove forward declaration 1
staging: comedi: ni_mio_common: remove forward declaration 2
staging: comedi: ni_mio_common: remove forward declaration 3
staging:
Move the pwm config functions to remove the need for the forward
declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 295 -
1 file changed, 145 insertions(+), 150 deletions(-)
diff --
Move ni_8255_callback() to remove the need for the forward declaration.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 28 --
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/dri
Removed dead code
Deleted stray newlines
Added newlines for better code readability
Addressed the following errors:
ERROR: do not use C99 // comments
ERROR: need consistent spacing around '|' (ctx:VxW)
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 155
Fixed a misplaced brace in a function
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 1af7c5d..675a12d 100644
--- a/d
Please ignore this patch, there seems something wrong with it, will
resend with a new subject.
Thanks,
Chaitanya
On Wed, May 28, 2014 at 4:17 PM, Chaitanya Hazarey wrote:
> Removed dead code
> Deleted stray newlines
> Added newlines for better code readability
>
> Addressed the following errors
Please ignore this patch, there seems something wrong with it, will
resend with a new subject.
Thanks,
Chaitanya
On Wed, May 28, 2014 at 4:17 PM, Chaitanya Hazarey wrote:
> Fixed a misplaced brace in a function
>
> Signed-off-by: Chaitanya Hazarey
> ---
> drivers/staging/rtl8192u/r8192U_wx.c
Fixed a misplaced brace in a function
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 1af7c5d..675a12d 100644
--- a/d
Removed dead code
Deleted stray newlines
Added newlines for better code readability
Addressed the following errors:
ERROR: do not use C99 // comments
ERROR: need consistent spacing around '|' (ctx:VxW)
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 155
The Subject: here is not really that descriptive, I've fixed it up when
committing it. Try to be a bit better for your next patch.
thanks,
greg k-h
___
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/lis
On Wed, May 28, 2014 at 07:32:39AM -0700, Chaitanya Hazarey wrote:
> -static int r8192_wx_set_scan_type(struct net_device *dev, struct
> iw_request_info *aa, union
> - iwreq_data *wrqu, char *p){
> +static int r8192_wx_set_scan_type(struct net_device *dev, struc
On Wed, May 28, 2014 at 06:52:51PM +1000, Scott Weir wrote:
> This patch corrects coding style issue:
> WARNING: Missing a black line after declarations
>
> Signed-off-by: Scott Weir
> ---
> drivers/staging/android/sync_debug.c | 4
This file isn't in my tree. Always work against linux-nex
On Wed, May 28, 2014 at 04:42:27PM +, Hartley Sweeten wrote:
> On Wednesday, May 28, 2014 3:22 AM, Ian Abbott wrote:
> > On 2014-05-27 18:31, H Hartley Sweeten wrote:
> >> THe comedi core ensures that the chanlist will be valid for any async
> >> operation
> >> other than Step 1 of the (*do_cm
On Mon, May 26, 2014 at 04:19:39PM +0200, Philipp Zabel wrote:
> The i.MX Image Processing Unit (IPU) contains a number of image processing
> blocks that sit right in the middle between DRM and V4L2. Some of the modules,
> such as Display Controller, Processor, and Interface (DC, DP, DI) or CMOS
>
Replaces ENXIO with EIO errno
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dgap.c | 44 ++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index
Simplify ugly dgap_find_config function
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 84 +++--
1 file changed, 43 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/dgap/dgap
refactors NULL conditionals
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
Tested-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 64 ++---
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers
On 05/27/2014 11:52 PM, Heesub Shin wrote:
> Hi,
>
> Here is my patchset with some modification, hoping reviews or comments
> from you guys.
>
> v2:
> o No changes in the code, just reworded changelog
> o Reorder patch
Ran this through Colin's ion-unit-tests and saw no changes in the
results on
The major number for comedi has been listed in Documentation/devices.txt
since kernel 2.1.88.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/TODO b/drivers/staging/
On Wednesday, May 28, 2014 3:22 AM, Ian Abbott wrote:
> On 2014-05-27 18:31, H Hartley Sweeten wrote:
>> THe comedi core ensures that the chanlist will be valid for any async
>> operation
>> other than Step 1 of the (*do_cmdtest) to get the trigger source masks.
>>
>> Remove the unnecessary checks
On Tue, May 27 2014 at 11:52:51 PM, Heesub Shin wrote:
> Hi,
>
> Here is my patchset with some modification, hoping reviews or comments
> from you guys.
>
> v2:
> o No changes in the code, just reworded changelog
> o Reorder patch
Some very nice cleanup. And I learned a new trick with page.lru
On 05/28/2014 09:17 AM, Greg KH wrote:
On Wed, May 28, 2014 at 06:01:17AM -0500, Ken Cox wrote:
On 05/23/2014 06:18 AM, Greg KH wrote:
On Thu, May 22, 2014 at 12:31:08PM -0500, Ken Cox wrote:
This series of patches cleans up the unisys driver code in various ways:
-fix sparse warnin
On Wed, May 28, 2014 at 12:32 AM, Greg KH wrote:
> On Tue, May 27, 2014 at 09:05:43PM +0530, navin patidar wrote:
>> Signed-off-by: navin patidar
>> ---
>> drivers/staging/rtl8712/osdep_service.h |6 --
>> 1 file changed, 6 deletions(-)
>
> This is the rtl8712 driver, not the rtl8188eu d
A sparse error fixup removed a htons() which is required for the driver
to function. This patch puts the htons() back and fixes the sparse
warning correctly by changing the left side cast.
Signed-off-by: Sean MacLennan
---
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c
b/drivers/staging/rtl819
Added {} braces and newlines to address the following:
ERROR: else should follow close brace '}'
ERROR: space required before the open brace '{'
ERROR: trailing statements should be on next line
ERROR: space required before the open parenthesis '('
ERROR: that open brace { should be on the previou
Added spaces needed in the proper places to address:
WARNING: please, no spaces at the start of a line
WARNING: missing space after struct definition
ERROR: spaces required around that '!=' (ctx:WxV)
ERROR: spaces required around that '=' (ctx:WxV)
ERROR: spaces required around that '=' (ctx:VxW)
On Wed, May 28, 2014 at 10:14:03AM -0400, Mark Hounschell wrote:
> Is that TODO-list going to be commited?
The TODO-list is a new thing. People are always complaining that there
isn't a TODO-list with task for people to do. Now I can just search my
inbox and generate one automatically. Fancy, h
On Wed, May 28, 2014 at 06:01:17AM -0500, Ken Cox wrote:
>
> On 05/23/2014 06:18 AM, Greg KH wrote:
> > On Thu, May 22, 2014 at 12:31:08PM -0500, Ken Cox wrote:
> >> This series of patches cleans up the unisys driver code in various ways:
> >> -fix sparse warnings related to accessing I/O
On 05/28/2014 06:11 AM, Dan Carpenter wrote:
> On Wed, May 28, 2014 at 06:29:38PM +0900, DaeSeok Youn wrote:
>>> In your patch it has:
>>> + dgap_tty_uninit(brd, false);
>>>
>>> But it should only be "false" if dgap_tty_init() failed. If
>>> dgap_tty_register_ports() fails then it should be
added newlines after declarations in two places
Signed-off-by: Robin Schroer
---
drivers/staging/frontier/tranzport.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/frontier/tranzport.c
b/drivers/staging/frontier/tranzport.c
index 334ba04..2f86163 100644
--- a/drivers/sta
26.05.2014 23:27, Aaro Koskinen пишет:
> On Fri, May 23, 2014 at 11:17:18AM +0400, Sergey Popov wrote:
On Sat, Mar 22, 2014 at 01:13:52PM +0400, Sergey Popov wrote:
> scsi 0:0:0:0: Direct-Access SanDisk Cruzer Facet 1.26 PQ: 0
> ANSI: 5
> sd 0:0:0:0: [sda] 15633408 512-by
Casting value returned by k[cmz]alloc is useless.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8723au/core/rtw_sta_mgt.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_sta_mgt.c
b/drivers/staging/rtl8723au/core/rtw_sta_mgt.c
index
Casting value returned by k[cmz]alloc is useless.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8723au/hal/usb_ops_linux.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/usb_ops_linux.c
b/drivers/staging/rtl8723au/hal/usb_ops_linux.c
Casting value returned by k[cmz]alloc is useless.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8723au/core/rtw_wlan_util.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c
b/drivers/staging/rtl8723au/core/rtw_wlan_util
Casting value returned by k[cmz]alloc is useless.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8723au/core/rtw_xmit.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c
b/drivers/staging/rtl8723au/core/rtw_xmit.c
index d0
Casting value returned by k[cmz]alloc is useless.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
b/drivers/staging/rtl8723au/hal/rtl8723a_h
Casting value returned by k[cmz]alloc is useless.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8723au/core/rtw_recv.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c
b/drivers/staging/rtl8723au/core/rtw_recv.c
index f21aa2
Casting value returned by k[cmz]alloc is useless.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8723au/core/rtw_mlme.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c
b/drivers/staging/rtl8723au/core/rtw_mlme.c
index 547
wlan_bssdef.h was included twice.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8723au/include/drv_types.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/include/drv_types.h
b/drivers/staging/rtl8723au/include/drv_types.h
index 49add5f..a94857d 100644
--- a
version.h inclusion is not needed as detected by versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8188eu/os_dep/xmit_linux.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c
b/drivers/staging/rtl8188eu/os_dep/xmit_linux.c
index
On 05/23/2014 06:18 AM, Greg KH wrote:
On Thu, May 22, 2014 at 12:31:08PM -0500, Ken Cox wrote:
This series of patches cleans up the unisys driver code in various ways:
-fix sparse warnings related to accessing I/O space
-fix sparse warnings related to dereferencing noderef ty
On 2014-05-27 15:38, Marcin Kostrzewa wrote:
Signed-off-by: Marcin Kostrzewa
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Te
On 2014-05-27 18:30, H Hartley Sweeten wrote:
This series continues the cleanup of the comedi driver async command support.
H Hartley Sweeten (38):
staging: comedi: usbdux: remove 'ai_continuous' from private data
staging: comedi: usbdux: remove 'ao_continuous' from private data
staging
On 2014-05-27 18:31, H Hartley Sweeten wrote:
THe comedi core ensures that the chanlist will be valid for any async operation
other than Step 1 of the (*do_cmdtest) to get the trigger source masks.
Remove the unnecessary checks.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-H
On Wed, May 28, 2014 at 06:29:38PM +0900, DaeSeok Youn wrote:
> > In your patch it has:
> > + dgap_tty_uninit(brd, false);
> >
> > But it should only be "false" if dgap_tty_init() failed. If
> > dgap_tty_register_ports() fails then it should be "true". Another
> Yes, you're right. There wer
On 2014-05-27 18:30, H Hartley Sweeten wrote:
The calculation for the total number of bytes in the DMA transfer
is incorrect. Fix it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
Nice catch!
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Tel: +44 (0)161 4
Hi, Dan
Please look at below my line comment.
2014-05-28 16:02 GMT+09:00 Dan Carpenter :
> We are talking about different things I think. What I'm saying is that
> there is the normal way to do error handling in the kernel. That's with
> a series of labels like this:
>
> ...
> r
This patch corrects coding style issue:
WARNING: Missing a black line after declarations
Signed-off-by: Scott Weir
---
drivers/staging/android/sync_debug.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/android/sync_debug.c
b/drivers/staging/android/sync_debug.c
index 0
We are talking about different things I think. What I'm saying is that
there is the normal way to do error handling in the kernel. That's with
a series of labels like this:
...
return 0;
err_free_ttys:
free_ttys();
err_free_channels:
free_channels();
err_free_brd
96 matches
Mail list logo
