2013/5/17 Robert Love :
> On Thu, May 16, 2013 at 1:19 PM, Andrew Morton
> wrote:
>> On Thu, 16 May 2013 13:08:17 -0400 Robert Love wrote:
>>> This problem seems a rare proper use of mutex_trylock.
>>
>> Not really. The need for a trylock is often an indication that a
>> subsystem has a locking
This is a patch to lvfs_linux.c that removes the use of variable assignment
within an if condition found by checkpatch.pl.
Signed-off-by: Jon Bernard
---
drivers/staging/lustre/lustre/lvfs/lvfs_linux.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/stagi
On 09/16/2013 05:05 PM, Dan Carpenter wrote:
> On Mon, Sep 16, 2013 at 04:49:29PM -0400, Joseph Salisbury wrote:
>> On 09/16/2013 04:38 PM, Dan Carpenter wrote:
>>> On Mon, Sep 16, 2013 at 01:42:35PM -0400, Joseph Salisbury wrote:
Reverting the patch changes the driver back to useing kzalloc()
On Mon, Sep 16, 2013 at 05:53:57PM -0400, Mike Snitzer wrote:
> - variable names need to be a bit more verbose (arr => array)
"struct array " is a horrible name. :P Please don't use either "arr"
or "array".
regards,
dan carpenter
___
devel mailing li
On Mon, Sep 16, 2013 at 09:55:44PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Dan Carpenter [mailto:[email protected]]
> > Sent: Monday, September 16, 2013 1:13 PM
> > To: KY Srinivasan
> > Cc: [email protected]; [email protected]; [email protected]; D
On Mon, Sep 16, 2013 at 06:29:45PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Dmitry Torokhov [mailto:[email protected]]
> > Sent: Monday, September 16, 2013 10:10 AM
> > To: KY Srinivasan
> > Cc: Dan Carpenter; [email protected]; [email protected];
> >
> -Original Message-
> From: Dan Carpenter [mailto:[email protected]]
> Sent: Monday, September 16, 2013 2:59 PM
> To: KY Srinivasan
> Cc: Haiyang Zhang; [email protected]
> Subject: [patch] hv: vmbus: fix vmbus_recvpacket_raw() return code
>
> Don't return success if t
On Sun, Sep 01 2013 at 7:10am -0400,
Akira Hayakawa wrote:
> This patch introduces dm-writeboost to staging tree.
>
> dm-writeboost is a log-structured caching software.
> It batches in-coming random-writes to a big sequential write
> to a cache device.
>
> Unlike other block caching softwares
Don't return success if the buffer has not been initialized.
Signed-off-by: Dan Carpenter
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index 6de6c98..b05293c 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -855,6 +855,6 @@ int vmbus_recvpacket_raw(struct vmbus_channel
> -Original Message-
> From: Dan Carpenter [mailto:[email protected]]
> Sent: Monday, September 16, 2013 1:13 PM
> To: KY Srinivasan
> Cc: [email protected]; [email protected]; [email protected]; Dmitry
> Torokhov; [email protected]; [email protected]; linux-
> in.
On Mon, Sep 16, 2013 at 01:42:35PM -0400, Joseph Salisbury wrote:
> Reverting the patch changes the driver back to useing kzalloc() and
> memcpy() instead of kmemdup. Doing so has uncovered another bug, which
> causes an oops on memcpy()[1]. We are in the process of bisecting that
> one now and
On Mon, Sep 16, 2013 at 04:49:29PM -0400, Joseph Salisbury wrote:
> On 09/16/2013 04:38 PM, Dan Carpenter wrote:
> > On Mon, Sep 16, 2013 at 01:42:35PM -0400, Joseph Salisbury wrote:
> >> Reverting the patch changes the driver back to useing kzalloc() and
> >> memcpy() instead of kmemdup. Doing s
On 09/16/2013 04:38 PM, Dan Carpenter wrote:
> On Mon, Sep 16, 2013 at 01:42:35PM -0400, Joseph Salisbury wrote:
>> Reverting the patch changes the driver back to useing kzalloc() and
>> memcpy() instead of kmemdup. Doing so has uncovered another bug, which
>> causes an oops on memcpy()[1]. We a
On Mon, Sep 16, 2013 at 06:42:25PM +, KY Srinivasan wrote:
> Dan,
>
> Rolling the changes you have indicated is not the issue; this can trivially
> be done.
> My contention is that it is not needed given that the underlying function is
> already
> doing that. Look at the function vmbus_recv
> -Original Message-
> From: Dan Carpenter [mailto:[email protected]]
> Sent: Monday, September 16, 2013 11:33 AM
> To: KY Srinivasan
> Cc: Dmitry Torokhov; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; linux-
> in
Just roll something like the following into your patch.
regards,
dan carpenter
diff --git a/drivers/input/serio/hyperv-keyboard.c
b/drivers/input/serio/hyperv-keyboard.c
index 0d4625f..262721b 100644
--- a/drivers/input/serio/hyperv-keyboard.c
+++ b/drivers/input/serio/hyperv-keyboard.c
@@ -151,
> -Original Message-
> From: Dmitry Torokhov [mailto:[email protected]]
> Sent: Monday, September 16, 2013 10:10 AM
> To: KY Srinivasan
> Cc: Dan Carpenter; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; linux-
> i
On 09/16/13 09:17, Jürgen Beisert wrote:
> Hi Jonathan,
>
> On Sunday 15 September 2013 12:35:29 Jonathan Cameron wrote:
>> [...]
>>> +static void mxs_lradc_reg_set(struct mxs_lradc *lradc, u32 val, u32 reg)
>>> +{
>>> + writel(val, lradc->base + reg + STMP_OFFSET_REG_SET);
>>> +}
>>> +
>>> +sta
Hi Thomas,
A bug was opened against the Ubuntu kernel[0]. After a kernel bisect,
it was found that reverting the following commit resolved
this bug:
commit a4a23f6d68ad2c86ee8df6a6f89c9d315c0a761c
Author: Thomas Meyer
Date: Sat Jun 1 11:40:31 2013 +0200
HID: hyperv: convert alloc+memcpy
On Mon, Sep 16, 2013 at 03:52:18PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Dmitry Torokhov [mailto:[email protected]]
> > Sent: Monday, September 16, 2013 8:20 AM
> > To: KY Srinivasan
> > Cc: [email protected]; [email protected];
> > d
On Mon, Sep 16, 2013 at 04:56:03PM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Dan Carpenter [mailto:[email protected]]
> > Sent: Monday, September 16, 2013 8:06 AM
> > To: KY Srinivasan
> > Cc: [email protected]; [email protected]; [email protected];
>
> -Original Message-
> From: Dan Carpenter [mailto:[email protected]]
> Sent: Monday, September 16, 2013 8:06 AM
> To: KY Srinivasan
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
>
> -Original Message-
> From: Dmitry Torokhov [mailto:[email protected]]
> Sent: Monday, September 16, 2013 8:20 AM
> To: KY Srinivasan
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> o.
"Jürgen Beisert" wrote:
>Hi Jonathan,
>
>On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
>> On 09/11/13 09:18, Juergen Beisert wrote:
>> > For battery driven systems it is a very bad idea to collect the
>> > touchscreen data within a kernel busy loop.
>> >
>> > This change uses the
On Sun, Sep 15, 2013 at 11:56:25AM +0100, Jonathan Cameron wrote:
> On 09/11/13 09:18, Juergen Beisert wrote:
> > For battery driven systems it is a very bad idea to collect the touchscreen
> > data within a kernel busy loop.
> >
> > This change uses the features of the hardware to delay and accum
Hi K. Y.
On Sun, Sep 15, 2013 at 10:28:54PM -0700, K. Y. Srinivasan wrote:
> Add a new driver to support synthetic keyboard. On the next generation
> Hyper-V guest firmware, many legacy devices will not be emulated and this
> driver will be required.
>
> I would like to thank Vojtech Pavlik for
Dear Jürgen Beisert,
> Hi Marek,
>
> On Monday 16 September 2013 16:23:48 Marek Vasut wrote:
> > > On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
> > > > On 09/11/13 09:18, Juergen Beisert wrote:
> > > > > For battery driven systems it is a very bad idea to collect the
> > > > > tou
On Mon, Sep 16, 2013 at 02:46:24PM +, KY Srinivasan wrote:
> > > + case VM_PKT_DATA_INBAND:
> > > + hv_kbd_on_receive(device, desc);
> >
> > This is the error handling I mentioned at the top. hv_kbd_on_receive()
> > doesn't take into consideration the a
> -Original Message-
> From: Dan Carpenter [mailto:[email protected]]
> Sent: Monday, September 16, 2013 1:21 AM
> To: KY Srinivasan
> Cc: [email protected]; [email protected];
> [email protected]; [email protected];
> dmitry.torok...@gmail.
Hi Marek,
On Monday 16 September 2013 16:23:48 Marek Vasut wrote:
> > On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
> > > On 09/11/13 09:18, Juergen Beisert wrote:
> > > > For battery driven systems it is a very bad idea to collect the
> > > > touchscreen data within a kernel busy l
Dear Jürgen Beisert,
> Hi Jonathan,
>
> On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
> > On 09/11/13 09:18, Juergen Beisert wrote:
> > > For battery driven systems it is a very bad idea to collect the
> > > touchscreen data within a kernel busy loop.
> > >
> > > This change uses
Dear Jürgen Beisert,
> Hi Jonathan,
>
> On Sunday 15 September 2013 12:50:09 Jonathan Cameron wrote:
> > On 09/11/13 09:18, Juergen Beisert wrote:
> > > Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC
> > > at least for the 4 wire touchscreen.
> > >
> > > Note: support for
Dear Juergen Beisert,
> Replace the individual register access by a few shared access function to
> make the code easier to read and in order to add the i.MX23 SoC in the
> next step.
>
> Signed-off-by: Juergen Beisert
> CC: [email protected]
> CC: [email protected]
>
Second of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
Fixed some lines over 80 characters.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35rx.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/winbond/wb35rx.c b/drivers/staging/winbond/wb35rx.c
index 48ed95c..999b7046 100644
--- a/drivers/stagin
Prototype of two functions added to the header to avoid the use of extern.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/mto.c | 4 +---
drivers/staging/winbond/mto.h | 4 ++--
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/winbond/mto.c b/drivers/stagin
Fourth of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg
Fixes some coding style issues from drivers/staging/winbond
Iker Pedrosa (24):
Staging: winbond: mto: removed function declaration
Staging: winbond: mto: avoided use of extern functions
Staging: winbond: mto: deleted extern functions
Staging: winbond: phy_calibration: first of the patches
Second of the patches that fixes the lines over 80 characters in
phy_calibration.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/phy_calibration.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/winbond/phy_calibration.c
b/drivers/stag
Deleted declaration of external functions that weren't used on this driver.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/mto.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/winbond/mto.h b/drivers/staging/winbond/mto.h
index 22bb264..8d41eed 100644
--- a/drive
Fifth of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.
White space deleted before semicolons.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index 5883d23..80b4b34 100644
--- a/drivers/staging/winbond/r
Seventh of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index
Third of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
i
The following function declarations have been removed because they aren't
implemented.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/mto.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/winbond/mto.c b/drivers/staging/winbond/mto.c
index 560c0ab..0d0f9fb 100644
Fixed some lines over 80 characters.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wbusb.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c
index 3fa1ae4..a2868f2 100644
--- a/drivers
First of the patches that fixes the lines over 80 characters in
phy_calibration.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/phy_calibration.c | 46 ++-
1 file changed, 27 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/winbond/phy_calibrati
Erased all the errors given by checkpatch stating trailing whitespace.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index 75b7752..5883d
Sixth of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 28 ++--
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
ind
First of the patches that fixes the lines over 80 characters in reg.c
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/reg.c | 26 ++
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
index
Deleted an space before a tabulation.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35reg_s.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/winbond/wb35reg_s.h
b/drivers/staging/winbond/wb35reg_s.h
index dc79faa..cdbbf35 100644
--- a/drivers/sta
The previously used printk lacked the warning level, now we've got a more
accurate way to know the error.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35tx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/stagi
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wbusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
Fixed lines over 80 characters.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35reg_f.h | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/winbond/wb35reg_f.h
b/drivers/staging/winbond/wb35reg_f.h
index 95dc980..cd6710c 100644
---
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35rx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
In the first revision Greg KH pointed out that this change broke the build. In
my computer it builds properly so if someone has t
According to the documentation it is not recommended to use msleep for 1ms -
20ms because it may sleep longer than 20ms. So, it is recommended to use usleep
instead.
In the first revision Greg KH pointed out that this change broke the build. In
my computer it builds properly so if someone has t
Erased the spaces that existed after opening some square brackets '['.
Signed-off-by: Iker Pedrosa
---
drivers/staging/winbond/wb35tx_s.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/winbond/wb35tx_s.h
b/drivers/staging/winbond/wb35tx_s.h
index 715f87d..dc
On Fri, 13 Sep 2013, [email protected] wrote:
> From: Wei WANG
>
> In some platforms, specially Thinkpad series, rts5249 won't be
> initialized properly. So we need adjust some phy parameters to
> improve the compatibility issue.
>
> It is a little different between simulation and real ch
Hi Jonathan,
On Monday 16 September 2013 10:10:22 Jürgen Beisert wrote:
> [...]
> > While this driver is placed in IIO within staging at the moment, these
> > changes are definitely input related. Hence I have cc'd Dmitry and the
> > input list.
> >
> > I am personaly a little uncomfortable that
Hi Jonathan,
On Sunday 15 September 2013 18:10:18 Jonathan Cameron wrote:
> On 09/15/13 11:56, Jonathan Cameron wrote:
> > On 09/11/13 09:18, Juergen Beisert wrote:
> >> For battery driven systems it is a very bad idea to collect the
> >> touchscreen data within a kernel busy loop.
> >>
> >> This
The main thing is that could you improve the error handling in
hv_kbd_on_channel_callback() explained inline.
On Sun, Sep 15, 2013 at 10:28:54PM -0700, K. Y. Srinivasan wrote:
> Add a new driver to support synthetic keyboard. On the next generation
> Hyper-V guest firmware, many legacy devices wil
Hi Jonathan,
On Sunday 15 September 2013 12:35:29 Jonathan Cameron wrote:
> [...]
> > +static void mxs_lradc_reg_set(struct mxs_lradc *lradc, u32 val, u32 reg)
> > +{
> > + writel(val, lradc->base + reg + STMP_OFFSET_REG_SET);
> > +}
> > +
> > +static void mxs_lradc_reg_clear(struct mxs_lradc *l
Hi Jonathan,
On Sunday 15 September 2013 12:50:09 Jonathan Cameron wrote:
> On 09/11/13 09:18, Juergen Beisert wrote:
> > Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at
> > least for the 4 wire touchscreen.
> >
> > Note: support for the remaining LRADC channels is not tes
Hi Jonathan,
On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:
> On 09/11/13 09:18, Juergen Beisert wrote:
> > For battery driven systems it is a very bad idea to collect the
> > touchscreen data within a kernel busy loop.
> >
> > This change uses the features of the hardware to delay a
65 matches
Mail list logo
