On Tue, Sep 10, 2013 at 10:00 PM, Joe Perches wrote:
> On Tue, 2013-09-10 at 21:41 -0700, Kees Cook wrote:
>> Make sure that format strings cannot leak into printk() calls from the
>> msgbuf string.
>
> printf(string);
> vs
> printf("%s", string);
>
> How does this help?
In the fo
Makes sure format string cannot leak into device_create() call.
Signed-off-by: Kees Cook
---
drivers/staging/xillybus/xillybus_core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xillybus/xillybus_core.c
b/drivers/staging/xillybus/xillybus_core.c
index
Make sure that format strings cannot leak into printk() calls from the
msgbuf string.
Signed-off-by: Kees Cook
---
drivers/staging/dgnc/dgnc_driver.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.
This fixes up the usage of snprintf, strncpy, and format strings in the
call to kthread_run to avoid ever accidentally allowing a format string
into the thread name.
Signed-off-by: Kees Cook
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c |2 +-
.../staging/lustre/lnet/klnds/socklnd/s
The boot message buffer could potentially overflow the stack and the
heap. Additionally make sure format strings could not leak into printk()
calls.
Signed-off-by: Kees Cook
---
drivers/staging/dgap/dgap_driver.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --
Hi, list!
I wat to try to write a kernel driver for some mediabuttons (and their
backlight) on my laptop, that don't want to work otherwise.
First of all, can you suggest me some ways for reverse-engineering if I
have no MS Windows OS (and don't want to buy it and even to install it)?
Actually, ex
On Wed, Sep 11, 2013 at 10:30 AM, Guenter Roeck wrote:
> On Wed, Sep 11, 2013 at 10:25:57AM +0800, Peng Tao wrote:
>> On Wed, Sep 11, 2013 at 9:44 AM, Christoph Hellwig
>> wrote:
>> > On Wed, Sep 11, 2013 at 01:14:11AM +0800, Peng Tao wrote:
>> >> The problem is access_process_vm() is not export
On Wed, Sep 11, 2013 at 10:25:57AM +0800, Peng Tao wrote:
> On Wed, Sep 11, 2013 at 9:44 AM, Christoph Hellwig wrote:
> > On Wed, Sep 11, 2013 at 01:14:11AM +0800, Peng Tao wrote:
> >> The problem is access_process_vm() is not exported since certain
> >> version of kernel including the latest. Acc
On Wed, Sep 11, 2013 at 9:44 AM, Christoph Hellwig wrote:
> On Wed, Sep 11, 2013 at 01:14:11AM +0800, Peng Tao wrote:
>> The problem is access_process_vm() is not exported since certain
>> version of kernel including the latest. According to Christoph in the
>> other mail, access_process_vm() is a
On Wed, Sep 11, 2013 at 01:14:11AM +0800, Peng Tao wrote:
> The problem is access_process_vm() is not exported since certain
> version of kernel including the latest. According to Christoph in the
> other mail, access_process_vm() is also a core mm function that is not
> supposed to be exported. Th
于 2013年09月10日 19:08, Lee Jones 写道:
I'm not asking for in-depth analysis, just an overview.
What's wrong with the default config?
Why is the signal quality bad and what makes it bad?
What did the old magic numbers do?
How will the configuration differ if I applied your patch?
It is a little dif
Dan Carpenter writes:
> Good eye for spotting the memory corruption bug!
>
> This is a bug fix, so the fix should go in a separate patch and not
> merged with a code cleanup patch. Ordinary users can trigger this so
> it's a security bug and separating it out is extra important.
Ok. I just sen
When a new voice is selected, we set volume and pitch appropriate for
the voice. We need to use the numeric index corresponding to the
voice when indexing into the volume and pitch tables, rather than
the raw user input that was used to select the voice.
Note that using the raw input can also lead
This patch removes parentheses around return
statements. They aren't needed.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_cls.c| 8 +-
drivers/staging/dgnc/dgnc_driver.c | 106 +--
drivers/staging/dgnc/dgnc_mgmt.c | 22 ++--
drivers/staging/dgnc/dgnc_neo.c
ret == 0 means success, anything else is failure.
Signed-off-by: navin patidar
---
drivers/staging/usbip/vhci_hcd.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c
index d7974cb..b3c9217 100644
--- a/d
Dear Jürgen Beisert,
> Hi Marek,
>
> On Monday 09 September 2013 18:04:19 Marek Vasut wrote:
> > > Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC
> > > at least for the 4 wire touchscreen.
> > >
> > > Signed-off-by: Juergen Beisert
> > > CC: [email protected]
On Tue, Sep 10, 2013 at 4:49 PM, Geert Uytterhoeven
wrote:
> On Mon, Sep 9, 2013 at 10:06 PM, Guenter Roeck wrote:
>>> [*] Why does m68k allmodconfig still succeed on kissb???
>>> It does fail for me, as m68k's copy_from_user_page() calls
>>> flush_icache_user_range(), which is not export
Dear Jürgen Beisert,
> Hi Marek,
>
> On Tuesday 10 September 2013 10:22:36 Marek Vasut wrote:
> > > On Monday 09 September 2013 18:04:19 Marek Vasut wrote:
> > > > > Distinguish i.MX23 and i.MX28 at runtime and do the same for both
> > > > > SoC at least for the 4 wire touchscreen.
> > > > >
> >
On Tue, Sep 10, 2013 at 05:58:02PM +0300, Dan Carpenter wrote:
> Btw, the [email protected] list seems to be down again. I
> still have not recieved the v3 patch. Use the
> [email protected] email list instead.
They are the same "list", just different DNS entries.
This patch removes the error messages associated
with errors in kzalloc. The driver doesn't need to
add the error message because kzalloc already prints
a more useful message.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 2 --
drivers/staging/dgnc/dgnc_tty.c| 4
This patch removes the conditionals that make sure
the driver supports various versions of the kernel.
They aren't needed.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 12
drivers/staging/dgnc/dgnc_kcompat.h | 24 ---
drivers/staging/dgnc/dgnc_tty.c
This patch removes casting around kzalloc calls.
The casts aren't needed because kzalloc returns
a void pointer.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/driver
On Mon, Sep 9, 2013 at 7:22 PM, Greg Kroah-Hartman
wrote:
> On Mon, Sep 09, 2013 at 10:08:19AM -0700, Guenter Roeck wrote:
>> On Mon, Sep 09, 2013 at 09:39:02AM -0700, Greg Kroah-Hartman wrote:
>> > On Mon, Sep 09, 2013 at 06:40:12AM -0700, Christoph Hellwig wrote:
>> > > On Sun, Sep 08, 2013 at 0
On Mon, Sep 09, 2013 at 10:08:19AM -0700, Guenter Roeck wrote:
> On Mon, Sep 09, 2013 at 09:39:02AM -0700, Greg Kroah-Hartman wrote:
> > On Mon, Sep 09, 2013 at 06:40:12AM -0700, Christoph Hellwig wrote:
> > > On Sun, Sep 08, 2013 at 06:59:45PM -0700, Greg Kroah-Hartman wrote:
> > > > Can't we just
The arguments that were passed into sizeof were
generic. This patch changes this by putting
the actual item that we need a size of instead.
For example:
- kzalloc(sizeof(struct dgnc_board), GFP_KERNEL);
+ kzalloc(sizeof(*brd), GFP_KERNEL);
Signed-off-by: Lidza Louina
---
drivers/staging/dgn
On Mon, Sep 09, 2013 at 09:39:02AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Sep 09, 2013 at 06:40:12AM -0700, Christoph Hellwig wrote:
> > On Sun, Sep 08, 2013 at 06:59:45PM -0700, Greg Kroah-Hartman wrote:
> > > Can't we just export the functions for those arches? Surely lutre
> > > isn't the f
Dear Dan Carpenter,
> On Tue, Sep 10, 2013 at 09:36:14AM +0200, Jürgen Beisert wrote:
> > > This patch seems to combine two things -- register access rework AND
> > > adjustment of the driver for MX23 touchscreen.
> >
> > It reworks the register access to avoid the i.MX23/i.MX28 runtime
> > decis
Calling handle_pending_slot_free() for every RW operation may
cause unneccessary slot_free_lock locking, because most likely
process will see NULL slot_free_rq. handle_pending_slot_free()
only when current detects that slot_free_rq is not NULL.
v3: do not acquire zram lock in zram_slot_free().
v2:
On 08/29/13 21:14, Derek Basehore wrote:
> The lux_uscale value is not initialized at probe. The value will be
> uninitialized unless a value is written to it through the iio channel
> interface.
> This fixes that.
>
> Signed-off-by: Derek Basehore
> Reviewed-on: https://gerrit.chromium.org/gerr
On 08/20/13 03:31, Jingoo Han wrote:
> The usage of strict_strto*() is not preferred, because
> strict_strto*() is obsolete. Thus, kstrto*() should be
> used.
>
> Previously, there were only strict_strtol(), strict_strtoul(),
> strict_strtoull(), and strict_strtoll(). Thus, when converting
> to th
Please don't flame me :) I'm getting my feet wet with kernel contribution.
One example I saw in a video by GKH suggested cleaning up coding style as a
good first commit.
Signed-off-by: Sean Williams
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 7 +++
1 file changed, 3 insertions(+), 4
`zram->init_done' in fact mimics `zram->meta != NULL' value.
Introduce init_done() function that checks zram->meta (iow,
checks if initialisation was performed), so `zram->init_done'
can be removed.
v3: init_done() in handle_pending_slot_free()
v2: introduce init_done()
Signed-off-by: Sergey Seno
This patch renames the struct board_t to dgnc_board. board_t
wasn't a good name for it since the _t suffix is for typedefs.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_cls.c| 14 +--
drivers/staging/dgnc/dgnc_driver.c | 20 +++
drivers/staging/dgnc/dgnc_driv
On Mon, Sep 09, 2013 at 07:48:51AM +0530, Ramkumar Ramachandra wrote:
> Greg Kroah-Hartman wrote:
> > On Sun, Sep 08, 2013 at 06:03:00PM -0700, Guenter Roeck wrote:
> >> Unfortunately, LUSTRE can only be built as module, so there is no
> >> easy fix.
> >
> > Can't we just export the functions for t
From: Faris de Haan
Fixed a few of the coding style issues reported by checkpatch.pl
Signed-off-by: Faris de Haan
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw
On Sun, Sep 08, 2013 at 07:24:19PM -0700, Guenter Roeck wrote:
> On 09/08/2013 06:59 PM, Greg Kroah-Hartman wrote:
> > On Sun, Sep 08, 2013 at 06:03:00PM -0700, Guenter Roeck wrote:
> >> mips allmodconfig fails with
> >>
> >> ERROR: "copy_from_user_page"
> >> [drivers/staging/lustre/lustre/libcfs/
On Mon, Sep 09, 2013 at 09:11:25PM +0200, Geert Uytterhoeven wrote:
> On Mon, Sep 9, 2013 at 7:22 PM, Greg Kroah-Hartman
> wrote:
> > On Mon, Sep 09, 2013 at 10:08:19AM -0700, Guenter Roeck wrote:
> >> On Mon, Sep 09, 2013 at 09:39:02AM -0700, Greg Kroah-Hartman wrote:
> >> > On Mon, Sep 09, 2013
On (09/10/13 17:34), Sergey Senozhatsky wrote:
[..]
> >
> > Now I think we can drop the call to handle_pending_slot_free() in
> > zram_bvec_rw() altogether. As long as the write lock is held when
> > handle_pending_slot_free() is called, there is no race. It's no different
> > from any write reque
On Tue, Sep 10, 2013 at 09:36:14AM +0200, Jürgen Beisert wrote:
> >
> > This patch seems to combine two things -- register access rework AND
> > adjustment of the driver for MX23 touchscreen.
>
> It reworks the register access to avoid the i.MX23/i.MX28 runtime decision
> all
> over the code aga
Good eye for spotting the memory corruption bug!
This is a bug fix, so the fix should go in a separate patch and not
merged with a code cleanup patch. Ordinary users can trigger this so
it's a security bug and separating it out is extra important.
The checking in spk_set_num_var() is not suffici
Dan Carpenter noted that handle_pending_slot_free() is racy with
zram_reset_device(). Take write init_lock in zram_slot_free(), thus
preventing any concurrent zram_slot_free(), zram_bvec_rw() or
zram_reset_device(). This also allows to safely check zram->init_done
in handle_pending_slot_free().
In
vhci_hcd is a virtual usb host controller, so no need to
check for dma.
Signed-off-by: navin patidar
---
drivers/staging/usbip/vhci_hcd.c |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c
index b3c9217..e810ad5 100644
ret == 0 means success, anything else is failure.
Signed-off-by: navin patidar
---
drivers/staging/usbip/stub_main.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/usbip/stub_main.c
b/drivers/staging/usbip/stub_main.c
index 33027cc..baf857f 100644
---
Btw, the [email protected] list seems to be down again. I
still have not recieved the v3 patch. Use the
[email protected] email list instead.
regards,
dan carpenter
___
devel mailing list
[email protected]
http
"Raphael S.Carvalho" writes:
> + /*
> + * If voice was just changed, we might need to reset our default
> + * pitch and volume.
> + */
> + if (param->var_id == VOICE) {
> + spk_reset_default_value("pitch", synth->defa
This is a patch to fwserial.c that wraps a line which previously exceeded the 80
character limit warning found by checkpatch.pl. This driver is now warning and
error free, according to checkpatch.pl
Signed-off-by: Jon Bernard
---
drivers/staging/fwserial/fwserial.c | 3 ++-
1 file changed, 2 in
On Mon, Sep 09, 2013 at 03:01:27PM -0400, Lidza Louina wrote:
> The arguments that were passed into sizeof were
> generic. This patch changes this by putting
> the actual item that we need a size of instead.
>
> For example:
> - kzalloc(sizeof(struct dgnc_board), GFP_KERNEL);
> + kzalloc(sizeo
This one is not right.
On Mon, Sep 09, 2013 at 03:01:28PM -0400, Lidza Louina wrote:
> This patch replaces kzalloc with kcalloc when using
> arrays. kcalloc is better suited for arrays because
> it has overflow protection.
>
> Reported-by: Dan Carpenter
> Signed-off-by: Lidza Louina
> ---
> dr
On Mon, Sep 09, 2013 at 03:01:22PM -0400, Lidza Louina wrote:
> This patch renames the struct board_t to dgnc_board. board_t
> wasn't a good name for it since the _t suffix is for typedefs.
>
> Signed-off-by: Lidza Louina
These were fine before. There was no need to resend the first five
patche
On Tue, Sep 10, 2013 at 10:44:07AM +0530, navin patidar wrote:
> ret == 0 means success, anything else is failure.
>
Hopefully, it's only returning negative error codes. Otherwise it needs
a different fix.
There isn't an official kernel style on if "if (ret < 0)" is better than
"if (ret)". Som
This patch replaces kzalloc with kcalloc when using
arrays. kcalloc is better suited for arrays because
it has overflow protection.
Reported-by: Dan Carpenter
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --gi
On Tue, Sep 10, 2013 at 6:44 PM, Guenter Roeck wrote:
>> I tried with 2.6.3 from crosstool, and it succeeded, too.
>>
> Do such old versions of gcc still exist ? Just kidding :)
>
>> Turns out cfs_access_process_vm() is called with write=0 only.
>> Gcc 2.6.3 optimizes away the write != 0 branch (w
Fixed space prohibition before semicolon, particularly:
nvm.c:106: WARNING: space prohibited before semicolon
nvm.c:1098: WARNING: space prohibited before semicolon
nvm.c:1279: WARNING: space prohibited before semicolon
nvm.c:2834: WARNING: space prohibited before semicolon
nvm.c:3361: WARNING: sp
On 09/10/2013 03:38 AM, [email protected] wrote:
From: Faris de Haan
Fixed a few of the coding style issues reported by checkpatch.pl
Signed-off-by: Faris de Haan
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 22 +++---
1 file changed, 11 insertions(+), 11 dele
On (09/09/13 18:10), Jerome Marchand wrote:
> On 09/09/2013 03:46 PM, Jerome Marchand wrote:
> > On 09/09/2013 03:21 PM, Dan Carpenter wrote:
> >> On Mon, Sep 09, 2013 at 03:49:42PM +0300, Sergey Senozhatsky wrote:
> > Calling handle_pending_slot_free() for every RW operation may
> > cause
Hi Marek,
On Tuesday 10 September 2013 10:22:36 Marek Vasut wrote:
> > On Monday 09 September 2013 18:04:19 Marek Vasut wrote:
> > > > Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC
> > > > at least for the 4 wire touchscreen.
> > > >
> > > > Signed-off-by: Juergen Beisert
On Mon, Sep 9, 2013 at 1:01 PM, Heiko Carstens
wrote:
> On Sun, Sep 08, 2013 at 07:31:18PM -0700, Guenter Roeck wrote:
>> On 09/08/2013 07:31 PM, Greg Kroah-Hartman wrote:
>> >On Sun, Sep 08, 2013 at 07:24:19PM -0700, Guenter Roeck wrote:
>> >>On 09/08/2013 06:59 PM, Greg Kroah-Hartman wrote:
>> >
On 09/08/2013 07:55 PM, Ramkumar Ramachandra wrote:
Greg Kroah-Hartman wrote:
How will the hardware industry be driven otherwise?
I have no idea what you are referring to here, please explain.
For stability, hardware needs to be present. When I started out a
couple of days ago, I blamed my m
On Mon, Sep 09, 2013 at 08:08:28AM +0530, Ramkumar Ramachandra wrote:
> Greg Kroah-Hartman wrote:
> > What do you mean by this? What "initial cost"? You should be able to
> > cross-compile almost all arches on your desktop machine today with the
> > compilers we have on kernel.org. If I can get
On Tue, 10 Sep 2013, wwang wrote:
> 于 2013年09月10日 17:09, [email protected] 写道:
> > From: Wei WANG
> >
> > In some platforms, specially Thinkpad series, rts5249 won't be
> > initialized properly. So we need adjust some phy parameters to
> > improve the compatibility issue.
>
> Hi all:
>
>
On Tue, 10 Sep 2013, wwang wrote:
> 于 2013年09月10日 17:28, Lee Jones 写道:
> >I would like some more information in the commit log though. You're
> >making a lot of configuration changes here and due to the
> >incomprehensible 'magic numbers' used previously, it's impossible to
> >know what you're cha
> From: Wei WANG
>
> In some platforms, specially Thinkpad series, rts5249 won't be
> initialized properly. So we need adjust some phy parameters to
> improve the compatibility issue.
The code looks so much more readable now, thanks for that.
I would like some more information in the commit log
于 2013年09月10日 17:28, Lee Jones 写道:
I would like some more information in the commit log though. You're
making a lot of configuration changes here and due to the
incomprehensible 'magic numbers' used previously, it's impossible to
know what you're changing by just reading the code.
Why won't the
于 2013年09月09日 21:02, Lee Jones 写道:
#define PHY_FLD4 0x1E
>+#define FLDEN_SEL 0x4000
>+#define REQ_REF 0x2000
>+#define RXAMP_OFF 0x1000
>+#define REQ_ADDA 0x0800
>+#define BER_COUNT 0x00
于 2013年09月10日 17:09, [email protected] 写道:
> From: Wei WANG
>
> In some platforms, specially Thinkpad series, rts5249 won't be
> initialized properly. So we need adjust some phy parameters to
> improve the compatibility issue.
Hi all:
Sorry, forget to modify the subject prefix. Please igno
On Mon, Sep 9, 2013 at 10:06 PM, Guenter Roeck wrote:
>> [*] Why does m68k allmodconfig still succeed on kissb???
>> It does fail for me, as m68k's copy_from_user_page() calls
>> flush_icache_user_range(), which is not exported.
>>
> I don't see a build failure in m68k:allmodconfig either.
From: Wei WANG
In some platforms, specially Thinkpad series, rts5249 won't be
initialized properly. So we need adjust some phy parameters to
improve the compatibility issue.
Signed-off-by: Wei WANG
---
drivers/mfd/rts5249.c| 48 --
include/linux/mf
From: Wei WANG
In some platforms, specially Thinkpad series, rts5249 won't be
initialized properly. So we need adjust some phy parameters to
improve the compatibility issue.
Signed-off-by: Wei WANG
---
drivers/mfd/rts5249.c| 48 --
include/linux/mf
Raphael S Carvalho writes:
> Wouldn't the following code (right before the statement: if
> (param->var_id == VOICE))
> check if value is out of range?
>
> value = simple_strtol(cp, NULL, 10);
> ret = spk_set_num_var(value, param, len);
> if (ret == -ERANGE) {
> var_data = param->data;
> pr_warn(
On Fri, 06 Sep 2013, [email protected] wrote:
> From: Wei WANG
>
> v2:
> Name those new-added register values
>
> Wei WANG (1):
> mfd: rtsx: Modify rts5249_optimize_phy
>
> drivers/mfd/rts5249.c| 35 --
> include/linux/mfd/rtsx_pci.h | 43
>
On 09/09/2013 02:34 PM, Dan Carpenter wrote:
> On Fri, Sep 06, 2013 at 06:21:20PM +0300, Sergey Senozhatsky wrote:
>> @@ -558,14 +563,12 @@ static void zram_reset_device(struct zram *zram, bool
>> reset_capacity)
>> flush_work(&zram->free_work);
>>
>> down_write(&zram->init_lock);
>> -
On Fri, Sep 6, 2013 at 5:50 PM, Dan Carpenter wrote:
> On Fri, Sep 06, 2013 at 04:48:30PM -0400, Lidza Louina wrote:
>> This patch removes the error messages associated
>> with errors in kzalloc. The driver doesn't need to
>> add the error message because kzalloc already prints
>> a more useful me
On Fri, Sep 06, 2013 at 06:12:55PM +0300, Sergey Senozhatsky wrote:
> Calling handle_pending_slot_free() for every RW operation may
> cause unneccessary slot_free_lock locking, because most likely
> process will see NULL slot_free_rq. handle_pending_slot_free()
> only when current detects that slot
On Tue, Sep 10, 2013 at 10:49:05AM +0200, Geert Uytterhoeven wrote:
> On Mon, Sep 9, 2013 at 10:06 PM, Guenter Roeck wrote:
> >> [*] Why does m68k allmodconfig still succeed on kissb???
> >> It does fail for me, as m68k's copy_from_user_page() calls
> >> flush_icache_user_range(), which is
Hi Konrad,
The above commit (c70bda9 in mainline) doesn't appear to work for me.
I.e., depmod does not create an entry in modules.devname and hence no
device node is created on boot.
If I understand correctly, you'd also need to create the correct
"char-major--" alias. But I don't really see how
On 09/08/2013 06:59 PM, Greg Kroah-Hartman wrote:
On Sun, Sep 08, 2013 at 06:03:00PM -0700, Guenter Roeck wrote:
mips allmodconfig fails with
ERROR: "copy_from_user_page" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
undefined!
which is due to LUSTRE using copy_from_user_page which is not e
Greg Kroah-Hartman wrote:
>> How will the hardware industry be driven otherwise?
>
> I have no idea what you are referring to here, please explain.
For stability, hardware needs to be present. When I started out a
couple of days ago, I blamed my monitor for the data corruption: it's
one extra poin
Guenter Roeck wrote:
>> For stability, hardware needs to be present. When I started out a
>> couple of days ago, I blamed my monitor for the data corruption: it's
>> one extra point of leverage.
>
> I have no idea whatsoever what you are talking about.
Sorry, my bad. I haven't done hardware driver
On 09/09/2013 10:34 AM, [email protected] wrote:
From: Faris de Haan
Fixed some of the coding style issues reported by checkpatch.pl
Signed-off-by: Faris de Haan
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
On Mon, Sep 09, 2013 at 06:40:12AM -0700, Christoph Hellwig wrote:
> On Sun, Sep 08, 2013 at 06:59:45PM -0700, Greg Kroah-Hartman wrote:
> > Can't we just export the functions for those arches? Surely lutre
> > isn't the first/only driver that needs this?
>
> Lustre is. These are core mm helpers
On Sun, Sep 08, 2013 at 06:03:00PM -0700, Guenter Roeck wrote:
> mips allmodconfig fails with
>
> ERROR: "copy_from_user_page" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
> undefined!
>
> which is due to LUSTRE using copy_from_user_page which is not exported by any
> architecture.
Any, or j
mips allmodconfig fails with
ERROR: "copy_from_user_page" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
undefined!
which is due to LUSTRE using copy_from_user_page which is not exported by any
architecture. Unfortunately, LUSTRE can only be built as module, so there is no
easy fix.
MIPS, SH,
Greg Kroah-Hartman wrote:
> On Sun, Sep 08, 2013 at 06:03:00PM -0700, Guenter Roeck wrote:
>> mips allmodconfig fails with
>>
>> ERROR: "copy_from_user_page" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
>> undefined!
>>
>> which is due to LUSTRE using copy_from_user_page which is not exported b
The usbip userspace utilities contained some half-documented (only in
--help, not in man) options. They were added to the man-pages of usbip
and usbipd.
Also a typo in the usbip headline was fixed.
Signed-off-by: Tobias Polzer
Signed-off-by: Dominik Paulus
---
drivers/staging/usbip/userspace/do
On Fri, 06 Sep 2013, [email protected] wrote:
> From: Wei WANG
>
> In some platforms, specially Thinkpad series, rts5249 won't be
> initialized properly. So we need adjust some phy parameters to
> improve the compatibility issue.
>
> Signed-off-by: Wei WANG
> ---
> drivers/mfd/rts5249.c
On Mon, Sep 9, 2013 at 5:58 PM, Tom Gundersen wrote:
> Hi Konrad,
>
> The above commit (c70bda9 in mainline) doesn't appear to work for me.
> I.e., depmod does not create an entry in modules.devname and hence no
> device node is created on boot.
>
> If I understand correctly, you'd also need to cr
On 09/08/2013 07:31 PM, Greg Kroah-Hartman wrote:
On Sun, Sep 08, 2013 at 07:24:19PM -0700, Guenter Roeck wrote:
On 09/08/2013 06:59 PM, Greg Kroah-Hartman wrote:
On Sun, Sep 08, 2013 at 06:03:00PM -0700, Guenter Roeck wrote:
mips allmodconfig fails with
ERROR: "copy_from_user_page" [drivers/
Dear Juergen Beisert,
> Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at
> least for the 4 wire touchscreen.
>
> Signed-off-by: Juergen Beisert
> CC: [email protected]
> CC: [email protected]
> CC: Marek Vasut
> CC: Fabio Estevam
> CC: Jonath
Greg Kroah-Hartman wrote:
> What do you mean by this? What "initial cost"? You should be able to
> cross-compile almost all arches on your desktop machine today with the
> compilers we have on kernel.org. If I can get them set up and working,
> they can't be that hard for anyone else :)
Won't y
On 09/09/2013 03:46 PM, Jerome Marchand wrote:
> On 09/09/2013 03:21 PM, Dan Carpenter wrote:
>> On Mon, Sep 09, 2013 at 03:49:42PM +0300, Sergey Senozhatsky wrote:
> Calling handle_pending_slot_free() for every RW operation may
> cause unneccessary slot_free_lock locking, because most like
From: Faris de Haan
Fixed some of the coding style issues reported by checkpatch.pl
Signed-off-by: Faris de Haan
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
b/driver
On (09/09/13 17:52), Dan Carpenter wrote:
> On Mon, Sep 09, 2013 at 05:42:59PM +0300, Sergey Senozhatsky wrote:
> > > 3) Explain why it is safe to test zram->slot_free_rq when we are not
> > >holding the lock. I think it is unsafe. I don't want to even think
> > >about it without the numb
On Mon, Sep 09, 2013 at 05:42:59PM +0300, Sergey Senozhatsky wrote:
> > 3) Explain why it is safe to test zram->slot_free_rq when we are not
> >holding the lock. I think it is unsafe. I don't want to even think
> >about it without the numbers.
>
> atomic pointer test, which is either NUL
On Fri, Sep 6, 2013 at 5:45 PM, Dan Carpenter wrote:
> On Fri, Sep 06, 2013 at 04:48:32PM -0400, Lidza Louina wrote:
>> The arguments that are passed into sizeof were
>> generic. This patch changes this by putting
>> the actual item that we need a size of instead.
>>
>> For example:
>> - kzalloc
On (09/09/13 16:21), Dan Carpenter wrote:
> On Mon, Sep 09, 2013 at 03:49:42PM +0300, Sergey Senozhatsky wrote:
> > > > Calling handle_pending_slot_free() for every RW operation may
> > > > cause unneccessary slot_free_lock locking, because most likely
> > > > process will see NULL slot_free_rq. ha
On Tue, 10 Sep 2013, wwang wrote:
> 于 2013年09月09日 21:02, Lee Jones 写道:
> >> #define PHY_FLD4 0x1E
> >>>+#define FLDEN_SEL0x4000
> >>>+#define REQ_REF 0x2000
> >>>+#define RXAMP_OFF0x1000
> >>>+#define REQ_ADDA
For battery driven systems it is a very bad idea to collect the touchscreen
data within a kernel busy loop.
This change uses the features of the hardware to delay and accumulate samples in
hardware to avoid a high interrupt and CPU load.
Note: this is only tested on a i.MX23 SoC yet.
Signed-off-
The LRADC units in i.MX23 and i.MX28 differ and we need to distinguish both
SoC variants in order to make the touchscreen work on i.MX23
Signed-off-by: Juergen Beisert
CC: [email protected]
CC: [email protected]
CC: Marek Vasut
CC: Fabio Estevam
CC: Jonathan Cameron
The following series replaces the current busy loop touchscreen implementation
for i.MX28/i.MX23 SoCs by a fully interrupt driven implementation.
Since i.MX23 and i.Mx28 silicon differs, the existing implementation can
be used for the i.MX28 SoC only.
So, the first two patches of this series move
On Sun, Sep 08, 2013 at 06:59:45PM -0700, Greg Kroah-Hartman wrote:
> Can't we just export the functions for those arches? Surely lutre
> isn't the first/only driver that needs this?
Lustre is. These are core mm helpers, and lustre uses them to
reimplement another core VM function. It then uses
1 - 100 of 113 matches
Mail list logo
