Re: Avoiding page allocation on validate

2007-12-22 Thread Keith Packard
On Sat, 2007-12-22 at 09:09 +0100, Thomas Hellström wrote: > This should be easy. We can have drm_ttm_get_page() come in two > varieties, one which tests > for NULL only and one that tests for dummy_page or NULL and allocates a > new page if needed. drm_ttm_get_page() is called from the nopfn()

Re: Avoiding page allocation on validate

2007-12-22 Thread Thomas Hellström
Keith Packard wrote: >On Fri, 2007-12-21 at 14:01 +0100, Thomas Hellström wrote: > > > >>This looks like a good thing, but is there a way we can avoid doing this >>in the ttm backend? >>Some backends (Poulsbo, and I think Dave's work on Radeon) implement a >>null populate() function and use th

Re: Avoiding page allocation on validate

2007-12-21 Thread Keith Packard
On Fri, 2007-12-21 at 14:01 +0100, Thomas Hellström wrote: > This looks like a good thing, but is there a way we can avoid doing this > in the ttm backend? > Some backends (Poulsbo, and I think Dave's work on Radeon) implement a > null populate() function and use the ttm page array directly. >

Re: Avoiding page allocation on validate

2007-12-21 Thread Thomas Hellström
Keith Packard wrote: >Right now, validating a buffer object forces every missing page to be >allocated. That means for things like vertex buffer objects, we either >need to create them at the 'right' size, or pay a significant penalty >when a large buffer is mapped to the card. > >It seems like it

Avoiding page allocation on validate

2007-12-16 Thread Keith Packard
Right now, validating a buffer object forces every missing page to be allocated. That means for things like vertex buffer objects, we either need to create them at the 'right' size, or pay a significant penalty when a large buffer is mapped to the card. It seems like it should be far better to jus