[PATCH] drm/i915: fix up error path leak in i915_cmdbuffer

2009-04-16 Thread Chris Wright
Commit 201361a5 introduces a leak when unwinding on error. Reorder unwind, and eliminate leak. Cc: Eric Anholt Cc: Keith Packard Cc: Jesse Barnes Signed-off-by: Chris Wright --- drivers/gpu/drm/i915/i915_dma.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a

[Dri-devel] Re: [CHECKER] Probable security holes in 2.6.5

2004-04-20 Thread Chris Wright
* Andrea Arcangeli ([EMAIL PROTECTED]) wrote: > On Fri, Apr 16, 2004 at 11:54:06AM -0700, Chris Wright wrote: > > + if (mc.idx >= dma->buf_count) > > + return -EINVAL; > > + > > i810_dma_dispatch_mc(dev, dma->buflist[mc.idx], mc.used, > >

[Dri-devel] Re: [CHECKER] Probable security holes in 2.6.5

2004-04-16 Thread Chris Wright
* Ken Ashcraft ([EMAIL PROTECTED]) wrote: > [BUG] > /home/kash/linux/linux-2.6.5/drivers/char/drm/i810_dma.c:1276:i810_dma_mc: > ERROR:TAINT: 1267:1276:Using user value "((mc).idx * 4)" without first performing > bounds checks [SOURCE_MODEL=(lib,copy_from_user,user,taintscalar)] [PATH= > "(*((*d