[patch -next] drm: off by one in drm_edid.c

m == num_est3_modes is one past the end of the est3_modes[]. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 7188674..46447b0 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -1383,7 +1383,7 @@ drm_est3_modes(str

[patch -next] drm: dereferencing before checking for null

The original code dereferences "fb_helper_conn" before verifying that it's non-null. Signed-off-by: Dan Carpenter --- It's never null here actually. I could send a patch to remove the check instead if that's prefered. diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.

[patch] i915: missing unlock on error path

There was a missing mutex_unlock(&dev->struct_mutex) on this error path. Signed-off-by: Dan Carpenter --- I thought Jiri sent this patch earlier but a google search for "stanse struct_mutex i965_reset" didn't find any patches, so I'm resending. diff --git a/drivers/gpu/drm/i915/i915_drv.c b/driv

Re: drm_edid: potential range checking issue?

Ping. This off-by-one overflow is still there in -next. I'm not sure how to fix it because both the declaraion and the use in add_detailed_modes() look deliberate. regards, dan carpenter On Sun, Mar 28, 2010 at 02:25:58PM +0300, Dan Carpenter wrote: > Hi list, :) > > Just going through some

[patch -next] i915/intel_sdvo: remove unneeded null check

The "connector" variable is used as the cursor in a list_for_each_entry() and it's always non-null so we don't need to check it. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index 42ceb15..179d146 100644 --- a/drivers/gpu/drm/i9

Re: [patch] i915: missing unlock on error path

On 05/07/2010 10:37 AM, Dan Carpenter wrote: > There was a missing mutex_unlock(&dev->struct_mutex) on this error path. > > Signed-off-by: Dan Carpenter > --- > I thought Jiri sent this patch earlier but a google search for "stanse > struct_mutex i965_reset" didn't find any patches, so I'm resend

[patch -next] i915: remove unneeded null checks

The "encoder" variable can never be null because it is used as loop cursor in a list_for_each_entry() loop. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index f6299bb..950dc8d 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/driver